mgorny added a reviewer: ZeGentzy.
mgorny marked an inline comment as done.
mgorny added inline comments.
================
Comment at: lldb/scripts/get_relative_lib_dir.py:26
split_libdir = arch_specific_libdir.split(os.sep)
- lib_re = re.compile(r"^lib.+$")
+ lib_re = re.compile(r"^lib.*$")
----------------
hhb wrote:
> If we go this way, should we always use LLDB_PYTHON_RELATIVE_LIBDIR in
> ScriptInterpreterPython.cpp, and add some code to make sure it is defined?
> Because all assumption of the path can be wrong.
>
> After the change here, I think POSIX will always use
> LLDB_PYTHON_RELATIVE_LIBDIR. But for windows, the path is still hard coded to
> lib/site-packages.
>
> (maybe finishSwigPythonLLDB.py / make_symlink() can also be updated to use
> os.path.relpath? )
Actually, I think we can kill all this logic by simply passing `''` as prefix,
as I did in the CMake part.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67890/new/
https://reviews.llvm.org/D67890
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
