hhb accepted this revision. hhb added inline comments. This revision is now accepted and ready to land.
================ Comment at: lldb/include/lldb/Host/windows/PosixApi.h:39 #endif +#ifndef S_IRGRP #define S_IRGRP 0 /* read, group */ ---------------- Maybe move these into the defined(_MSC_VER) above? Or the other way? Seems they should be consistent. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67910/new/ https://reviews.llvm.org/D67910 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits