[GitHub] [maven-gh-actions-shared] olamy closed pull request #54: clean local repo as well to be sure we do not lock files

2023-02-28 Thread via GitHub
olamy closed pull request #54: clean local repo as well to be sure we do not lock files URL: https://github.com/apache/maven-gh-actions-shared/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-shade-plugin] dependabot[bot] opened a new pull request, #177: Bump mavenVersion from 3.2.5 to 3.8.7

2023-02-28 Thread via GitHub
dependabot[bot] opened a new pull request, #177: URL: https://github.com/apache/maven-shade-plugin/pull/177 Bumps `mavenVersion` from 3.2.5 to 3.8.7. Updates `maven-plugin-api` from 3.2.5 to 3.8.7 Release notes Sourced from https://github.com/apache/maven/releases";>maven-plugin-

[GitHub] [maven-site-plugin] dependabot[bot] opened a new pull request, #130: Bump jettyVersion from 9.4.50.v20221201 to 9.4.51.v20230217

2023-02-28 Thread via GitHub
dependabot[bot] opened a new pull request, #130: URL: https://github.com/apache/maven-site-plugin/pull/130 Bumps `jettyVersion` from 9.4.50.v20221201 to 9.4.51.v20230217. Updates `jetty-server` from 9.4.50.v20221201 to 9.4.51.v20230217 Release notes Sourced from https://github.co

[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request, #148: Bump maven-invoker-plugin from 3.2.2 to 3.5.0

2023-02-28 Thread via GitHub
dependabot[bot] opened a new pull request, #148: URL: https://github.com/apache/maven-jlink-plugin/pull/148 Bumps [maven-invoker-plugin](https://github.com/apache/maven-invoker-plugin) from 3.2.2 to 3.5.0. Release notes Sourced from https://github.com/apache/maven-invoker-plugin/re

[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request, #149: Bump maven-plugins from 34 to 39

2023-02-28 Thread via GitHub
dependabot[bot] opened a new pull request, #149: URL: https://github.com/apache/maven-jlink-plugin/pull/149 Bumps [maven-plugins](https://github.com/apache/maven-parent) from 34 to 39. Release notes Sourced from https://github.com/apache/maven-parent/releases";>maven-plugins's rele

[GitHub] [maven-wrapper] slawekjaranowski merged pull request #92: [MWRAPPER-96] Require Maven 3.2.5

2023-02-28 Thread via GitHub
slawekjaranowski merged PR #92: URL: https://github.com/apache/maven-wrapper/pull/92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [maven-resolver] gnodet commented on a diff in pull request #255: [MRESOLVER-328] SSL insecure mode

2023-02-28 Thread via GitHub
gnodet commented on code in PR #255: URL: https://github.com/apache/maven-resolver/pull/255#discussion_r1121267926 ## maven-resolver-api/src/main/java/org/eclipse/aether/ConfigurationProperties.java: ## @@ -144,6 +144,22 @@ public final class ConfigurationProperties { */

[GitHub] [maven-resolver] cstamas merged pull request #256: [MRESOLVER-315] Preemptive auth

2023-02-28 Thread via GitHub
cstamas merged PR #256: URL: https://github.com/apache/maven-resolver/pull/256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

[GitHub] [maven-resolver] cstamas merged pull request #258: [MRESOLVER-330] Introduce file-static name mapper

2023-02-28 Thread via GitHub
cstamas merged PR #258: URL: https://github.com/apache/maven-resolver/pull/258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #261: [MRESOLVER-333] Better errors about artifact availability

2023-02-28 Thread via GitHub
cstamas commented on code in PR #261: URL: https://github.com/apache/maven-resolver/pull/261#discussion_r1121282495 ## maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactResolutionException.java: ## @@ -96,21 +97,28 @@ private static String getMessage(List re

[GitHub] [maven-resolver] cstamas merged pull request #261: [MRESOLVER-333] Better errors about artifact availability

2023-02-28 Thread via GitHub
cstamas merged PR #261: URL: https://github.com/apache/maven-resolver/pull/261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

[GitHub] [maven] gnodet opened a new pull request, #1019: Fix mutable api in PluginContainer

2023-03-01 Thread via GitHub
gnodet opened a new pull request, #1019: URL: https://github.com/apache/maven/pull/1019 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the

[GitHub] [maven] gnodet commented on a diff in pull request #998: Using Set<>() for contains()

2023-03-01 Thread via GitHub
gnodet commented on code in PR #998: URL: https://github.com/apache/maven/pull/998#discussion_r1121322576 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -69,8 +61,12 @@ class ReactorReader implements MavenWorkspaceReader { public static final Strin

[GitHub] [maven] michael-o commented on a diff in pull request #1015: Prefer Java standard library to Plexus util

2023-03-01 Thread via GitHub
michael-o commented on code in PR #1015: URL: https://github.com/apache/maven/pull/1015#discussion_r1121326348 ## maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java: ## @@ -60,7 +59,7 @@ public void validate(Settings settings,

[GitHub] [maven] michael-o commented on a diff in pull request #998: Using Set<>() for contains()

2023-03-01 Thread via GitHub
michael-o commented on code in PR #998: URL: https://github.com/apache/maven/pull/998#discussion_r1121326811 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -69,8 +61,12 @@ class ReactorReader implements MavenWorkspaceReader { public static final St

[GitHub] [maven-resolver] michael-o commented on pull request #255: [MRESOLVER-328] SSL insecure mode

2023-03-01 Thread via GitHub
michael-o commented on PR #255: URL: https://github.com/apache/maven-resolver/pull/255#issuecomment-1449548282 > IMHO, having it in doco is completely enough, as on reported issue (and "smaller shops"), they may work with self signed certs, and we would just "punish" them by logging a warni

[GitHub] [maven-resolver] michael-o commented on a diff in pull request #255: [MRESOLVER-328] SSL insecure mode

2023-03-01 Thread via GitHub
michael-o commented on code in PR #255: URL: https://github.com/apache/maven-resolver/pull/255#discussion_r1121339099 ## maven-resolver-transport-http/src/test/java/org/eclipse/aether/transport/http/HttpServer.java: ## @@ -136,9 +136,17 @@ public String getHttpsUrl() { }

[GitHub] [maven-resolver] michael-o commented on a diff in pull request #255: [MRESOLVER-328] SSL insecure mode

2023-03-01 Thread via GitHub
michael-o commented on code in PR #255: URL: https://github.com/apache/maven-resolver/pull/255#discussion_r1121339701 ## maven-resolver-transport-http/src/test/java/org/eclipse/aether/transport/http/HttpTransporterTest.java: ## @@ -395,6 +395,27 @@ public void testGet_SSL() thro

[GitHub] [maven] gnodet commented on a diff in pull request #998: Using Set<>() for contains()

2023-03-01 Thread via GitHub
gnodet commented on code in PR #998: URL: https://github.com/apache/maven/pull/998#discussion_r1121340937 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -69,8 +70,12 @@ class ReactorReader implements MavenWorkspaceReader { public static final Strin

[GitHub] [maven] gnodet commented on a diff in pull request #998: Using Set<>() for contains()

2023-03-01 Thread via GitHub
gnodet commented on code in PR #998: URL: https://github.com/apache/maven/pull/998#discussion_r1121341538 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -69,8 +70,12 @@ class ReactorReader implements MavenWorkspaceReader { public static final Strin

[GitHub] [maven-resolver] michael-o commented on a diff in pull request #255: [MRESOLVER-328] SSL insecure mode

2023-03-01 Thread via GitHub
michael-o commented on code in PR #255: URL: https://github.com/apache/maven-resolver/pull/255#discussion_r1121341642 ## src/site/markdown/configuration.md: ## @@ -40,6 +40,7 @@ Option | Type | Description | Default Value | Supports Repo ID Suffix `aether.connector.http.preemp

[GitHub] [maven] gnodet commented on a diff in pull request #995: [MNG-6869] New flag to verify Maven installation status

2023-03-01 Thread via GitHub
gnodet commented on code in PR #995: URL: https://github.com/apache/maven/pull/995#discussion_r1121345217 ## maven-core/src/main/java/org/apache/maven/internal/impl/DefaultArtifactCoordinate.java: ## @@ -30,11 +31,11 @@ * A wrapper class around a maven resolver artifact. */

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #255: [MRESOLVER-328] SSL insecure mode

2023-03-01 Thread via GitHub
cstamas commented on code in PR #255: URL: https://github.com/apache/maven-resolver/pull/255#discussion_r1121364807 ## src/site/markdown/configuration.md: ## @@ -40,6 +40,7 @@ Option | Type | Description | Default Value | Supports Repo ID Suffix `aether.connector.http.preempti

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #255: [MRESOLVER-328] SSL insecure mode

2023-03-01 Thread via GitHub
cstamas commented on code in PR #255: URL: https://github.com/apache/maven-resolver/pull/255#discussion_r1121366391 ## maven-resolver-transport-http/src/test/java/org/eclipse/aether/transport/http/HttpTransporterTest.java: ## @@ -395,6 +395,27 @@ public void testGet_SSL() throws

[GitHub] [maven-resolver] michael-o commented on a diff in pull request #255: [MRESOLVER-328] SSL insecure mode

2023-03-01 Thread via GitHub
michael-o commented on code in PR #255: URL: https://github.com/apache/maven-resolver/pull/255#discussion_r1121368246 ## src/site/markdown/configuration.md: ## @@ -40,6 +40,7 @@ Option | Type | Description | Default Value | Supports Repo ID Suffix `aether.connector.http.preemp

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #255: [MRESOLVER-328] SSL insecure mode

2023-03-01 Thread via GitHub
cstamas commented on code in PR #255: URL: https://github.com/apache/maven-resolver/pull/255#discussion_r1121373386 ## src/site/markdown/configuration.md: ## @@ -40,6 +40,7 @@ Option | Type | Description | Default Value | Supports Repo ID Suffix `aether.connector.http.preempti

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #255: [MRESOLVER-328] SSL insecure mode

2023-03-01 Thread via GitHub
cstamas commented on code in PR #255: URL: https://github.com/apache/maven-resolver/pull/255#discussion_r1121375206 ## src/site/markdown/configuration.md: ## @@ -40,6 +40,7 @@ Option | Type | Description | Default Value | Supports Repo ID Suffix `aether.connector.http.preempti

[GitHub] [maven-ear-plugin] dependabot[bot] opened a new pull request, #86: Bump plexus-io from 3.4.0 to 3.4.1

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #86: URL: https://github.com/apache/maven-ear-plugin/pull/86 Bumps [plexus-io](https://github.com/codehaus-plexus/plexus-io) from 3.4.0 to 3.4.1. Release notes Sourced from https://github.com/codehaus-plexus/plexus-io/releases";>plexus-io'

[GitHub] [maven-ear-plugin] dependabot[bot] commented on pull request #85: Bump plexus-archiver from 4.5.0 to 4.6.1

2023-03-01 Thread via GitHub
dependabot[bot] commented on PR #85: URL: https://github.com/apache/maven-ear-plugin/pull/85#issuecomment-144968 Superseded by #87. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [maven-ear-plugin] dependabot[bot] closed pull request #85: Bump plexus-archiver from 4.5.0 to 4.6.1

2023-03-01 Thread via GitHub
dependabot[bot] closed pull request #85: Bump plexus-archiver from 4.5.0 to 4.6.1 URL: https://github.com/apache/maven-ear-plugin/pull/85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-ear-plugin] dependabot[bot] opened a new pull request, #87: Bump plexus-archiver from 4.5.0 to 4.6.2

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #87: URL: https://github.com/apache/maven-ear-plugin/pull/87 Bumps [plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 4.5.0 to 4.6.2. Release notes Sourced from https://github.com/codehaus-plexus/plexus-archiver/rel

[GitHub] [maven-resolver] michael-o commented on a diff in pull request #255: [MRESOLVER-328] SSL insecure mode

2023-03-01 Thread via GitHub
michael-o commented on code in PR #255: URL: https://github.com/apache/maven-resolver/pull/255#discussion_r1121393109 ## maven-resolver-transport-http/src/test/java/org/eclipse/aether/transport/http/HttpServer.java: ## @@ -136,9 +136,17 @@ public String getHttpsUrl() { }

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #255: [MRESOLVER-328] SSL insecure mode

2023-03-01 Thread via GitHub
cstamas commented on code in PR #255: URL: https://github.com/apache/maven-resolver/pull/255#discussion_r1121403410 ## maven-resolver-api/src/main/java/org/eclipse/aether/ConfigurationProperties.java: ## @@ -144,6 +144,22 @@ public final class ConfigurationProperties { */

[GitHub] [maven] tbw777 commented on a diff in pull request #998: Using Set<>() for contains()

2023-03-01 Thread via GitHub
tbw777 commented on code in PR #998: URL: https://github.com/apache/maven/pull/998#discussion_r1121405591 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -69,8 +70,12 @@ class ReactorReader implements MavenWorkspaceReader { public static final Strin

[GitHub] [maven] Thomas-Bergmann commented on a diff in pull request #929: [MNG-7559] Fix version comparison (master 4.0.x branch)

2023-03-01 Thread via GitHub
Thomas-Bergmann commented on code in PR #929: URL: https://github.com/apache/maven/pull/929#discussion_r1121421815 ## maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java: ## @@ -346,4 +342,22 @@ public void testReuse() { assert

[GitHub] [maven] cstamas opened a new pull request, #1020: [MNG-7713] Drop legacy-local-repository option

2023-03-01 Thread via GitHub
cstamas opened a new pull request, #1020: URL: https://github.com/apache/maven/pull/1020 There is really no need for it, and there is a resolver option if really must (but really should not, local repo is and should be considered as transient). --- https://issues.apache.org/ji

[GitHub] [maven] Thomas-Bergmann commented on a diff in pull request #929: [MNG-7559] Fix version comparison (master 4.0.x branch)

2023-03-01 Thread via GitHub
Thomas-Bergmann commented on code in PR #929: URL: https://github.com/apache/maven/pull/929#discussion_r1121421815 ## maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java: ## @@ -346,4 +342,22 @@ public void testReuse() { assert

[GitHub] [maven] Thomas-Bergmann commented on a diff in pull request #929: [MNG-7559] Fix version comparison (master 4.0.x branch)

2023-03-01 Thread via GitHub
Thomas-Bergmann commented on code in PR #929: URL: https://github.com/apache/maven/pull/929#discussion_r1121421815 ## maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java: ## @@ -346,4 +342,22 @@ public void testReuse() { assert

[GitHub] [maven-assembly-plugin] cstamas commented on a diff in pull request #113: [MASSEMBLY-974] Drop deprecated repository element

2023-03-01 Thread via GitHub
cstamas commented on code in PR #113: URL: https://github.com/apache/maven-assembly-plugin/pull/113#discussion_r1121440787 ## src/main/mdo/assembly.mdo: ## @@ -226,7 +226,7 @@ repositories Review Comment: removed -- This is an automated me

[GitHub] [maven] michael-o commented on a diff in pull request #1020: [MNG-7713] Drop legacy-local-repository option

2023-03-01 Thread via GitHub
michael-o commented on code in PR #1020: URL: https://github.com/apache/maven/pull/1020#discussion_r1121456848 ## maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java: ## @@ -443,12 +443,20 @@ public interface MavenExecutionRequest { /** *

[GitHub] [maven] cstamas commented on a diff in pull request #1020: [MNG-7713] Drop legacy-local-repository option

2023-03-01 Thread via GitHub
cstamas commented on code in PR #1020: URL: https://github.com/apache/maven/pull/1020#discussion_r1121464442 ## maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java: ## @@ -443,12 +443,20 @@ public interface MavenExecutionRequest { /** * @s

[GitHub] [maven] michael-o commented on a diff in pull request #1020: [MNG-7713] Drop legacy-local-repository option

2023-03-01 Thread via GitHub
michael-o commented on code in PR #1020: URL: https://github.com/apache/maven/pull/1020#discussion_r1121469512 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -843,13 +842,6 @@ private void encryption(CliRequest cliRequest) throws Exception {

[GitHub] [maven] cstamas merged pull request #1020: [MNG-7713] Drop legacy-local-repository option

2023-03-01 Thread via GitHub
cstamas merged PR #1020: URL: https://github.com/apache/maven/pull/1020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

[GitHub] [maven] cstamas merged pull request #1018: [maven-3.9.x] [MNG-7713] Drop legacy-local-repository option

2023-03-01 Thread via GitHub
cstamas merged PR #1018: URL: https://github.com/apache/maven/pull/1018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

[GitHub] [maven] gnodet merged pull request #1001: [3.9.x][MNG-7583] Allow concurrent access to the MavenPluginManager

2023-03-01 Thread via GitHub
gnodet merged PR #1001: URL: https://github.com/apache/maven/pull/1001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

[GitHub] [maven] sultan commented on a diff in pull request #929: [MNG-7559] Fix version comparison (master 4.0.x branch)

2023-03-01 Thread via GitHub
sultan commented on code in PR #929: URL: https://github.com/apache/maven/pull/929#discussion_r1121522502 ## maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java: ## @@ -346,4 +342,22 @@ public void testReuse() { assertEquals(c1

[GitHub] [maven] sultan commented on a diff in pull request #929: [MNG-7559] Fix version comparison (master 4.0.x branch)

2023-03-01 Thread via GitHub
sultan commented on code in PR #929: URL: https://github.com/apache/maven/pull/929#discussion_r1121522502 ## maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java: ## @@ -346,4 +342,22 @@ public void testReuse() { assertEquals(c1

[GitHub] [maven] sultan commented on a diff in pull request #929: [MNG-7559] Fix version comparison (master 4.0.x branch)

2023-03-01 Thread via GitHub
sultan commented on code in PR #929: URL: https://github.com/apache/maven/pull/929#discussion_r1121522502 ## maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java: ## @@ -346,4 +342,22 @@ public void testReuse() { assertEquals(c1

[GitHub] [maven] cstamas opened a new pull request, #1021: [MNG-7713] Make Maven fail if option present

2023-03-01 Thread via GitHub
cstamas opened a new pull request, #1021: URL: https://github.com/apache/maven/pull/1021 As with previous PR (simple removal) the `-llr` got interpreted as `-l lr`, it logged all output to `lr` file. This would maean that use of `-llr` would still sneakily 'work' and probably cause surprise

[GitHub] [maven-compiler-plugin] cstamas commented on a diff in pull request #180: [MCOMPILER-391] Use dep mgmt when resolving annotation processors and their deps

2023-03-01 Thread via GitHub
cstamas commented on code in PR #180: URL: https://github.com/apache/maven-compiler-plugin/pull/180#discussion_r1121549459 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -330,6 +335,22 @@ public abstract class AbstractCompilerMojo extends Ab

[GitHub] [maven] slawekjaranowski commented on a diff in pull request #1021: [MNG-7713] Make Maven fail if option present

2023-03-01 Thread via GitHub
slawekjaranowski commented on code in PR #1021: URL: https://github.com/apache/maven/pull/1021#discussion_r1121551376 ## maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java: ## @@ -280,6 +280,12 @@ public CLIManager() { .desc("Ineffective, only kep

[GitHub] [maven] cstamas commented on a diff in pull request #1021: [MNG-7713] Make Maven fail if option present

2023-03-01 Thread via GitHub
cstamas commented on code in PR #1021: URL: https://github.com/apache/maven/pull/1021#discussion_r1121553055 ## maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java: ## @@ -280,6 +280,12 @@ public CLIManager() { .desc("Ineffective, only kept for bac

[GitHub] [maven] elharo commented on a diff in pull request #1015: Prefer Java standard library to Plexus util

2023-03-01 Thread via GitHub
elharo commented on code in PR #1015: URL: https://github.com/apache/maven/pull/1015#discussion_r1121552266 ## maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java: ## @@ -60,7 +59,7 @@ public void validate(Settings settings, S

[GitHub] [maven] elharo commented on pull request #1015: Prefer Java standard library to Plexus util

2023-03-01 Thread via GitHub
elharo commented on PR #1015: URL: https://github.com/apache/maven/pull/1015#issuecomment-1449935370 Yes, I would like to remove all references to remove all references to org.codehaus.plexus.utils.StringUtils. In fact I would like to remove all references to remove all references to org.co

[GitHub] [maven-compiler-plugin] psiroky commented on a diff in pull request #180: [MCOMPILER-391] Use dep mgmt when resolving annotation processors and their deps

2023-03-01 Thread via GitHub
psiroky commented on code in PR #180: URL: https://github.com/apache/maven-compiler-plugin/pull/180#discussion_r1121557872 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -330,6 +335,22 @@ public abstract class AbstractCompilerMojo extends Ab

[GitHub] [maven-compiler-plugin] psiroky commented on a diff in pull request #180: [MCOMPILER-391] Use dep mgmt when resolving annotation processors and their deps

2023-03-01 Thread via GitHub
psiroky commented on code in PR #180: URL: https://github.com/apache/maven-compiler-plugin/pull/180#discussion_r1121558571 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -330,6 +335,22 @@ public abstract class AbstractCompilerMojo extends Ab

[GitHub] [maven-compiler-plugin] psiroky commented on a diff in pull request #180: [MCOMPILER-391] Use dep mgmt when resolving annotation processors and their deps

2023-03-01 Thread via GitHub
psiroky commented on code in PR #180: URL: https://github.com/apache/maven-compiler-plugin/pull/180#discussion_r1121560964 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -1584,42 +1605,91 @@ private List resolveProcessorPathEntries() throws

[GitHub] [maven-shared-utils] elharo commented on a diff in pull request #123: [MSHARED-1172] Deprecate redundant isEmptyString method

2023-03-01 Thread via GitHub
elharo commented on code in PR #123: URL: https://github.com/apache/maven-shared-utils/pull/123#discussion_r1059790076 ## src/main/java/org/apache/maven/shared/utils/xml/Xpp3DomUtils.java: ## @@ -148,15 +148,15 @@ private static boolean isMergeChildren( Xpp3Dom dominant )

[GitHub] [maven-compiler-plugin] psiroky commented on a diff in pull request #180: [MCOMPILER-391] Use dep mgmt when resolving annotation processors and their deps

2023-03-01 Thread via GitHub
psiroky commented on code in PR #180: URL: https://github.com/apache/maven-compiler-plugin/pull/180#discussion_r1121566199 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -1584,42 +1605,91 @@ private List resolveProcessorPathEntries() throws

[GitHub] [maven-compiler-plugin] psiroky commented on a diff in pull request #180: [MCOMPILER-391] Use dep mgmt when resolving annotation processors and their deps

2023-03-01 Thread via GitHub
psiroky commented on code in PR #180: URL: https://github.com/apache/maven-compiler-plugin/pull/180#discussion_r1121568151 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -330,6 +335,22 @@ public abstract class AbstractCompilerMojo extends Ab

[GitHub] [maven-compiler-plugin] psiroky commented on pull request #180: [MCOMPILER-391] Use dep mgmt when resolving annotation processors and their deps

2023-03-01 Thread via GitHub
psiroky commented on PR #180: URL: https://github.com/apache/maven-compiler-plugin/pull/180#issuecomment-1449955799 I decided to proceed with the suggested solution. The PR now contains changes for both use cases: 1. using dependency management to get just the top-level annotation proc

[GitHub] [maven-compiler-plugin] psiroky commented on a diff in pull request #180: [MCOMPILER-391] Use dep mgmt when resolving annotation processors and their deps

2023-03-01 Thread via GitHub
psiroky commented on code in PR #180: URL: https://github.com/apache/maven-compiler-plugin/pull/180#discussion_r1121557872 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -330,6 +335,22 @@ public abstract class AbstractCompilerMojo extends Ab

[GitHub] [maven-doxia] kwin merged pull request #146: Bugfix/newlines

2023-03-01 Thread via GitHub
kwin merged PR #146: URL: https://github.com/apache/maven-doxia/pull/146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache

[GitHub] [maven-doxia] elharo commented on pull request #149: Prefer Apache commons IO to codehaus

2023-03-01 Thread via GitHub
elharo commented on PR #149: URL: https://github.com/apache/maven-doxia/pull/149#issuecomment-1449987139 org.apache.commons.lang3.StringUtils is used. However in this case it's a drop-in replacement for codehaus.plexus StringUtils — e.g. in line 2381 of AptParser — so only the import statem

[GitHub] [maven-doxia] michael-o commented on a diff in pull request #149: Prefer Apache commons IO to codehaus

2023-03-01 Thread via GitHub
michael-o commented on code in PR #149: URL: https://github.com/apache/maven-doxia/pull/149#discussion_r1121591874 ## doxia-modules/doxia-module-xdoc/src/main/java/org/apache/maven/doxia/module/xdoc/XdocParser.java: ## @@ -333,7 +330,7 @@ private void handleMetaStart(XmlPullPars

[GitHub] [maven-compiler-plugin] psiroky commented on a diff in pull request #180: [MCOMPILER-391] Use dep mgmt when resolving annotation processors and their deps

2023-03-01 Thread via GitHub
psiroky commented on code in PR #180: URL: https://github.com/apache/maven-compiler-plugin/pull/180#discussion_r1121595369 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -1604,22 +1606,39 @@ private List resolveProcessorPathEntries() throws

[GitHub] [maven] cstamas merged pull request #1021: [MNG-7713] Make Maven fail if option present

2023-03-01 Thread via GitHub
cstamas merged PR #1021: URL: https://github.com/apache/maven/pull/1021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

[GitHub] [maven] cstamas opened a new pull request, #1022: [MNG-7713] Make Maven fail if option present (#1021)

2023-03-01 Thread via GitHub
cstamas opened a new pull request, #1022: URL: https://github.com/apache/maven/pull/1022 As with previous PR (simple removal) the `-llr` got interpreted as `-l lr`, it logged all output to `lr` file. This would maean that use of `-llr` would still sneakily 'work' and probably cause surprise

[GitHub] [maven] cstamas merged pull request #1022: [MNG-7713] Make Maven fail if option present (#1021)

2023-03-01 Thread via GitHub
cstamas merged PR #1022: URL: https://github.com/apache/maven/pull/1022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

[GitHub] [maven-doxia] elharo commented on a diff in pull request #149: Prefer Apache commons IO to codehaus

2023-03-01 Thread via GitHub
elharo commented on code in PR #149: URL: https://github.com/apache/maven-doxia/pull/149#discussion_r1121726597 ## doxia-modules/doxia-module-xdoc/src/main/java/org/apache/maven/doxia/module/xdoc/XdocParser.java: ## @@ -333,7 +330,7 @@ private void handleMetaStart(XmlPullParser

[GitHub] [maven-mvnd] guylabs commented on pull request #797: Add property to disable model caching

2023-03-01 Thread via GitHub
guylabs commented on PR #797: URL: https://github.com/apache/maven-mvnd/pull/797#issuecomment-1450242173 @ppalaga Would that be something that you can add for us? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-mvnd] ppalaga commented on pull request #797: Add property to disable model caching

2023-03-01 Thread via GitHub
ppalaga commented on PR #797: URL: https://github.com/apache/maven-mvnd/pull/797#issuecomment-1450418416 @gnodet didn't we have a property for disabling caching for specific artifacts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [maven] gnodet opened a new pull request, #1023: [MNG-7709] Regression in configuration merge

2023-03-01 Thread via GitHub
gnodet opened a new pull request, #1023: URL: https://github.com/apache/maven/pull/1023 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the

[GitHub] [maven] cstamas opened a new pull request, #1024: [maven-3.9.x][MNG-7710] Upgrade plexus-utils

2023-03-01 Thread via GitHub
cstamas opened a new pull request, #1024: URL: https://github.com/apache/maven/pull/1024 (when the fixed release is done, this is just a placeholder) --- https://issues.apache.org/jira/browse/MNG-7710 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [maven-mvnd] oehme commented on pull request #797: Add property to disable model caching

2023-03-01 Thread via GitHub
oehme commented on PR #797: URL: https://github.com/apache/maven-mvnd/pull/797#issuecomment-1450502370 @ppalaga you have a property for[ reloading certain class realms](https://github.com/apache/maven-mvnd/blob/b97f585c0915c6ec5525f752b575c40e09ce297c/common/src/main/java/org/mvndaemon/mvnd/

[GitHub] [maven-mvnd] ppalaga commented on pull request #797: Add property to disable model caching

2023-03-01 Thread via GitHub
ppalaga commented on PR #797: URL: https://github.com/apache/maven-mvnd/pull/797#issuecomment-1450557202 > you have a property for reloading certain class realms (e.g. for plugins that hold static state). But nothing for the model cache. Thanks for explaining @oehme! That's exactly, w

[GitHub] [maven-mvnd] ppalaga commented on a diff in pull request #797: Add property to disable model caching

2023-03-01 Thread via GitHub
ppalaga commented on code in PR #797: URL: https://github.com/apache/maven-mvnd/pull/797#discussion_r1122109132 ## daemon/src/main/java/org/apache/maven/project/SnapshotModelCacheFactory.java: ## @@ -45,6 +45,9 @@ public SnapshotModelCacheFactory(DefaultModelCacheFactory factor

[GitHub] [maven-mvnd] oehme commented on a diff in pull request #797: Add property to disable model caching

2023-03-01 Thread via GitHub
oehme commented on code in PR #797: URL: https://github.com/apache/maven-mvnd/pull/797#discussion_r1122150631 ## daemon/src/main/java/org/apache/maven/project/SnapshotModelCacheFactory.java: ## @@ -45,6 +45,9 @@ public SnapshotModelCacheFactory(DefaultModelCacheFactory factory)

[GitHub] [maven] cstamas opened a new pull request, #1025: [MNG-7715] Update to resolver 1.9.6

2023-03-01 Thread via GitHub
cstamas opened a new pull request, #1025: URL: https://github.com/apache/maven/pull/1025 Update and apply some adjustments to UTs as error message did change. --- https://issues.apache.org/jira/browse/MNG-7715 -- This is an automated message from the Apache Git Service. To

[GitHub] [maven-doxia] kwin commented on pull request #152: [DOXIA-699] Add failing test case

2023-03-01 Thread via GitHub
kwin commented on PR #152: URL: https://github.com/apache/maven-doxia/pull/152#issuecomment-1450744459 @michael-o Can you have a look why this test fails? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [maven-compiler-plugin] psiroky commented on pull request #180: [MCOMPILER-391] Use dep mgmt when resolving annotation processors and their deps

2023-03-01 Thread via GitHub
psiroky commented on PR #180: URL: https://github.com/apache/maven-compiler-plugin/pull/180#issuecomment-1450781593 I ran a quick performance test using the Quarkus repo (1k modules, where 500 of them are using annotation processors) and I could not really spot any noticeable difference in

[GitHub] [maven-resolver] slawekjaranowski opened a new pull request, #262: [MRESOLVER-337] Real cause when artifact not found with repository filtering

2023-03-01 Thread via GitHub
slawekjaranowski opened a new pull request, #262: URL: https://github.com/apache/maven-resolver/pull/262 When we use remote repository filtering real cause for artifact not found may be hidden. https://issues.apache.org/jira/browse/MRESOLVER-337 -- This is an automated message from

[GitHub] [maven-dependency-plugin] dependabot[bot] opened a new pull request, #289: Bump plexus-archiver from 4.6.0 to 4.6.2

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #289: URL: https://github.com/apache/maven-dependency-plugin/pull/289 Bumps [plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 4.6.0 to 4.6.2. Release notes Sourced from https://github.com/codehaus-plexus/plexus-arc

[GitHub] [maven-dependency-plugin] dependabot[bot] commented on pull request #278: Bump plexus-archiver from 4.6.0 to 4.6.1

2023-03-01 Thread via GitHub
dependabot[bot] commented on PR #278: URL: https://github.com/apache/maven-dependency-plugin/pull/278#issuecomment-1450978454 Superseded by #289. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-dependency-plugin] dependabot[bot] closed pull request #278: Bump plexus-archiver from 4.6.0 to 4.6.1

2023-03-01 Thread via GitHub
dependabot[bot] closed pull request #278: Bump plexus-archiver from 4.6.0 to 4.6.1 URL: https://github.com/apache/maven-dependency-plugin/pull/278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven] elharo merged pull request #1014: [MNG-7700] test some edge cases with leading zeroes

2023-03-01 Thread via GitHub
elharo merged PR #1014: URL: https://github.com/apache/maven/pull/1014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

[GitHub] [maven-wrapper] dependabot[bot] opened a new pull request, #93: Bump plexus-archiver from 4.6.1 to 4.6.2

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #93: URL: https://github.com/apache/maven-wrapper/pull/93 Bumps [plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 4.6.1 to 4.6.2. Release notes Sourced from https://github.com/codehaus-plexus/plexus-archiver/releas

[GitHub] [maven-jar-plugin] dependabot[bot] opened a new pull request, #61: Bump plexus-utils from 3.4.2 to 3.5.1

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #61: URL: https://github.com/apache/maven-jar-plugin/pull/61 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.2 to 3.5.1. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases";>p

[GitHub] [maven-jar-plugin] dependabot[bot] commented on pull request #54: Bump plexus-utils from 3.4.2 to 3.5.0

2023-03-01 Thread via GitHub
dependabot[bot] commented on PR #54: URL: https://github.com/apache/maven-jar-plugin/pull/54#issuecomment-1451205070 Superseded by #61. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [maven-jar-plugin] dependabot[bot] closed pull request #54: Bump plexus-utils from 3.4.2 to 3.5.0

2023-03-01 Thread via GitHub
dependabot[bot] closed pull request #54: Bump plexus-utils from 3.4.2 to 3.5.0 URL: https://github.com/apache/maven-jar-plugin/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [maven] olamy commented on a diff in pull request #1024: [maven-3.9.x][MNG-7710] Upgrade plexus-utils to 3.5.1

2023-03-01 Thread via GitHub
olamy commented on code in PR #1024: URL: https://github.com/apache/maven/pull/1024#discussion_r1122590010 ## pom.xml: ## @@ -135,7 +135,7 @@ under the License. 2.1.0 1.26 -3.3.1 +3.5.0 Review Comment: ```suggestion 3.5.1 ``` -- This is

[GitHub] [maven-site-plugin] dependabot[bot] opened a new pull request, #131: Bump plexus-utils from 3.5.0 to 3.5.1

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #131: URL: https://github.com/apache/maven-site-plugin/pull/131 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.5.0 to 3.5.1. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases"

[GitHub] [maven-parent] dependabot[bot] opened a new pull request, #113: Bump plexus-utils from 3.5.0 to 3.5.1

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #113: URL: https://github.com/apache/maven-parent/pull/113 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.5.0 to 3.5.1. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases";>ple

[GitHub] [maven-site-plugin] dependabot[bot] opened a new pull request, #132: Bump plexus-archiver from 4.6.1 to 4.6.2

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #132: URL: https://github.com/apache/maven-site-plugin/pull/132 Bumps [plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 4.6.1 to 4.6.2. Release notes Sourced from https://github.com/codehaus-plexus/plexus-archiver/

[GitHub] [maven-doxia-converter] dependabot[bot] opened a new pull request, #42: Bump plexus-utils from 3.5.0 to 3.5.1

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #42: URL: https://github.com/apache/maven-doxia-converter/pull/42 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.5.0 to 3.5.1. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/release

[GitHub] [maven-dependency-analyzer] dependabot[bot] opened a new pull request, #79: Bump plexus-utils from 3.4.2 to 3.5.1

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #79: URL: https://github.com/apache/maven-dependency-analyzer/pull/79 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.2 to 3.5.1. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/rel

[GitHub] [maven-dependency-analyzer] dependabot[bot] commented on pull request #72: Bump plexus-utils from 3.4.2 to 3.5.0

2023-03-01 Thread via GitHub
dependabot[bot] commented on PR #72: URL: https://github.com/apache/maven-dependency-analyzer/pull/72#issuecomment-1451299205 Superseded by #79. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [maven-dependency-analyzer] dependabot[bot] closed pull request #72: Bump plexus-utils from 3.4.2 to 3.5.0

2023-03-01 Thread via GitHub
dependabot[bot] closed pull request #72: Bump plexus-utils from 3.4.2 to 3.5.0 URL: https://github.com/apache/maven-dependency-analyzer/pull/72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [maven-shade-plugin] dependabot[bot] opened a new pull request, #178: Bump plexus-utils from 3.4.2 to 3.5.1

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #178: URL: https://github.com/apache/maven-shade-plugin/pull/178 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.2 to 3.5.1. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases

[GitHub] [maven-indexer] dependabot[bot] opened a new pull request, #297: Bump plexus-utils from 3.5.0 to 3.5.1

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #297: URL: https://github.com/apache/maven-indexer/pull/297 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.5.0 to 3.5.1. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases";>pl

<    1   2   3   4   5   6   7   8   9   10   >