gnodet commented on code in PR #998:
URL: https://github.com/apache/maven/pull/998#discussion_r1121340937
##########
maven-core/src/main/java/org/apache/maven/ReactorReader.java:
##########
@@ -69,8 +70,12 @@ class ReactorReader implements MavenWorkspaceReader {
public static final String PROJECT_LOCAL_REPO = "project-local-repo";
- private static final Collection<String> COMPILE_PHASE_TYPES =
- Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", "par",
"sar", "wsr", "har", "app-client");
+ private static final Collection<String> COMPILE_PHASE_TYPES;
+
Review Comment:
I'd rather not split the initialisation in a separate block. Can we just
add the `new HashSet<?>(xxx)` around the existing list initially ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
