[GitHub] [maven-doxia] michael-o commented on a diff in pull request #149: Prefer Apache commons IO to codehaus

[via GitHub]

michael-o commented on code in PR #149:
URL: https://github.com/apache/maven-doxia/pull/149#discussion_r1121591874


##########
doxia-modules/doxia-module-xdoc/src/main/java/org/apache/maven/doxia/module/xdoc/XdocParser.java:
##########
@@ -333,7 +330,7 @@ private void handleMetaStart(XmlPullParser parser, Sink 
sink, SinkEventAttribute
 
     private void handleParamStart(XmlPullParser parser, Sink sink) throws 
MacroExecutionException {
         if (!isSecondParsing()) {
-            if (StringUtils.isNotEmpty(macroName)) {
+            if (macroName != null && !macroName.isEmpty()) {
                 String paramName = parser.getAttributeValue(null, 
Attribute.NAME.toString());

Review Comment:
   But why remove these if StringUtils is present?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org