elharo commented on code in PR #123:
URL:
https://github.com/apache/maven-shared-utils/pull/123#discussion_r1059790076
##########
src/main/java/org/apache/maven/shared/utils/xml/Xpp3DomUtils.java:
##########
@@ -148,15 +148,15 @@ private static boolean isMergeChildren( Xpp3Dom dominant )
}
/**
- * @param str The string to be checked.
- * @return <code>true</code> in case string is empty <code>false</code>
otherwise.
+ * @deprecated use <code>str == null || String.isBlank(str)</code> (Java
11+)
Review Comment:
IMHO
JDK > org,apache.commons > Guava > maven-shared-utils > plexus-utils >
random classes where it doesn't belong
Realistically, this method is reinvented so often and so frequently, we'll
never get down to a single version. However this case is particularly
egregious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
