[GitHub] [maven-resolver] cstamas commented on a diff in pull request #255: [MRESOLVER-328] SSL insecure mode

[via GitHub]

cstamas commented on code in PR #255:
URL: https://github.com/apache/maven-resolver/pull/255#discussion_r1121366391


##########
maven-resolver-transport-http/src/test/java/org/eclipse/aether/transport/http/HttpTransporterTest.java:
##########
@@ -395,6 +395,27 @@ public void testGet_SSL() throws Exception {
         assertEquals(task.getDataString(), new 
String(listener.baos.toByteArray(), StandardCharsets.UTF_8));
     }
 
+    @Test
+    public void testGet_SelfSigned_SSL() throws Exception {
+        // client gets all the material removed (and later recreated)
+        System.clearProperty("javax.net.ssl.trustStore");
+        System.clearProperty("javax.net.ssl.trustStorePassword");
+        System.clearProperty("javax.net.ssl.keyStore");
+        System.clearProperty("javax.net.ssl.keyStorePassword");
+        session.setConfigProperty("aether.connector.http.ssl.insecure", true);

Review Comment:
   fixed



##########
maven-resolver-transport-http/src/test/java/org/eclipse/aether/transport/http/HttpServer.java:
##########
@@ -136,9 +136,17 @@ public String getHttpsUrl() {
     }
 
     public HttpServer addSslConnector() {
+        return addSslConnector(true);
+    }
+
+    public HttpServer addSelfSignedSslConnector() {
+        return addSslConnector(false);
+    }

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org