[GitHub] [maven-parent] gnodet closed pull request #136: Upgrade palantir to 2.38.0 to fix JDK 21 support

2023-09-26 Thread via GitHub
gnodet closed pull request #136: Upgrade palantir to 2.38.0 to fix JDK 21 support URL: https://github.com/apache/maven-parent/pull/136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [maven] slawekjaranowski commented on pull request #1262: [MNG-7895] Support ${project.basedir} in file profile activation

2023-09-26 Thread via GitHub
slawekjaranowski commented on PR #1262: URL: https://github.com/apache/maven/pull/1262#issuecomment-1734996131 > > > Hm, now by reading this PR and seeing several places where comment explains why NOT `project.basedir`... it makes me worried, but is LGTM > > > > > > But in other p

[jira] [Commented] (MNG-7895) Support ${project.basedir} in file profile activation

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769047#comment-17769047 ] ASF GitHub Bot commented on MNG-7895: - slawekjaranowski commented on PR #1262: URL: htt

[GitHub] [maven] slawekjaranowski commented on a diff in pull request #1263: Use the same branch name for ITs on Jenkins

2023-09-26 Thread via GitHub
slawekjaranowski commented on code in PR #1263: URL: https://github.com/apache/maven/pull/1263#discussion_r1336766409 ## Jenkinsfile: ## @@ -84,10 +84,21 @@ for (String os in runITsOses) { // will not trample each other plus workaround for JENKINS-52657

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #291: [MENFORCER-492] Bump plexus-utils from 3.5.1 to 4.0.0 and plexus-xml 3.0.0

2023-09-26 Thread via GitHub
slawekjaranowski merged PR #291: URL: https://github.com/apache/maven-enforcer/pull/291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (MENFORCER-492) Bump plexus-utils from 3.5.1 to 4.0.0 and plexus-xml 3.0.0

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769050#comment-17769050 ] ASF GitHub Bot commented on MENFORCER-492: -- slawekjaranowski merged PR #291:

[jira] [Closed] (MENFORCER-492) Bump plexus-utils from 3.5.1 to 4.0.0 and plexus-xml 3.0.0

2023-09-26 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MENFORCER-492. - Resolution: Fixed > Bump plexus-utils from 3.5.1 to 4.0.0 and plexus-xml 3.0.0

[GitHub] [maven-mvnd] timtebeek commented on pull request #882: Removed superfluous public for tests

2023-09-26 Thread via GitHub
timtebeek commented on PR #882: URL: https://github.com/apache/maven-mvnd/pull/882#issuecomment-1735047823 Chiming in to say that if this is something you'd want removed across the board we have a ready made recipe for that at https://docs.openrewrite.org/recipes/java/testing/cleanup/testss

[GitHub] [maven-site] slawekjaranowski merged pull request #449: Improvements to release procedure

2023-09-26 Thread via GitHub
slawekjaranowski merged PR #449: URL: https://github.com/apache/maven-site/pull/449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

[GitHub] [maven-mvnd] ppalaga merged pull request #886: [MNG-6847] Use diamond operator

2023-09-26 Thread via GitHub
ppalaga merged PR #886: URL: https://github.com/apache/maven-mvnd/pull/886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apac

[GitHub] [maven-mvnd] ppalaga commented on pull request #886: [MNG-6847] Use diamond operator

2023-09-26 Thread via GitHub
ppalaga commented on PR #886: URL: https://github.com/apache/maven-mvnd/pull/886#issuecomment-1735316270 Thanks @timtebeek -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769112#comment-17769112 ] ASF GitHub Bot commented on MNG-6847: - ppalaga merged PR #886: URL: https://github.com/

[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769113#comment-17769113 ] ASF GitHub Bot commented on MNG-6847: - ppalaga commented on PR #886: URL: https://githu

[GitHub] [maven-mvnd] timtebeek commented on pull request #886: [MNG-6847] Use diamond operator

2023-09-26 Thread via GitHub
timtebeek commented on PR #886: URL: https://github.com/apache/maven-mvnd/pull/886#issuecomment-173539 Thanks for the merge and good seeing you here; it's been a while since BaselOne last year. Hope you're well! :) -- This is an automated message from the Apache Git Service. To respon

[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769115#comment-17769115 ] ASF GitHub Bot commented on MNG-6847: - timtebeek commented on PR #886: URL: https://git

[GitHub] [maven-mvnd] elharo commented on a diff in pull request #881: Code improvements.

2023-09-26 Thread via GitHub
elharo commented on code in PR #881: URL: https://github.com/apache/maven-mvnd/pull/881#discussion_r1337093736 ## integration-tests/src/test/java/org/mvndaemon/mvnd/it/ResidentExtensionsTest.java: ## @@ -69,8 +69,8 @@ void verify() throws IOException, InterruptedException {

[jira] [Commented] (MNG-7416) Simplify conditional expression.

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769139#comment-17769139 ] ASF GitHub Bot commented on MNG-7416: - elharo commented on code in PR #227: URL: https

[GitHub] [maven-doxia-linkcheck] timtebeek commented on a diff in pull request #10: [MNG-6847] Use diamond operator

2023-09-26 Thread via GitHub
timtebeek commented on code in PR #10: URL: https://github.com/apache/maven-doxia-linkcheck/pull/10#discussion_r1337108391 ## src/main/java/org/apache/maven/doxia/linkcheck/validation/LinkValidationItem.java: ## @@ -91,12 +91,7 @@ public boolean equals( Object obj )

[GitHub] [maven-resolver] elharo merged pull request #333: [MNG-7416] Simplify Boolean expressions and returns

2023-09-26 Thread via GitHub
elharo merged PR #333: URL: https://github.com/apache/maven-resolver/pull/333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.a

[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769144#comment-17769144 ] ASF GitHub Bot commented on MNG-6847: - timtebeek commented on code in PR #10: URL: htt

[jira] [Commented] (MNG-7416) Simplify conditional expression.

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769145#comment-17769145 ] ASF GitHub Bot commented on MNG-7416: - elharo merged PR #333: URL: https://github.com/a

[GitHub] [maven] vivkong commented on a diff in pull request #1239: [MNG-7864] Fix the S390x to use IT branches

2023-09-26 Thread via GitHub
vivkong commented on code in PR #1239: URL: https://github.com/apache/maven/pull/1239#discussion_r1337113488 ## Jenkinsfile.s390x.its: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTI

[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769148#comment-17769148 ] ASF GitHub Bot commented on MNG-7864: - vivkong commented on code in PR #1239: URL: http

[GitHub] [maven] elharo commented on pull request #1264: [MNG-6847] Use diamond operator

2023-09-26 Thread via GitHub
elharo commented on PR #1264: URL: https://github.com/apache/maven/pull/1264#issuecomment-1735427163 Tests might be broken at head. I don't think the failures are caused by this PR but we'll need to resolve that before merging this: Error: Tests run: 3, Failures: 0, Errors: 2, Skippe

[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769149#comment-17769149 ] ASF GitHub Bot commented on MNG-6847: - elharo commented on PR #1264: URL: https://githu

[GitHub] [maven-project-info-reports-plugin] elharo merged pull request #63: [MNG-7416] Simplify Boolean expressions and returns

2023-09-26 Thread via GitHub
elharo merged PR #63: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[jira] [Commented] (MNG-7416) Simplify conditional expression.

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769151#comment-17769151 ] ASF GitHub Bot commented on MNG-7416: - elharo merged PR #63: URL: https://github.com/ap

[GitHub] [maven-site] slawekjaranowski merged pull request #448: Refresh Making GPG Keys page

2023-09-26 Thread via GitHub
slawekjaranowski merged PR #448: URL: https://github.com/apache/maven-site/pull/448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

[jira] [Commented] (MJAVADOC-734) javadoc drops copying doc-files when module-info.java file present

2023-09-26 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769170#comment-17769170 ] Elliotte Rusty Harold commented on MJAVADOC-734: Do you have a reproduc

[jira] [Updated] (MJAVADOC-734) javadoc drops copying doc-files when module-info.java file present

2023-09-26 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MJAVADOC-734: --- Issue Type: Bug (was: Improvement) > javadoc drops copying doc-files when

[GitHub] [maven] slawekjaranowski commented on pull request #1258: Fix unneeded/wrong substring calls in expression evaluation and put back weak references in cache

2023-09-26 Thread via GitHub
slawekjaranowski commented on PR #1258: URL: https://github.com/apache/maven/pull/1258#issuecomment-1735514757 Is it worth doing in 3.9.x also? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #242: Use Maven 3.9.0 on GitHub

2023-09-26 Thread via GitHub
slawekjaranowski commented on PR #242: URL: https://github.com/apache/maven-integration-testing/pull/242#issuecomment-1735520283 > I wouldn't do this before at least 3.9.1, .0 contains too many open issues for now. I hope that 3.9.4 is better than 3.9.1 😄 -- This is an automated

[jira] [Commented] (MCOMPILER-546) Maven compiling fails when using JEP 443

2023-09-26 Thread Vlad Galuska (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769182#comment-17769182 ] Vlad Galuska commented on MCOMPILER-546: [~michael-o] Any update here? > Mave

[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #242: Use Maven 3.9.4 on GitHub

2023-09-26 Thread via GitHub
slawekjaranowski commented on PR #242: URL: https://github.com/apache/maven-integration-testing/pull/242#issuecomment-1735525166 current test are not compatible with 4.0.0-alpha-7, as is alpha version we can change something so 3.9.4 should be ok now We can think about 4.0.0-alpha

[jira] [Created] (MNG-7898) Missing .mvn directory should not be reported in quiet mode

2023-09-26 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MNG-7898: Summary: Missing .mvn directory should not be reported in quiet mode Key: MNG-7898 URL: https://issues.apache.org/jira/browse/MNG-7898 Project: Maven

[GitHub] [maven-plugin-tools] timtebeek commented on a diff in pull request #227: [MNG-7416] Simplify Boolean expressions and returns

2023-09-26 Thread via GitHub
timtebeek commented on code in PR #227: URL: https://github.com/apache/maven-plugin-tools/pull/227#discussion_r1337254040 ## maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/javadoc/JavaJavadocMojoDescriptorExtractor.java: ## @@ -510,7 +510,7 @@ pri

[jira] [Commented] (MNG-7416) Simplify conditional expression.

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769192#comment-17769192 ] ASF GitHub Bot commented on MNG-7416: - timtebeek commented on code in PR #227: URL: ht

[GitHub] [maven] gnodet commented on pull request #1258: Fix unneeded/wrong substring calls in expression evaluation and put back weak references in cache

2023-09-26 Thread via GitHub
gnodet commented on PR #1258: URL: https://github.com/apache/maven/pull/1258#issuecomment-1735598461 > Is it worth doing in 3.9.x also? I don't think so. The substrings have been there since ages and are harmless (because the first part of the string is completely ignored), and the

[jira] [Commented] (MCOMPILER-546) Maven compiling fails when using JEP 443

2023-09-26 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769194#comment-17769194 ] Michael Osipov commented on MCOMPILER-546: -- Should there be one, by whom? >

[GitHub] [maven-plugin-tools] elharo commented on a diff in pull request #227: [MNG-7416] Simplify Boolean expressions and returns

2023-09-26 Thread via GitHub
elharo commented on code in PR #227: URL: https://github.com/apache/maven-plugin-tools/pull/227#discussion_r1337283480 ## maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/javadoc/JavaJavadocMojoDescriptorExtractor.java: ## @@ -510,7 +510,7 @@ privat

[jira] [Commented] (MNG-7416) Simplify conditional expression.

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769204#comment-17769204 ] ASF GitHub Bot commented on MNG-7416: - elharo commented on code in PR #227: URL: https

[jira] [Commented] (MNG-7416) Simplify conditional expression.

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769203#comment-17769203 ] ASF GitHub Bot commented on MNG-7416: - elharo merged PR #227: URL: https://github.com/a

[jira] [Created] (MNG-7899) Various memory usage improvements

2023-09-26 Thread sebastien (Jira)
sebastien created MNG-7899: -- Summary: Various memory usage improvements Key: MNG-7899 URL: https://issues.apache.org/jira/browse/MNG-7899 Project: Maven Issue Type: Improvement Components:

[jira] [Commented] (MNG-7899) Various memory usage improvements

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769235#comment-17769235 ] ASF GitHub Bot commented on MNG-7899: - sebastien-doyon opened a new pull request, #1265

[GitHub] [maven] vivkong opened a new pull request, #1266: [MNG-7848] Add Jenkinsfile.s390x for Jenkins CI on s390x

2023-09-26 Thread via GitHub
vivkong opened a new pull request, #1266: URL: https://github.com/apache/maven/pull/1266 As discussed on https://github.com/apache/maven/pull/1239, we would like to add `Jenkinsfile.s390x` back and re-enable the s390x pipeline on Jenkins CI (https://ci-maven.apache.org/job/Maven/job/Maven%2

[jira] [Commented] (MNG-7848) Add s390x pipeline to Jenkins CI

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769237#comment-17769237 ] ASF GitHub Bot commented on MNG-7848: - vivkong opened a new pull request, #1266: URL: h

[jira] [Commented] (MNG-7899) Various memory usage improvements

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769238#comment-17769238 ] ASF GitHub Bot commented on MNG-7899: - sebastien-doyon opened a new pull request, #1267

[GitHub] [maven] sebastien-doyon opened a new pull request, #1268: [MNG-7899] Various memory usage improvements

2023-09-26 Thread via GitHub
sebastien-doyon opened a new pull request, #1268: URL: https://github.com/apache/maven/pull/1268 Reuse a StringBuilder in a for loop by setting its lenght to zero. Help reduce temporary objects creation. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (MNG-7899) Various memory usage improvements

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769243#comment-17769243 ] ASF GitHub Bot commented on MNG-7899: - sebastien-doyon opened a new pull request, #1268

[GitHub] [maven] sebastien-doyon opened a new pull request, #1269: [MNG-7899] Various memory usage improvements 4

2023-09-26 Thread via GitHub
sebastien-doyon opened a new pull request, #1269: URL: https://github.com/apache/maven/pull/1269 Merging the getStatus() method to optimize : - Use the main StringBuilder to append string instead of using a separate one - Use the StringBuilder.append() with index to avoid String.

[jira] [Commented] (MNG-7899) Various memory usage improvements

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769248#comment-17769248 ] ASF GitHub Bot commented on MNG-7899: - sebastien-doyon opened a new pull request, #1269

[GitHub] [maven-enforcer] dependabot[bot] opened a new pull request, #293: Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.2

2023-09-26 Thread via GitHub
dependabot[bot] opened a new pull request, #293: URL: https://github.com/apache/maven-enforcer/pull/293 Bumps [org.codehaus.plexus:plexus-xml](https://github.com/codehaus-plexus/plexus-xml) from 3.0.0 to 4.0.2. Release notes Sourced from https://github.com/codehaus-plexus/plexus-x

[GitHub] [maven] sebastien-doyon opened a new pull request, #1270: [MNG-7899] Various memory usage improvements

2023-09-26 Thread via GitHub
sebastien-doyon opened a new pull request, #1270: URL: https://github.com/apache/maven/pull/1270 Multiple optimizations : - renderLevel() method use static constants instead of rebuilding the strings on each call - replace + operator usage with more PrintStream.print() calls to r

[jira] [Commented] (MNG-7899) Various memory usage improvements

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769252#comment-17769252 ] ASF GitHub Bot commented on MNG-7899: - sebastien-doyon opened a new pull request, #1270

[GitHub] [maven-build-cache-extension] kbuntrock commented on pull request #92: [MBUILDCACHE-67] Bugfix artefact restoration error not handled properly

2023-09-26 Thread via GitHub
kbuntrock commented on PR #92: URL: https://github.com/apache/maven-build-cache-extension/pull/92#issuecomment-1735759678 Hello there, A little up on this old-timer PR. If I'm correct I fixed every mandatory request. Any other thought? -- This is an automated message from

[jira] [Commented] (MBUILDCACHE-67) Any error in restoring from the cache should resume the non cache build

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769253#comment-17769253 ] ASF GitHub Bot commented on MBUILDCACHE-67: --- kbuntrock commented on PR #92:

[jira] [Commented] (MCOMPILER-546) Maven compiling fails when using JEP 443

2023-09-26 Thread Vlad Galuska (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769277#comment-17769277 ] Vlad Galuska commented on MCOMPILER-546: My bad, assumed for some reason you w

[GitHub] [maven-integration-testing] slawekjaranowski merged pull request #299: [MNG-7895] Support ${project.basedir} in file profile activation - fix ITs

2023-09-26 Thread via GitHub
slawekjaranowski merged PR #299: URL: https://github.com/apache/maven-integration-testing/pull/299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

[GitHub] [maven] slawekjaranowski merged pull request #1262: [MNG-7895] Support ${project.basedir} in file profile activation

2023-09-26 Thread via GitHub
slawekjaranowski merged PR #1262: URL: https://github.com/apache/maven/pull/1262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mave

[jira] [Commented] (MNG-7895) Support ${project.basedir} in file profile activation

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769300#comment-17769300 ] ASF GitHub Bot commented on MNG-7895: - slawekjaranowski merged PR #1262: URL: https://g

[jira] [Commented] (MCOMPILER-546) Maven compiling fails when using JEP 443

2023-09-26 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769303#comment-17769303 ] Tamas Cservenak commented on MCOMPILER-546: --- Vlad, this seems JDK bug. Try

[jira] [Comment Edited] (MCOMPILER-546) Maven compiling fails when using JEP 443

2023-09-26 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769303#comment-17769303 ] Tamas Cservenak edited comment on MCOMPILER-546 at 9/26/23 6:15 PM:

[jira] [Commented] (MCOMPILER-546) Maven compiling fails when using JEP 443

2023-09-26 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769304#comment-17769304 ] Tamas Cservenak commented on MCOMPILER-546: --- Funny, here it is reported, and

[jira] [Comment Edited] (MCOMPILER-546) Maven compiling fails when using JEP 443

2023-09-26 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769304#comment-17769304 ] Tamas Cservenak edited comment on MCOMPILER-546 at 9/26/23 6:28 PM:

[jira] [Comment Edited] (MCOMPILER-546) Maven compiling fails when using JEP 443

2023-09-26 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769304#comment-17769304 ] Tamas Cservenak edited comment on MCOMPILER-546 at 9/26/23 6:29 PM:

[jira] [Commented] (MCOMPILER-546) Maven compiling fails when using JEP 443

2023-09-26 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769316#comment-17769316 ] Tamas Cservenak commented on MCOMPILER-546: --- Reproducer https://gist.github.

[GitHub] [maven-integration-testing] slawekjaranowski opened a new pull request, #301: [MNG-7895] Support ${project.basedir} in file profile activation - fix ITs 3.9.5

2023-09-26 Thread via GitHub
slawekjaranowski opened a new pull request, #301: URL: https://github.com/apache/maven-integration-testing/pull/301 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [maven] slawekjaranowski opened a new pull request, #1271: [MNG-7895] Support ${project.basedir} in file profile activation

2023-09-26 Thread via GitHub
slawekjaranowski opened a new pull request, #1271: URL: https://github.com/apache/maven/pull/1271 (cherry picked from commit 5c2e671a06721fe07cf414a9377a63652d512be0) --- Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make

[jira] [Commented] (MNG-7895) Support ${project.basedir} in file profile activation

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769320#comment-17769320 ] ASF GitHub Bot commented on MNG-7895: - slawekjaranowski opened a new pull request, #127

[jira] [Commented] (MNG-7416) Simplify conditional expression.

2023-09-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769323#comment-17769323 ] ASF GitHub Bot commented on MNG-7416: - timtebeek commented on code in PR #227: URL: ht

[GitHub] [maven-integration-testing] dependabot[bot] opened a new pull request, #302: Bump org.codehaus.plexus:plexus-utils from 0.1-mng2892 to 3.0.24 in /core-it-suite/src/test/resources/mng-2892

2023-09-26 Thread via GitHub
dependabot[bot] opened a new pull request, #302: URL: https://github.com/apache/maven-integration-testing/pull/302 Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 0.1-mng2892 to 3.0.24. Commits See full diff in https://github.com/

[GitHub] [maven-invoker-plugin] dependabot[bot] opened a new pull request, #197: Bump org.codehaus.plexus:plexus-utils from 1.1 to 3.0.24 in /src/it/script-class-loading

2023-09-26 Thread via GitHub
dependabot[bot] opened a new pull request, #197: URL: https://github.com/apache/maven-invoker-plugin/pull/197 Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 1.1 to 3.0.24. Commits See full diff in https://github.com/codehaus-plex

[GitHub] [maven-integration-testing] dependabot[bot] opened a new pull request, #303: Bump org.codehaus.plexus:plexus-utils from 0.1-mng3012 to 3.0.24 in /core-it-suite/src/test/resources/mng-3012

2023-09-26 Thread via GitHub
dependabot[bot] opened a new pull request, #303: URL: https://github.com/apache/maven-integration-testing/pull/303 Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 0.1-mng3012 to 3.0.24. Commits See full diff in https://github.com/

[GitHub] [maven-integration-testing] dependabot[bot] opened a new pull request, #304: Bump org.codehaus.plexus:plexus-utils from 0.1-stub to 3.0.24 in /core-it-suite/src/test/resources/mng-4666

2023-09-26 Thread via GitHub
dependabot[bot] opened a new pull request, #304: URL: https://github.com/apache/maven-integration-testing/pull/304 Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 0.1-stub to 3.0.24. Commits See full diff in https://github.com/cod

[GitHub] [maven-integration-testing] dependabot[bot] opened a new pull request, #305: Bump org.codehaus.plexus:plexus-utils from 1.1 to 3.0.24 in /core-it-support/core-it-plugins/maven-it-plugin-plexu

2023-09-26 Thread via GitHub
dependabot[bot] opened a new pull request, #305: URL: https://github.com/apache/maven-integration-testing/pull/305 Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 1.1 to 3.0.24. Commits See full diff in https://github.com/codehaus

[GitHub] [maven-archetype] dependabot[bot] opened a new pull request, #154: Bump org.codehaus.plexus:plexus-utils from 1.4.2 to 3.0.24 in /maven-archetype-plugin/src/test/projects/simple-inheritence/e

2023-09-26 Thread via GitHub
dependabot[bot] opened a new pull request, #154: URL: https://github.com/apache/maven-archetype/pull/154 Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 1.4.2 to 3.0.24. Commits https://github.com/codehaus-plexus/plexus-utils/comm

[GitHub] [maven-archetype] dependabot[bot] commented on pull request #115: Bump plexus-utils from 1.4.2 to 3.0.16 in /maven-archetype-plugin/src/test/projects/simple-inheritence/enforcer-rules

2023-09-26 Thread via GitHub
dependabot[bot] commented on PR #115: URL: https://github.com/apache/maven-archetype/pull/115#issuecomment-1736178492 Superseded by #154. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [maven-archetype] dependabot[bot] closed pull request #115: Bump plexus-utils from 1.4.2 to 3.0.16 in /maven-archetype-plugin/src/test/projects/simple-inheritence/enforcer-rules

2023-09-26 Thread via GitHub
dependabot[bot] closed pull request #115: Bump plexus-utils from 1.4.2 to 3.0.16 in /maven-archetype-plugin/src/test/projects/simple-inheritence/enforcer-rules URL: https://github.com/apache/maven-archetype/pull/115 -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [maven-toolchains-plugin] dependabot[bot] opened a new pull request, #16: Bump org.codehaus.plexus:plexus-utils from 3.0.16 to 3.0.24 in /src/it/setup-custom-toolchain

2023-09-26 Thread via GitHub
dependabot[bot] opened a new pull request, #16: URL: https://github.com/apache/maven-toolchains-plugin/pull/16 Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.0.16 to 3.0.24. Commits https://github.com/codehaus-plexus/plexus-uti

[GitHub] [maven-filtering] dependabot[bot] opened a new pull request, #80: Bump org.codehaus.plexus:plexus-utils from 3.0.16 to 3.0.24 in /src/test/resources

2023-09-26 Thread via GitHub
dependabot[bot] opened a new pull request, #80: URL: https://github.com/apache/maven-filtering/pull/80 Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.0.16 to 3.0.24. Commits https://github.com/codehaus-plexus/plexus-utils/commi

[GitHub] [maven-integration-testing] dependabot[bot] opened a new pull request, #306: Bump org.codehaus.plexus:plexus-utils from 3.0.9 to 3.0.24 in /core-it-suite/src/test/resources/mng-7160-extension

2023-09-26 Thread via GitHub
dependabot[bot] opened a new pull request, #306: URL: https://github.com/apache/maven-integration-testing/pull/306 Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.0.9 to 3.0.24. Commits https://github.com/codehaus-plexus/plexus-

[jira] [Commented] (MCOMPILER-546) Maven compiling fails when using JEP 443

2023-09-26 Thread Vlad Galuska (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769346#comment-17769346 ] Vlad Galuska commented on MCOMPILER-546: Debug false works for the project I e

[GitHub] [maven-integration-testing] slawekjaranowski opened a new pull request, #307: Try to fix MavenITmng7836AlternativePomSyntaxTest

2023-09-26 Thread via GitHub
slawekjaranowski opened a new pull request, #307: URL: https://github.com/apache/maven-integration-testing/pull/307 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #307: Try to fix MavenITmng7836AlternativePomSyntaxTest

2023-09-26 Thread via GitHub
slawekjaranowski commented on code in PR #307: URL: https://github.com/apache/maven-integration-testing/pull/307#discussion_r1337825137 ## core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7836AlternativePomSyntaxTest.java: ## @@ -64,8 +66,11 @@ void testAlternativeSynt

[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #307: Try to fix MavenITmng7836AlternativePomSyntaxTest

2023-09-26 Thread via GitHub
slawekjaranowski commented on code in PR #307: URL: https://github.com/apache/maven-integration-testing/pull/307#discussion_r1337826109 ## core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7836AlternativePomSyntaxTest.java: ## @@ -64,8 +66,11 @@ void testAlternativeSynt

[GitHub] [maven-integration-testing] slawekjaranowski closed pull request #302: Bump org.codehaus.plexus:plexus-utils from 0.1-mng2892 to 3.0.24 in /core-it-suite/src/test/resources/mng-2892

2023-09-26 Thread via GitHub
slawekjaranowski closed pull request #302: Bump org.codehaus.plexus:plexus-utils from 0.1-mng2892 to 3.0.24 in /core-it-suite/src/test/resources/mng-2892 URL: https://github.com/apache/maven-integration-testing/pull/302 -- This is an automated message from the Apache Git Service. To respond

[GitHub] [maven-integration-testing] dependabot[bot] commented on pull request #302: Bump org.codehaus.plexus:plexus-utils from 0.1-mng2892 to 3.0.24 in /core-it-suite/src/test/resources/mng-2892

2023-09-26 Thread via GitHub
dependabot[bot] commented on PR #302: URL: https://github.com/apache/maven-integration-testing/pull/302#issuecomment-1736380354 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or m

[jira] [Closed] (MCOMPILER-546) Maven compiling fails when using JEP 443

2023-09-26 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MCOMPILER-546. Assignee: Tamas Cservenak Resolution: Information Provided > Maven compiling fails

[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #307: Try to fix MavenITmng7836AlternativePomSyntaxTest

2023-09-26 Thread via GitHub
slawekjaranowski commented on PR #307: URL: https://github.com/apache/maven-integration-testing/pull/307#issuecomment-1736735173 This patch make a build green https://github.com/apache/maven/actions/runs/6318762268 but not resolve a problem -- This is an automated message from the Apa

[GitHub] [maven-integration-testing] gnodet opened a new pull request, #308: Fix expectations on IT MNG-7836 following the modifications on the consumer pom

2023-09-26 Thread via GitHub
gnodet opened a new pull request, #308: URL: https://github.com/apache/maven-integration-testing/pull/308 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #308: Fix expectations on IT MNG-7836 following the modifications on the consumer pom

2023-09-26 Thread via GitHub
slawekjaranowski commented on PR #308: URL: https://github.com/apache/maven-integration-testing/pull/308#issuecomment-1736754890 Can we change in: https://github.com/apache/maven-integration-testing/pull/307 -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [maven-integration-testing] gnodet commented on pull request #307: Try to fix MavenITmng7836AlternativePomSyntaxTest

2023-09-26 Thread via GitHub
gnodet commented on PR #307: URL: https://github.com/apache/maven-integration-testing/pull/307#issuecomment-1736792190 The fix is #308. The problem occurred because I split some PRs. Each PR was individually passing the tests, but when both had been merged, the test from the first PR w

[GitHub] [maven-integration-testing] gnodet commented on a diff in pull request #307: Try to fix MavenITmng7836AlternativePomSyntaxTest

2023-09-26 Thread via GitHub
gnodet commented on code in PR #307: URL: https://github.com/apache/maven-integration-testing/pull/307#discussion_r1338119093 ## core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7836AlternativePomSyntaxTest.java: ## @@ -64,8 +66,11 @@ void testAlternativeSyntax() throw

[GitHub] [maven-integration-testing] gnodet commented on a diff in pull request #307: Try to fix MavenITmng7836AlternativePomSyntaxTest

2023-09-26 Thread via GitHub
gnodet commented on code in PR #307: URL: https://github.com/apache/maven-integration-testing/pull/307#discussion_r1338125407 ## core-it-suite/src/test/resources-filtered/settings-remote.xml: ## @@ -67,6 +67,35 @@ plugins/artifacts from test repos so use of these settings shou