[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769144#comment-17769144 ]
ASF GitHub Bot commented on MNG-6847: ------------------------------------- timtebeek commented on code in PR #10: URL: https://github.com/apache/maven-doxia-linkcheck/pull/10#discussion_r1337108391 ########## src/main/java/org/apache/maven/doxia/linkcheck/validation/LinkValidationItem.java: ########## @@ -91,12 +91,7 @@ public boolean equals( Object obj ) return false; } - if ( !lvi.source.equals( this.source ) ) - { - return false; - } - - return true; + return lvi.source.equals(this.source); Review Comment: ```suggestion return lvi.source.equals( this.source ); ``` > Explicit type can be replaced by the diamond operator > ----------------------------------------------------- > > Key: MNG-6847 > URL: https://issues.apache.org/jira/browse/MNG-6847 > Project: Maven > Issue Type: Improvement > Components: Core > Affects Versions: 3.6.3 > Reporter: Krosheninnikov Artem > Assignee: Michael Osipov > Priority: Trivial > Fix For: 4.0.0-alpha-2, 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As the title says. It's a small change to reduce unneeded verbosity in the > code. -- This message was sent by Atlassian Jira (v8.20.10#820010)