slawekjaranowski commented on code in PR #307:
URL:
https://github.com/apache/maven-integration-testing/pull/307#discussion_r1337825137
##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7836AlternativePomSyntaxTest.java:
##########
@@ -64,8 +66,11 @@ void testAlternativeSyntax() throws Exception {
assertTrue(Files.isRegularFile(consumerPom));
List<String> consumerPomLines = Files.readAllLines(consumerPom,
StandardCharsets.UTF_8);
- assertFalse(consumerPomLines.stream().anyMatch(l ->
l.contains("<name>Apache-2.0</name>")));
- assertTrue(consumerPomLines.stream().anyMatch(l ->
l.contains("<parent>")));
+
+ // looks like consumerPom is an effective pom
+ // both assertions will fail
+ // assertFalse(consumerPomLines.stream().anyMatch(l ->
l.contains("<name>Apache-2.0</name>")));
+ // assertTrue(consumerPomLines.stream().anyMatch(l ->
l.contains("<parent>")));
Review Comment:
When I made a test to build and execute - this assertions don't pass
It can be cause that the feature is not working as expected ... or we have
wrong assumptions here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
