[
https://issues.apache.org/jira/browse/MNG-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769139#comment-17769139
]
ASF GitHub Bot commented on MNG-7416:
-------------------------------------
elharo commented on code in PR #227:
URL:
https://github.com/apache/maven-plugin-tools/pull/227#discussion_r1337100795
##########
maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/javadoc/JavaJavadocMojoDescriptorExtractor.java:
##########
@@ -510,7 +510,7 @@ private Map<String, JavaField>
extractFieldParameterTags(JavaClass javaClass) {
if (superClass != null) {
rawParams = extractFieldParameterTags(superClass);
} else {
- rawParams = new TreeMap<String, JavaField>();
+ rawParams = new TreeMap<>();
Review Comment:
Looking at this one, I realize the diamond operator with no params is more
useful for the case where it's declared on the same line.
TreeMap<String, JavaField> rawParams = new TreeMap<String, JavaField>();
does seem redundant
rawParams = new TreeMap<String, JavaField>();
is not. Haven't noticed that before.
> Simplify conditional expression.
> --------------------------------
>
> Key: MNG-7416
> URL: https://issues.apache.org/jira/browse/MNG-7416
> Project: Maven
> Issue Type: Improvement
> Reporter: Arturo Bernal
> Priority: Minor
>
> Simplify conditional expression and avoid extra computations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
