elharo commented on code in PR #227:
URL:
https://github.com/apache/maven-plugin-tools/pull/227#discussion_r1337283480
##########
maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/javadoc/JavaJavadocMojoDescriptorExtractor.java:
##########
@@ -510,7 +510,7 @@ private Map<String, JavaField>
extractFieldParameterTags(JavaClass javaClass) {
if (superClass != null) {
rawParams = extractFieldParameterTags(superClass);
} else {
- rawParams = new TreeMap<String, JavaField>();
+ rawParams = new TreeMap<>();
Review Comment:
Doesn't matter that much. The variable declaration wasn't in view by default
in Github code review. I do think there's a real tendency for devs to argue
that, "In my tool it's obvious" when advocating for more compact, less
redundant syntax without really considering how it looks in other environments.
I often hear folks claim that IDEs make certain constructs unnecessary. We can
be really myopic about that, even to the point of saving a few milliseconds of
typing right now at the cost of hours of debugging to our future selves. The
real cost here is in lambdas and method chaining, which are extremely opaque
and hard to read, all to save the trivial effort of typing a few more local
variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
