[
https://issues.apache.org/jira/browse/MNG-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769192#comment-17769192
]
ASF GitHub Bot commented on MNG-7416:
-------------------------------------
timtebeek commented on code in PR #227:
URL:
https://github.com/apache/maven-plugin-tools/pull/227#discussion_r1337254040
##########
maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/javadoc/JavaJavadocMojoDescriptorExtractor.java:
##########
@@ -510,7 +510,7 @@ private Map<String, JavaField>
extractFieldParameterTags(JavaClass javaClass) {
if (superClass != null) {
rawParams = extractFieldParameterTags(superClass);
} else {
- rawParams = new TreeMap<String, JavaField>();
+ rawParams = new TreeMap<>();
Review Comment:
Hmm, yes I guess that's true; would you want me to revert it here? Or keep
it since the variable is still mostly in view?
Alternatively we can pull down the variable declaration to just above the if
statement, as that would also clear up any ambiguity.
> Simplify conditional expression.
> --------------------------------
>
> Key: MNG-7416
> URL: https://issues.apache.org/jira/browse/MNG-7416
> Project: Maven
> Issue Type: Improvement
> Reporter: Arturo Bernal
> Priority: Minor
>
> Simplify conditional expression and avoid extra computations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
