slawekjaranowski commented on issue #265:
URL:
https://github.com/apache/maven-archetype/issues/265#issuecomment-2865342828
> Do you have an ETA for the release for me? Thank you!
I hope in this weekend
--
This is an automated message from the Apache Git Service.
To respond to the
slawekjaranowski merged PR #267:
URL: https://github.com/apache/maven-archetype/pull/267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr
github-actions[bot] commented on PR #246:
URL: https://github.com/apache/maven-site/pull/246#issuecomment-2864981103
This pull request is stale because it has been waiting for feedback for 60
days. Remove the stale label or comment on this PR, or it will be automatically
closed in 30 days.
github-actions[bot] commented on issue #708:
URL: https://github.com/apache/maven-site/issues/708#issuecomment-2864981069
This issue is stale because it has been waiting for feedback for 60 days.
Remove the stale label or comment on this issue, or it will be automatically
closed in 30 days.
gnodet commented on code in PR #2292:
URL: https://github.com/apache/maven/pull/2292#discussion_r2080518601
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##
@@ -77,17 +79,19 @@ public DefaultModelProcessor(ModelXmlFactory
modelXmlFacto
dependabot[bot] opened a new pull request, #2305:
URL: https://github.com/apache/maven/pull/2305
Bumps org.eclipse.jetty:jetty-server from 9.4.55.v20240627 to
9.4.56.v20240826.
[ {
elharo commented on code in PR #2292:
URL: https://github.com/apache/maven/pull/2292#discussion_r2080293469
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##
@@ -69,75 +71,74 @@
public class DefaultModelProcessor implements ModelProcess
gnodet commented on code in PR #2292:
URL: https://github.com/apache/maven/pull/2292#discussion_r2080275677
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##
@@ -69,25 +72,31 @@
public class DefaultModelProcessor implements ModelProcess
gnodet commented on PR #2303:
URL: https://github.com/apache/maven/pull/2303#issuecomment-2863924821
> > Removed too much. Please don't refactor too much without care.
>
>
>
> yes
>
> - SOC to myself and
>
> - `need to go right, to go fast` by Uncle Bob.
>
gnodet commented on code in PR #2304:
URL: https://github.com/apache/maven/pull/2304#discussion_r2080223658
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##
@@ -126,18 +126,14 @@ public Model read(XmlReaderRequest request) throws
IOExc
lprimak commented on issue #265:
URL:
https://github.com/apache/maven-archetype/issues/265#issuecomment-2863863713
Do you have an ETA for the release for me? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Bukama commented on PR #40:
URL: https://github.com/apache/maven-archetypes/pull/40#issuecomment-2863778450
Oh and please update confluence list 👼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Pankraz76 commented on code in PR #2304:
URL: https://github.com/apache/maven/pull/2304#discussion_r2080073931
##
impl/maven-impl/src/test/java/org/apache/maven/impl/model/DefaultModelProcessorTest.java:
##
@@ -0,0 +1,343 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Pankraz76 commented on code in PR #2304:
URL: https://github.com/apache/maven/pull/2304#discussion_r2080063940
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##
@@ -94,50 +97,45 @@ public Path locateExistingPom(Path projectDirectory) {
Pankraz76 commented on code in PR #2304:
URL: https://github.com/apache/maven/pull/2304#discussion_r2080063940
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##
@@ -94,50 +97,45 @@ public Path locateExistingPom(Path projectDirectory) {
Pankraz76 commented on code in PR #2303:
URL: https://github.com/apache/maven/pull/2303#discussion_r2080056801
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -93,7 +93,7 @@ public void write(XmlWriterRequest request)
throws XmlWriterE
Pankraz76 commented on PR #2303:
URL: https://github.com/apache/maven/pull/2303#issuecomment-2863615488
> Removed too much. Please don't refactor too much without care.
yes
- SOC to myself and
- `need to go right, to go fast` by Uncle Bob.
test first this changes already a
romani commented on code in PR #2303:
URL: https://github.com/apache/maven/pull/2303#discussion_r2079938779
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -93,7 +93,7 @@ public void write(XmlWriterRequest request)
throws XmlWriterEx
elharo commented on code in PR #2304:
URL: https://github.com/apache/maven/pull/2304#discussion_r2079922952
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##
@@ -94,50 +97,45 @@ public Path locateExistingPom(Path projectDirectory) {
Bukama opened a new pull request, #368:
URL: https://github.com/apache/maven-javadoc-plugin/pull/368
closes #367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
Pankraz76 commented on code in PR #2303:
URL: https://github.com/apache/maven/pull/2303#discussion_r2079687120
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -93,7 +93,7 @@ public void write(XmlWriterRequest request)
throws XmlWriterE
Pankraz76 commented on code in PR #2304:
URL: https://github.com/apache/maven/pull/2304#discussion_r2079670718
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##
@@ -114,9 +114,9 @@ public Model read(XmlReaderRequest request) throws
IOEx
Pankraz76 commented on code in PR #2304:
URL: https://github.com/apache/maven/pull/2304#discussion_r2079665241
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##
@@ -94,50 +97,45 @@ public Path locateExistingPom(Path projectDirectory) {
gnodet commented on PR #2292:
URL: https://github.com/apache/maven/pull/2292#issuecomment-286295
It's not thrown, that's right. So do not add a throw clause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gnodet commented on code in PR #2303:
URL: https://github.com/apache/maven/pull/2303#discussion_r2079619439
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -62,14 +63,9 @@ public PluginDescriptor read(@Nonnull XmlReaderRequest
request)
Pankraz76 commented on code in PR #2304:
URL: https://github.com/apache/maven/pull/2304#discussion_r2079569695
##
impl/maven-impl/src/test/java/org/apache/maven/impl/model/DefaultModelProcessorTest.java:
##
@@ -0,0 +1,349 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
jtnord opened a new issue, #841:
URL: https://github.com/apache/maven-surefire/issues/841
### New feature, improvement proposal
Currently you have the option of using regular arguments or using a manifest
only JAR to control the classpath for surefire.
The Manifest JAR is a wor
Pankraz76 commented on code in PR #2303:
URL: https://github.com/apache/maven/pull/2303#discussion_r2079489202
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -38,20 +38,20 @@
import org.apache.maven.plugin.descriptor.io.PluginDescript
elharo commented on code in PR #2304:
URL: https://github.com/apache/maven/pull/2304#discussion_r2079482137
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##
@@ -114,9 +114,9 @@ public Model read(XmlReaderRequest request) throws
IOExcep
[
https://issues.apache.org/jira/browse/MDEP-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950238#comment-17950238
]
ASF GitHub Bot commented on MDEP-976:
-
elharo commented on code in PR #523:
URL:
https
elharo commented on code in PR #523:
URL:
https://github.com/apache/maven-dependency-plugin/pull/523#discussion_r2079473159
##
src/main/java/org/apache/maven/plugins/dependency/fromDependencies/CopyDependenciesMojo.java:
##
@@ -105,6 +105,15 @@ public class CopyDependenciesMojo
Pankraz76 commented on code in PR #2303:
URL: https://github.com/apache/maven/pull/2303#discussion_r2079464474
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -62,14 +63,9 @@ public PluginDescriptor read(@Nonnull XmlReaderRequest
reque
Pankraz76 commented on code in PR #2303:
URL: https://github.com/apache/maven/pull/2303#discussion_r2079464474
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -62,14 +63,9 @@ public PluginDescriptor read(@Nonnull XmlReaderRequest
reque
Pankraz76 commented on code in PR #2303:
URL: https://github.com/apache/maven/pull/2303#discussion_r2079446642
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -102,7 +102,7 @@ public void write(XmlWriterRequest
request) throws XmlWrite
Pankraz76 commented on code in PR #2303:
URL: https://github.com/apache/maven/pull/2303#discussion_r2079445550
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -114,7 +114,7 @@ public static PluginDescriptor fromXml(@Nonnull String xml)
Bukama commented on PR #357:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/357#issuecomment-2862537722
> Caused by: org.apache.maven.surefire.booter.SurefireBooterForkException:
The forked VM terminated without properly saying goodbye. VM crash or
System.exit called?
Command
Pankraz76 commented on code in PR #2303:
URL: https://github.com/apache/maven/pull/2303#discussion_r2079331098
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -93,7 +93,7 @@ public void write(XmlWriterRequest request)
throws XmlWriterE
Pankraz76 commented on code in PR #2303:
URL: https://github.com/apache/maven/pull/2303#discussion_r2079331098
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -93,7 +93,7 @@ public void write(XmlWriterRequest request)
throws XmlWriterE
felix-office opened a new issue, #527:
URL: https://github.com/apache/maven-dependency-plugin/issues/527
### Affected version
Everything after Maven 3.9.2
### Bug description
First of all, I'm very happy that Github Issues is enabled now as I was
trying to get a Jira acc
Bukama commented on PR #357:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/357#issuecomment-2862295497
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Bukama opened a new issue, #367:
URL: https://github.com/apache/maven-javadoc-plugin/issues/367
### Affected version
3.11.2
### Bug description
On the index page
(https://maven.apache.org/plugins/maven-javadoc-plugin/index.html) the plugin
goals are described. For goal
Pankraz76 commented on PR #2292:
URL: https://github.com/apache/maven/pull/2292#issuecomment-2862135103
> Currently, the API is designed to throw XmlReaderException. Check the
implemented interface, there's no IOException thrown here.
>
> >
please notice dedicated thread:
http
Pankraz76 commented on code in PR #2304:
URL: https://github.com/apache/maven/pull/2304#discussion_r2079127763
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##
@@ -126,18 +126,14 @@ public Model read(XmlReaderRequest request) throws
IO
Pankraz76 commented on code in PR #2304:
URL: https://github.com/apache/maven/pull/2304#discussion_r2079124687
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##
@@ -126,18 +126,14 @@ public Model read(XmlReaderRequest request) throws
IO
Pankraz76 commented on code in PR #2304:
URL: https://github.com/apache/maven/pull/2304#discussion_r2079123415
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##
@@ -114,9 +114,9 @@ public Model read(XmlReaderRequest request) throws
IOEx
Pankraz76 commented on PR #2304:
URL: https://github.com/apache/maven/pull/2304#issuecomment-2862122305
ideally when merging this, the test will be obsolet in in follow up:
- https://github.com/apache/maven/pull/2292
then we have awareness that coverage is a real deal and not a nice
Pankraz76 commented on PR #2304:
URL: https://github.com/apache/maven/pull/2304#issuecomment-2862115843
this one important to give liberty on code back to us; making code liquide
while logic remains tight and dusty.
--
This is an automated message from the Apache Git Service.
To respond
48 matches
Mail list logo
