elharo commented on code in PR #523:
URL:
https://github.com/apache/maven-dependency-plugin/pull/523#discussion_r2079473159
##########
src/main/java/org/apache/maven/plugins/dependency/fromDependencies/CopyDependenciesMojo.java:
##########
@@ -105,6 +105,15 @@ public class CopyDependenciesMojo extends
AbstractFromDependenciesMojo {
@Parameter(property = "mdep.copySignatures", defaultValue = "false")
protected boolean copySignatures;
+ /**
+ * Prepend the groupId to the output filename by default to avoid
conflicts when artifactIds are not globally unique.
+ * Set to false to retain the original behavior.
Review Comment:
It might be unclear to readers what the original behavior was.
##########
src/main/java/org/apache/maven/plugins/dependency/fromDependencies/CopyDependenciesMojo.java:
##########
@@ -144,25 +153,27 @@ protected void doExecute() throws MojoExecutionException {
DependencyStatusSets dss =
getDependencySets(this.failOnMissingClassifierArtifact, addParentPoms);
Set<Artifact> artifacts = dss.getResolvedDependencies();
+ boolean effectivePrependGroupId = prependGroupId ||
prependGroupIdByDefault;
Review Comment:
why do we need both? One feels like it should be enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
