gnodet commented on code in PR #2292:
URL: https://github.com/apache/maven/pull/2292#discussion_r2080275677
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##########
@@ -69,25 +72,31 @@
public class DefaultModelProcessor implements ModelProcessor {
private final ModelXmlFactory modelXmlFactory;
- private final List<ModelParser> modelParsers;
+ private final @Nullable List<ModelParser> modelParsers;
- @Inject
Review Comment:
Are you aware that Maven has its own DI framework ? If you remove the
required annotations, it will probably break ?
@Nullable can be used to inform the DI that the requirement is optional.
Did you run UTs and ITs ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
