Pankraz76 commented on code in PR #2303:
URL: https://github.com/apache/maven/pull/2303#discussion_r2079464474
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##########
@@ -62,14 +63,9 @@ public PluginDescriptor read(@Nonnull XmlReaderRequest
request) throws XmlReader
return xml.read(inputStream, request.isStrict());
} else if (reader != null) {
return xml.read(reader, request.isStrict());
- } else if (path != null) {
- try (InputStream is = Files.newInputStream(path)) {
- return xml.read(is, request.isStrict());
- }
- } else {
- try (InputStream is = url.openStream()) {
Review Comment:
else is default because of early exit in L:56
`throw new IllegalArgumentException("path, url, reader or inputStream must
be non null");`
This branch is `not testable as its not possible`.
<img width="869" alt="image"
src="https://github.com/user-attachments/assets/197dbbfd-74ee-4fdd-86d9-bf091385939f";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
