Pankraz76 commented on code in PR #2304:
URL: https://github.com/apache/maven/pull/2304#discussion_r2079670718
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##########
@@ -114,9 +114,9 @@ public Model read(XmlReaderRequest request) throws
IOException {
}
try {
return doRead(request);
- } catch (IOException e) {
- exceptions.forEach(e::addSuppressed);
- throw e;
+ } catch (RuntimeException ex) {
Review Comment:
manage to change to `} catch (ModelParserException e) {`
as `IOError` is a `sitting duck` ready, for refactoring into `void`:
https://github.com/apache/maven/pull/2292#issuecomment-2862888895
> It's not thrown, that's right. So do not add a throw clause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
