Re: [PR] Logic for collecting Histogram efficiently using Point Trees [lucene]

jainankitk commented on code in PR #14439: URL: https://github.com/apache/lucene/pull/14439#discussion_r2049741831 ## lucene/sandbox/src/test/org/apache/lucene/sandbox/facet/plain/histograms/TestHistogramCollectorManager.java: ## @@ -115,6 +117,38 @@ public void testSkipIndexWit

Re: [PR] Logic for collecting Histogram efficiently using Point Trees [lucene]

jainankitk commented on code in PR #14439: URL: https://github.com/apache/lucene/pull/14439#discussion_r2049534867 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/PointTreeBulkCollector.java: ## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Logic for collecting Histogram efficiently using Point Trees [lucene]

jainankitk commented on code in PR #14439: URL: https://github.com/apache/lucene/pull/14439#discussion_r2049535183 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/PointTreeBulkCollector.java: ## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Upgrade to gradle 8.14-rc-2 [lucene]

dweiss commented on PR #14519: URL: https://github.com/apache/lucene/pull/14519#issuecomment-2814109034 I would like to wait until the official release is made (not rc). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Speed up advancing within a sparse block in IndexedDISI. [lucene]

github-actions[bot] commented on PR #14371: URL: https://github.com/apache/lucene/pull/14371#issuecomment-2814249617 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Upgrade to gradle 8.14-rc-2 [lucene]

harshavamsi commented on PR #14519: URL: https://github.com/apache/lucene/pull/14519#issuecomment-2814127985 > I would like to wait until the official release is made (not rc). I'll mark this for draft and will pick up once 8.14 is fully released. -- This is an automated message fro

Re: [PR] Remove sloppySin calculations [lucene]

rmuir commented on PR #14516: URL: https://github.com/apache/lucene/pull/14516#issuecomment-2814266775 It will mostly impact geo sorting. But replacing the fast SloppyMath calculation here with slower equivalents from OpenJDK won't buy you any improved error rate: precision is purpose

Re: [I] Tone down TestIndexWriterDelete.testDeleteAllRepeated (OOMs sometimes) [lucene]

dweiss commented on issue #14508: URL: https://github.com/apache/lucene/issues/14508#issuecomment-2812002598 I think it'd be good to set up jenkins the way Robert does - point gradle's temp folders at some tmpfs mount, at least from linux. This would save your disks from wearing out signifi

Re: [PR] Logic for collecting Histogram efficiently using Point Trees [lucene]

jainankitk commented on code in PR #14439: URL: https://github.com/apache/lucene/pull/14439#discussion_r2050147491 ## lucene/sandbox/src/test/org/apache/lucene/sandbox/facet/plain/histograms/TestHistogramCollectorManager.java: ## @@ -115,6 +117,38 @@ public void testSkipIndexWit

Re: [PR] Logic for collecting Histogram efficiently using Point Trees [lucene]

jainankitk commented on code in PR #14439: URL: https://github.com/apache/lucene/pull/14439#discussion_r2050117622 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/HistogramCollector.java: ## @@ -53,11 +59,22 @@ public LeafCollector getLeafCollector(Le

Re: [PR] Logic for collecting Histogram efficiently using Point Trees [lucene]

jainankitk commented on code in PR #14439: URL: https://github.com/apache/lucene/pull/14439#discussion_r2050115412 ## lucene/core/src/java/org/apache/lucene/util/ArrayUtil.java: ## @@ -801,4 +802,16 @@ public static int compareUnsigned4(byte[] a, int aOffset, byte[] b, int bOff

Re: [I] Add a timeout for forceMergeDeletes in IndexWriter [lucene]

vigyasharma commented on issue #14431: URL: https://github.com/apache/lucene/issues/14431#issuecomment-2811827103 > Suppose forceMergeDeletes() returned the MergeSpec This could be a _"good first issue"_, I'll create a spin-off issue for the same. We can close it if others disagree wi

Re: [PR] Ensuring skip list is read for fields indexed with only DOCS [lucene]

expani commented on code in PR #14511: URL: https://github.com/apache/lucene/pull/14511#discussion_r2047828296 ## lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java: ## @@ -282,6 +288,10 @@ public PostingsEnum postings( @Override public Im

Re: [PR] Ensuring skip list is read for fields indexed with only DOCS [lucene]

expani commented on code in PR #14511: URL: https://github.com/apache/lucene/pull/14511#discussion_r2047828296 ## lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java: ## @@ -282,6 +288,10 @@ public PostingsEnum postings( @Override public Im

[PR] Use a non-deprecated assertThat, and change several test assertions to use assertThat [lucene]

thecoop opened a new pull request, #14518: URL: https://github.com/apache/lucene/pull/14518 The main reason for this PR is using an un-deprecated `assertThat` by default. I've also updated a few uses of old-style assertions to use `assertThat` and `Matchers` that give a more descriptive err

[PR] Upgrade to gradle 8.14-rc-2 [lucene]

harshavamsi opened a new pull request, #14519: URL: https://github.com/apache/lucene/pull/14519 ### Description I was trying to do a fresh import of Lucene into Intellij 2025.1 when it threw ``` java.lang.ClassCastException: class org.codehaus.groovy.runtime.GString

Re: [PR] Use a non-deprecated assertThat, and change several test assertions to use assertThat [lucene]

thecoop commented on code in PR #14518: URL: https://github.com/apache/lucene/pull/14518#discussion_r2048959333 ## lucene/core/src/test/org/apache/lucene/index/TestAddIndexes.java: ## @@ -810,10 +810,7 @@ public MergeSpecification findMerges(CodecReader... readers) throws IOExc

Re: [PR] Remove sloppySin calculations [lucene]

jainankitk commented on PR #14516: URL: https://github.com/apache/lucene/pull/14516#issuecomment-2813787215 > I don't agree with the such changes without supporting benchmarks, sorry. Especially it is bad news to just replace 3 functions (sin,cos,asin) all at once in YOLO fashion. Th

Re: [PR] Logic for collecting Histogram efficiently using Point Trees [lucene]

jainankitk commented on code in PR #14439: URL: https://github.com/apache/lucene/pull/14439#discussion_r2049533078 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/PointTreeBulkCollector.java: ## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Logic for collecting Histogram efficiently using Point Trees [lucene]

stefanvodita commented on code in PR #14439: URL: https://github.com/apache/lucene/pull/14439#discussion_r2048509305 ## lucene/sandbox/src/test/org/apache/lucene/sandbox/facet/plain/histograms/TestHistogramCollectorManager.java: ## @@ -115,6 +117,38 @@ public void testSkipIndexW

Re: [PR] cache preset dict for LZ4WithPresetDictDecompressor [lucene]

kkewwei commented on code in PR #14397: URL: https://github.com/apache/lucene/pull/14397#discussion_r2048995276 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java: ## @@ -512,6 +512,7 @@ private void doReset(int docID

Re: [PR] cache preset dict for LZ4WithPresetDictDecompressor [lucene]

kkewwei commented on code in PR #14397: URL: https://github.com/apache/lucene/pull/14397#discussion_r2048995276 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java: ## @@ -512,6 +512,7 @@ private void doReset(int docID

Re: [PR] cache preset dict for LZ4WithPresetDictDecompressor [lucene]

kkewwei commented on code in PR #14397: URL: https://github.com/apache/lucene/pull/14397#discussion_r2048995276 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java: ## @@ -512,6 +512,7 @@ private void doReset(int docID

Re: [PR] cache preset dict for LZ4WithPresetDictDecompressor [lucene]

kkewwei commented on code in PR #14397: URL: https://github.com/apache/lucene/pull/14397#discussion_r2048995276 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java: ## @@ -512,6 +512,7 @@ private void doReset(int docID

Re: [PR] cache preset dict for LZ4WithPresetDictDecompressor [lucene]

kkewwei commented on code in PR #14397: URL: https://github.com/apache/lucene/pull/14397#discussion_r2048995276 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java: ## @@ -512,6 +512,7 @@ private void doReset(int docID

Re: [PR] cache preset dict for LZ4WithPresetDictDecompressor [lucene]

kkewwei commented on code in PR #14397: URL: https://github.com/apache/lucene/pull/14397#discussion_r2048995276 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java: ## @@ -512,6 +512,7 @@ private void doReset(int docID

Re: [PR] Logic for collecting Histogram efficiently using Point Trees [lucene]

jainankitk commented on PR #14439: URL: https://github.com/apache/lucene/pull/14439#issuecomment-2810960212 I have updated the PR, and the code flow is like below now: * `HistogramCollector` overrides the `setWeight` for accessing the underlying `Query` * To keep things simple, jus

Re: [PR] Remove sloppySin calculations [lucene]

rmuir commented on code in PR #14516: URL: https://github.com/apache/lucene/pull/14516#discussion_r2048713697 ## lucene/core/src/java/org/apache/lucene/geo/Rectangle.java: ## @@ -28,9 +25,6 @@ import static org.apache.lucene.geo.GeoUtils.MIN_LON_RADIANS; import static org.apac

[PR] Remove sloppySin calculations [lucene]

jainankitk opened a new pull request, #14516: URL: https://github.com/apache/lucene/pull/14516 ### Description Wondering if we really need sloppySin anymore. For modern hardware with JDK 17 on recent processors: * The performance difference should be negligible * Modern JVMs hea

Re: [PR] Ensuring skip list is read for fields indexed with only DOCS [lucene]

expani commented on code in PR #14511: URL: https://github.com/apache/lucene/pull/14511#discussion_r2047828296 ## lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java: ## @@ -282,6 +288,10 @@ public PostingsEnum postings( @Override public Im

Re: [I] Strange stack traces for new bitset focused doc iterators [lucene]

benwtrent commented on issue #14517: URL: https://github.com/apache/lucene/issues/14517#issuecomment-2812913299 Thinking about the first stack trace more, it may actually be because `windowBase > windowMax`. Following the trace up, we reach `DenseConjunctionBulkScorer#scoreWindow`, where `i