jainankitk commented on PR #14516: URL: https://github.com/apache/lucene/pull/14516#issuecomment-2813787215
> I don't agree with the such changes without supporting benchmarks, sorry. Especially it is bad news to just replace 3 functions (sin,cos,asin) all at once in YOLO fashion. Thanks for raising these concerns. The intention was to just remove custom `sloppySin`. Removing `SloppyMath.cos`, `SloppyMath.asin` was by mistake. Let me work on providing supporting benchmark. I am wondering if there is something in `LuceneUtil` benchmark that can be used for this purpose? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
