expani commented on code in PR #14511:
URL: https://github.com/apache/lucene/pull/14511#discussion_r2047828296
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java:
##########
@@ -282,6 +288,10 @@ public PostingsEnum postings(
@Override
public ImpactsEnum impacts(FieldInfo fieldInfo, BlockTermState state, int
flags)
throws IOException {
+ if (state.docFreq <= BLOCK_SIZE) {
+ // no skip data
+ return new SlowImpactsEnum(postings(fieldInfo, state, null, flags));
+ }
Review Comment:
DUMMY_IMPACTS in PostingsReader is a `List<Impact>` ( 10.1.0 )
whereas
the DUMMY_IMPACTS returned by SlowImpactsEnum ( 9.11.1 ) was a `Impacts`
which would still apply for cases where using the skip list doesn't make sense
`state.docFreq <= BLOCK_SIZE`
I picked this check from `Lucene99PostingsReader` where we stored a default
impact of freq=1 even if the field was indexed with `IndexOptions.DOCS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
