uschindler commented on code in PR #13570:
URL: https://github.com/apache/lucene/pull/13570#discussion_r1677539871
##
lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java:
##
@@ -256,15 +267,15 @@ default IOException convertMapFailedIOException(
}
}
- priva
uschindler commented on code in PR #13570:
URL: https://github.com/apache/lucene/pull/13570#discussion_r1677544947
##
lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java:
##
@@ -199,20 +203,27 @@ public IndexInput openInput(String name, IOContext
context) throws IOE
ChrisHegarty commented on code in PR #13570:
URL: https://github.com/apache/lucene/pull/13570#discussion_r1677621308
##
lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java:
##
@@ -199,20 +203,27 @@ public IndexInput openInput(String name, IOContext
context) throws I
ChrisHegarty commented on code in PR #13570:
URL: https://github.com/apache/lucene/pull/13570#discussion_r1677620883
##
lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java:
##
@@ -199,20 +203,27 @@ public IndexInput openInput(String name, IOContext
context) throws I
iverase commented on code in PR #13563:
URL: https://github.com/apache/lucene/pull/13563#discussion_r1677624311
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java:
##
@@ -1792,61 +1794,88 @@ public DocValuesSkipper getSkipper(FieldInfo field
stefanvodita commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1677574763
##
lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java:
##
@@ -300,35 +302,28 @@ public DrillSidewaysResult(
}
}
- private static class Ca
jpountz commented on code in PR #13563:
URL: https://github.com/apache/lucene/pull/13563#discussion_r1677636214
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java:
##
@@ -1792,61 +1794,88 @@ public DocValuesSkipper getSkipper(FieldInfo field
iverase commented on code in PR #13563:
URL: https://github.com/apache/lucene/pull/13563#discussion_r1677637583
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesConsumer.java:
##
@@ -207,65 +210,120 @@ void accumulate(long value) {
maxValue = Mat
ChrisHegarty commented on code in PR #13570:
URL: https://github.com/apache/lucene/pull/13570#discussion_r1677637602
##
lucene/core/src/java21/org/apache/lucene/store/RefCountedSharedArena.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
iverase commented on code in PR #13563:
URL: https://github.com/apache/lucene/pull/13563#discussion_r1677661302
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java:
##
@@ -1792,61 +1794,88 @@ public DocValuesSkipper getSkipper(FieldInfo field
epotyom commented on PR #13568:
URL: https://github.com/apache/lucene/pull/13568#issuecomment-2228412566
@stefanvodita thank you for reviewing!
> Do you have any benchmark results to share? Hooking this into luceneutil
might be tricky. I think even a vague sense of where this is bett
epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r166951
##
lucene/core/src/java/org/apache/lucene/search/CollectorOwner.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1677782365
##
lucene/core/src/java/org/apache/lucene/search/CollectorOwner.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
msokolov commented on PR #13559:
URL: https://github.com/apache/lucene/pull/13559#issuecomment-2228466558
Another idea -- would it help your use case? -- would be to support
`nextSetBit(start, end)` . We could do this without adding any additional
tracking in existing SparseBitSet methods
msokolov commented on code in PR #13559:
URL: https://github.com/apache/lucene/pull/13559#discussion_r1677810270
##
lucene/core/src/java/org/apache/lucene/util/SparseFixedBitSet.java:
##
@@ -51,6 +51,7 @@ private static int blockCount(int length) {
}
final long[] indices
epotyom commented on PR #13559:
URL: https://github.com/apache/lucene/pull/13559#issuecomment-2228524276
@msokolov thanks for looking into it!
> I wonder if DocIdSetBuilder would help? I guess it doesn't support
accessing as a BitSet while under construction though.
Yes, I thin
epotyom commented on code in PR #13559:
URL: https://github.com/apache/lucene/pull/13559#discussion_r1677851990
##
lucene/core/src/java/org/apache/lucene/util/SparseFixedBitSet.java:
##
@@ -51,6 +51,7 @@ private static int blockCount(int length) {
}
final long[] indices;
epotyom commented on code in PR #13559:
URL: https://github.com/apache/lucene/pull/13559#discussion_r1677851990
##
lucene/core/src/java/org/apache/lucene/util/SparseFixedBitSet.java:
##
@@ -51,6 +51,7 @@ private static int blockCount(int length) {
}
final long[] indices;
epotyom commented on code in PR #13559:
URL: https://github.com/apache/lucene/pull/13559#discussion_r1677851990
##
lucene/core/src/java/org/apache/lucene/util/SparseFixedBitSet.java:
##
@@ -51,6 +51,7 @@ private static int blockCount(int length) {
}
final long[] indices;
epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1677862194
##
lucene/core/src/java/org/apache/lucene/search/CollectorOwner.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1677870287
##
lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.java:
##
@@ -115,6 +116,69 @@ public final LongValuesSource toLongValuesSource() {
return new
epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1677872262
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -630,27 +630,47 @@ private TopFieldDocs searchAfter(
*/
public T search(Query query,
msokolov commented on code in PR #13559:
URL: https://github.com/apache/lucene/pull/13559#discussion_r1677885744
##
lucene/core/src/java/org/apache/lucene/util/SparseFixedBitSet.java:
##
@@ -51,6 +51,7 @@ private static int blockCount(int length) {
}
final long[] indices
epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1677923025
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ordinal_iterators/SortOrdinalIterator.java:
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foun
epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1677925857
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ordinal_iterators/SortOrdinalIterator.java:
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foun
magibney commented on code in PR #13570:
URL: https://github.com/apache/lucene/pull/13570#discussion_r1677916943
##
lucene/core/src/java21/org/apache/lucene/store/RefCountedSharedArena.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
uschindler commented on code in PR #13570:
URL: https://github.com/apache/lucene/pull/13570#discussion_r1677946847
##
lucene/core/src/java21/org/apache/lucene/store/RefCountedSharedArena.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
uschindler commented on code in PR #13570:
URL: https://github.com/apache/lucene/pull/13570#discussion_r1677959677
##
lucene/core/src/java21/org/apache/lucene/store/RefCountedSharedArena.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
uschindler commented on code in PR #13570:
URL: https://github.com/apache/lucene/pull/13570#discussion_r1677959677
##
lucene/core/src/java21/org/apache/lucene/store/RefCountedSharedArena.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
mayya-sharipova merged PR #13569:
URL: https://github.com/apache/lucene/pull/13569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lu
uschindler commented on PR #13570:
URL: https://github.com/apache/lucene/pull/13570#issuecomment-2228727994
Hi,
we also get Updates on the JDK fixes:
https://github.com/openjdk/jdk/pull/20158 (see issue about more details and
some improvements Solr and/or Elasticsearch/Opensearch should
ChrisHegarty commented on code in PR #13570:
URL: https://github.com/apache/lucene/pull/13570#discussion_r1677994244
##
lucene/core/src/java21/org/apache/lucene/store/RefCountedSharedArena.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
uschindler commented on issue #13325:
URL: https://github.com/apache/lucene/issues/13325#issuecomment-2228749316
We also have another PR doing the same than @magibney's:
https://github.com/apache/lucene/pull/13570
We also got some updates on the JDK front. Next to the fixes here (use
magibney commented on PR #13570:
URL: https://github.com/apache/lucene/pull/13570#issuecomment-2228755150
To expand a bit on the concern I raised above:
IIUC, in order for this to work properly (guaranteed to not potentially leak
virtual memory address space) it depends on segment fil
uschindler commented on PR #13570:
URL: https://github.com/apache/lucene/pull/13570#issuecomment-2228783249
> To expand a bit on the concern I raised above:
>
> IIUC, in order for this to work properly (guaranteed to not potentially
leak virtual memory address space) it depends on seg
ChrisHegarty commented on code in PR #13570:
URL: https://github.com/apache/lucene/pull/13570#discussion_r1678024394
##
lucene/core/src/java21/org/apache/lucene/store/RefCountedSharedArena.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
uschindler commented on PR #13570:
URL: https://github.com/apache/lucene/pull/13570#issuecomment-2228809498
We may need some other logic: We have some files that can change without the
segment name changing? How do we handle *.del od docValues update files? If
they correspond to the same se
magibney commented on PR #13570:
URL: https://github.com/apache/lucene/pull/13570#issuecomment-2228833300
heh, was just writing to suggest something similar
(`Function>`). SGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
magibney closed pull request #13555: Group memory arenas by segment to reduce
costly `Arena.close()`
URL: https://github.com/apache/lucene/pull/13555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
magibney commented on PR #13555:
URL: https://github.com/apache/lucene/pull/13555#issuecomment-2228844256
Closing in favor of #13570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
uschindler commented on issue #13325:
URL: https://github.com/apache/lucene/issues/13325#issuecomment-2228936957
Yeah: https://github.com/openjdk/jdk/pull/20158#issuecomment-2228916752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
benwtrent commented on issue #13519:
URL: https://github.com/apache/lucene/issues/13519#issuecomment-2228966111
@MilindShyani OK, I did some more benchmarking.
I tried switching to `+` & with your full correction term and recall
significantly dropped to `0.518`
I tried the fol
shatejas commented on PR #13407:
URL: https://github.com/apache/lucene/pull/13407#issuecomment-2228981677
@benwtrent
> Its not necessary and without it things are simpler (less code and less
API features is a good thing by itself)
This shouldn't come at the cost of not providi
shatejas closed pull request #13407: Introduces efSearch as a separate
parameter in KNN{Byte:Float}VectorQuery
URL: https://github.com/apache/lucene/pull/13407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1678175501
##
lucene/sandbox/src/test/org/apache/lucene/sandbox/facet/SandboxFacetTestCase.java:
##
@@ -0,0 +1,407 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1678177857
##
lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java:
##
@@ -300,35 +302,28 @@ public DrillSidewaysResult(
}
}
- private static class Callabl
epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1678181693
##
lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java:
##
@@ -349,45 +344,149 @@ private DrillDownQuery getDrillDownQuery(
public ConcurrentDrillSide
epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1678184630
##
lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java:
##
@@ -398,130 +497,56 @@ private ConcurrentDrillSidewaysResult
searchSequentially(
}
epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1678185585
##
lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java:
##
@@ -398,130 +497,56 @@ private ConcurrentDrillSidewaysResult
searchSequentially(
}
epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1678226435
##
lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysQuery.java:
##
@@ -195,11 +156,11 @@ public ScorerSupplier scorerSupplier(LeafReaderContext
context) thr
epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1678240834
##
lucene/sandbox/src/test/org/apache/lucene/sandbox/facet/TestRangeFacet.java:
##
@@ -0,0 +1,1654 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1678246773
##
lucene/sandbox/src/test/org/apache/lucene/sandbox/facet/TestRangeFacet.java:
##
@@ -0,0 +1,1654 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1678247836
##
lucene/sandbox/src/test/org/apache/lucene/sandbox/facet/TestRangeFacet.java:
##
@@ -0,0 +1,1654 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1678265251
##
lucene/sandbox/src/test/org/apache/lucene/sandbox/facet/TestTaxonomyFacet.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
dsmiley commented on code in PR #13570:
URL: https://github.com/apache/lucene/pull/13570#discussion_r1678448829
##
lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java:
##
@@ -199,20 +202,27 @@ public IndexInput openInput(String name, IOContext
context) throws IOExce
dsmiley commented on code in PR #13570:
URL: https://github.com/apache/lucene/pull/13570#discussion_r1678459190
##
lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInputProvider.java:
##
@@ -125,4 +134,31 @@ private final MemorySegment[] map(
}
return s
dsmiley commented on issue #13325:
URL: https://github.com/apache/lucene/issues/13325#issuecomment-2229550743
What does "refreshing indexes" mean exactly? Solr does not have special
threads for opening/closing indexes; they will typically happen on the common
Jetty request thread pool. If
github-actions[bot] commented on PR #13516:
URL: https://github.com/apache/lucene/pull/13516#issuecomment-2229712938
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
github-actions[bot] commented on PR #12869:
URL: https://github.com/apache/lucene/pull/12869#issuecomment-2229714723
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
goankur opened a new pull request, #13572:
URL: https://github.com/apache/lucene/pull/13572
Credit:
https://www.elastic.co/search-labs/blog/vector-similarity-computations-ludicrous-speed
Implement vectorized dot product in native C code using Neon intrinsics
### Descri
MilindShyani commented on issue #13519:
URL: https://github.com/apache/lucene/issues/13519#issuecomment-2229864587
Hi @benwtrent, I am trying to carefully check the math vs code. The first
thing I noticed is that my definitions of dxs and dxq don't necessarily match
with yours. That might b
rmuir commented on PR #13572:
URL: https://github.com/apache/lucene/pull/13572#issuecomment-2230045004
Do we even need to use intrinsics? function is so simple that the compiler
seems to do the right thing, e.g. use `SDOT` dot production instruction, given
the correct flags:
https://
rmuir commented on PR #13572:
URL: https://github.com/apache/lucene/pull/13572#issuecomment-2230061569
I haven't benchmarked, just seems `SDOT` is the one to optimize for, and GCC
can both recognize the code shape and autovectorize to it without hassle.
my cheap 2021 phone has `asimd
rmuir commented on code in PR #13572:
URL: https://github.com/apache/lucene/pull/13572#discussion_r1678790088
##
lucene/core/build.gradle:
##
@@ -14,10 +14,43 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+plug
rmuir commented on code in PR #13572:
URL: https://github.com/apache/lucene/pull/13572#discussion_r1678799350
##
lucene/core/build.gradle:
##
@@ -14,10 +14,43 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+plug
uschindler commented on code in PR #13570:
URL: https://github.com/apache/lucene/pull/13570#discussion_r1678835899
##
lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInputProvider.java:
##
@@ -125,4 +134,31 @@ private final MemorySegment[] map(
}
retur
uschindler commented on code in PR #13570:
URL: https://github.com/apache/lucene/pull/13570#discussion_r1678835899
##
lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInputProvider.java:
##
@@ -125,4 +134,31 @@ private final MemorySegment[] map(
}
retur
uschindler commented on issue #13325:
URL: https://github.com/apache/lucene/issues/13325#issuecomment-2230135534
It is not a JDK bug, it is expected behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
uschindler commented on issue #13325:
URL: https://github.com/apache/lucene/issues/13325#issuecomment-2230139147
Basically the idea is to close indexes asynchronous in a single thread doing
this to not block main threads.
--
This is an automated message from the Apache Git Service.
To res
69 matches
Mail list logo