epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1677923025
########## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ordinal_iterators/SortOrdinalIterator.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.sandbox.facet.ordinal_iterators; + +import java.io.IOException; +import org.apache.lucene.sandbox.facet.abstracts.GetOrd; +import org.apache.lucene.sandbox.facet.abstracts.OrdToComparable; +import org.apache.lucene.sandbox.facet.abstracts.OrdinalIterator; +import org.apache.lucene.util.InPlaceMergeSorter; + +/** + * {@link OrdinalIterator} that consumes incoming ordinals, sorts them by Comparable, and returns in + * sorted order. + */ +public class SortOrdinalIterator<T extends Comparable<T> & GetOrd> implements OrdinalIterator { Review Comment: Oh, I'll remove this class in the next iteration - I don't think we actually need it. The reason is that when we sort results instead of computing topN, we expect to keep all source ordinals, so it seems to be easier to just get an array of ordinals and sort the array. We can add a static util method to ComparableUtils for that I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
