dsmiley commented on code in PR #13570:
URL: https://github.com/apache/lucene/pull/13570#discussion_r1678448829
##########
lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java:
##########
@@ -199,20 +202,27 @@ public IndexInput openInput(String name, IOContext
context) throws IOException {
ensureOpen();
ensureCanRead(name);
Path path = directory.resolve(name);
- return PROVIDER.openInput(path, context, chunkSizePower,
preload.test(name, context));
+ return PROVIDER.openInput(
+ path, context, chunkSizePower, preload.test(name, context),
attachment);
}
// visible for tests:
- static final MMapIndexInputProvider PROVIDER;
+ static final MMapIndexInputProvider<Object> PROVIDER;
- interface MMapIndexInputProvider {
- IndexInput openInput(Path path, IOContext context, int chunkSizePower,
boolean preload)
+ interface MMapIndexInputProvider<A> {
+ IndexInput openInput(
+ Path path, IOContext context, int chunkSizePower, boolean preload, A
attachment)
throws IOException;
long getDefaultMaxChunkSize();
boolean supportsMadvise();
+ /** An optional attachment of the provider, that will be passed to
openInput. */
Review Comment:
Without looking at the actual implementation, it wasn't clear what
"attachment" is, or what's expected of this method. Apparently this should
return a *new* "attachment", and it's called on MMapDirectory's constructor
(thus once, not per openInput). Renaming "createXXXXX" would clarify.
Are we being overly generic? We can call it what it is -- arenaBySegment.
##########
lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInputProvider.java:
##########
@@ -125,4 +134,31 @@ private final MemorySegment[] map(
}
return segments;
}
+
+ public ConcurrentHashMap<String, RefCountedSharedArena> attachment() {
Review Comment:
hm; I'd expect an Override annotation
##########
lucene/core/src/java21/org/apache/lucene/store/RefCountedSharedArena.java:
##########
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.store;
+
+import java.lang.foreign.Arena;
+import java.lang.foreign.MemorySegment;
+import java.util.concurrent.atomic.AtomicInteger;
+
+@SuppressWarnings("preview")
+final class RefCountedSharedArena implements Arena {
+
+ static final int OPEN = 0;
+ static final int CLOSED = -1;
+
+ private final String segmentName;
+ private final Runnable removeFromMap;
Review Comment:
I would call this onClose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
