epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1678184630
##########
lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java:
##########
@@ -398,130 +497,56 @@ private <R> ConcurrentDrillSidewaysResult<R>
searchSequentially(
}
Query[] drillDownQueries = query.getDrillDownQueries();
- int numDims = drillDownDims.size();
-
- FacetsCollectorManager drillDownCollectorManager =
createDrillDownFacetsCollectorManager();
-
- FacetsCollectorManager[] drillSidewaysFacetsCollectorManagers =
- new FacetsCollectorManager[numDims];
- for (int i = 0; i < numDims; i++) {
- drillSidewaysFacetsCollectorManagers[i] =
createDrillSidewaysFacetsCollectorManager();
- }
-
DrillSidewaysQuery dsq =
new DrillSidewaysQuery(
baseQuery,
- drillDownCollectorManager,
- drillSidewaysFacetsCollectorManagers,
+ // drillDownCollectorOwner,
+ // Don't pass drill down collector because drill down is collected
by IndexSearcher
+ // itself.
+ // TODO: deprecate drillDown collection in DrillSidewaysQuery?
Review Comment:
I don't think we would write it completely differently - we could deprecate
some methods that use FacetCollectors in the future maybe? But there are some
followup items, like this TODO, which I think we can look into later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
