epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1677870287
##########
lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.java:
##########
@@ -115,6 +116,69 @@ public final LongValuesSource toLongValuesSource() {
return new LongDoubleValuesSource(this);
}
+ public final LongValuesSource toSortableLongDoubleValuesSource() {
+ return new SortableLongDoubleValuesSource(this);
+ }
+
+ private static class SortableLongDoubleValuesSource extends LongValuesSource
{
+
+ private final DoubleValuesSource inner;
+
+ private SortableLongDoubleValuesSource(DoubleValuesSource inner) {
+ this.inner = inner;
+ }
+
+ @Override
+ public LongValues getValues(LeafReaderContext ctx, DoubleValues scores)
throws IOException {
+ DoubleValues in = inner.getValues(ctx, scores);
+
+ return new LongValues() {
+ @Override
+ public long longValue() throws IOException {
+ return NumericUtils.doubleToSortableLong(in.doubleValue());
+ }
+
+ @Override
+ public boolean advanceExact(int doc) throws IOException {
+ return in.advanceExact(doc);
+ }
+ };
+ }
+
+ @Override
+ public boolean needsScores() {
+ return inner.needsScores();
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(inner);
Review Comment:
I think the only benefit is that `Objects.hash` handles null, but not sure
if we want to support nulls here? +cc @Shradha26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
