ChrisHegarty commented on code in PR #13570: URL: https://github.com/apache/lucene/pull/13570#discussion_r1677637602
########## lucene/core/src/java21/org/apache/lucene/store/RefCountedSharedArena.java: ########## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.store; + +import java.lang.foreign.Arena; +import java.lang.foreign.MemorySegment; +import java.lang.invoke.MethodHandles; +import java.lang.invoke.VarHandle; + +@SuppressWarnings("preview") +final class RefCountedSharedArena implements Arena { + + static final int OPEN = 0; + static final int CLOSED = -1; + + static final VarHandle STATE; + + static { Review Comment: There are certainly different approaches here. Conceptually, I think of ref counting as a simple `int` counter, then how to operate on that in a thread-safe way - that's how I got to what is in the PR. Of course, now that I look at it, it could be rewritten with a `AtomicInteger`, since the CAS operations we need are there. And we don't operate on the state outside of that. I updated to use AtomicInteger, since the code is a little more readably, and I don't think that the instance creation will be a problem. I'm on the fence on this one, happy to keep or revert it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
