Re: [PR] Backport to 9x: Initialize facet counting data structures lazily #12408 [lucene]

stefanvodita merged PR #13300: URL: https://github.com/apache/lucene/pull/13300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [PR] Datacube format changes to support materialized views [lucene]

Bukhtawar commented on code in PR #13342: URL: https://github.com/apache/lucene/pull/13342#discussion_r1588928997 ## lucene/core/src/java/org/apache/lucene/index/SegmentInfo.java: ## @@ -124,7 +125,8 @@ public SegmentInfo( Map diagnostics, byte[] id, Map att

Re: [PR] Datacube format changes to support materialized views [lucene]

bharath-techie commented on code in PR #13342: URL: https://github.com/apache/lucene/pull/13342#discussion_r1589030697 ## lucene/core/src/java/org/apache/lucene/index/SegmentInfo.java: ## @@ -124,7 +125,8 @@ public SegmentInfo( Map diagnostics, byte[] id, Ma

Re: [PR] Add new VectorScorer interface to vector value iterators [lucene]

benwtrent commented on code in PR #13181: URL: https://github.com/apache/lucene/pull/13181#discussion_r1589212230 ## lucene/core/src/java/org/apache/lucene/search/VectorScorer.java: ## @@ -18,64 +18,39 @@ import java.io.IOException; import org.apache.lucene.index.ByteVectorV

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

uschindler commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589285702 ## lucene/core/src/java/org/apache/lucene/internal/vectorization/VectorizationProvider.java: ## @@ -198,6 +201,11 @@ private static void ensureCaller() { private

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

uschindler commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589290658 ## lucene/core/src/java/org/apache/lucene/codecs/hnsw/FlatVectorScorerProvider.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

uschindler commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589312414 ## lucene/core/src/java/org/apache/lucene/codecs/hnsw/FlatVectorScorerProvider.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

uschindler commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589314731 ## lucene/core/src/java/org/apache/lucene/internal/vectorization/VectorizationProvider.java: ## @@ -198,6 +201,11 @@ private static void ensureCaller() { private

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

ChrisHegarty commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589316210 ## lucene/core/src/java/org/apache/lucene/internal/vectorization/VectorizationProvider.java: ## @@ -198,6 +201,11 @@ private static void ensureCaller() { priva

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

ChrisHegarty commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589317289 ## lucene/core/src/java/org/apache/lucene/codecs/hnsw/FlatVectorScorerProvider.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

ChrisHegarty commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589323816 ## lucene/core/src/test/org/apache/lucene/search/TestKnnByteVectorQueryMMap.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

ChrisHegarty commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589316210 ## lucene/core/src/java/org/apache/lucene/internal/vectorization/VectorizationProvider.java: ## @@ -198,6 +201,11 @@ private static void ensureCaller() { priva

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

msokolov commented on PR #13339: URL: https://github.com/apache/lucene/pull/13339#issuecomment-2093195536 So excited to see this finally come to fruition! No more double-buffering! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

uschindler commented on PR #13339: URL: https://github.com/apache/lucene/pull/13339#issuecomment-2093209660 How can i change the review to "undecided"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

ChrisHegarty commented on PR #13339: URL: https://github.com/apache/lucene/pull/13339#issuecomment-2093212149 > How can i change the review to "undecided"? I re-requested ur review - so there is no official reviewer yet. Take ur time. I have some luceneutil benchmarks to run, etc. -

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

uschindler commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589339242 ## lucene/core/src/java/org/apache/lucene/codecs/hnsw/FlatVectorScorerProvider.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

uschindler commented on PR #13339: URL: https://github.com/apache/lucene/pull/13339#issuecomment-2093214942 > > How can i change the review to "undecided"? > > I re-requested ur review - so there is no official reviewer yet. Take ur time. I have some luceneutil benchmarks to run, etc.

Re: [I] IndexWriter loses track of parent field when index is empty [lucene]

msokolov commented on issue #13340: URL: https://github.com/apache/lucene/issues/13340#issuecomment-2093214232 @simonw of you get a moment, your perspective would be helpful. Should we be writing index metadata somewhere outside of a segment? Or tweak the hack we have... -- This is an au

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

uschindler commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589359449 ## lucene/core/src/java21/org/apache/lucene/internal/vectorization/MemorySegmentByteVectorScorerSupplier.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache S

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

ChrisHegarty commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589375462 ## lucene/core/src/java21/org/apache/lucene/internal/vectorization/MemorySegmentByteVectorScorerSupplier.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

ChrisHegarty commented on PR #13339: URL: https://github.com/apache/lucene/pull/13339#issuecomment-2093300534 > Dismissing Uwe's review, since he is undecided. Can be explicitly added later, when we convince him ;-) (Oh, this looks harsh!) I hope that I did this right. If not, I apolo

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

ChrisHegarty commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589410048 ## lucene/core/src/java21/org/apache/lucene/internal/vectorization/MemorySegmentByteVectorScorerSupplier.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

uschindler commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589472836 ## lucene/core/src/java21/org/apache/lucene/internal/vectorization/DotProductByteVectorScorerSupplier.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Softw

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

uschindler commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589477380 ## lucene/core/src/java21/org/apache/lucene/internal/vectorization/DotProductByteVectorScorerSupplier.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Softw

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

ChrisHegarty commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589486120 ## lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/VectorScorerBenchmark.java: ## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

uschindler commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589486399 ## lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/VectorScorerBenchmark.java: ## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

uschindler commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589508058 ## lucene/core/src/java21/org/apache/lucene/internal/vectorization/MemorySegmentByteVectorScorerSupplier.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache S

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

uschindler commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589514775 ## lucene/core/src/java21/org/apache/lucene/internal/vectorization/MemorySegmentByteVectorScorerSupplier.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache S

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

ChrisHegarty commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589535535 ## lucene/core/src/java21/org/apache/lucene/internal/vectorization/MemorySegmentByteVectorScorerSupplier.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

uschindler commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589596339 ## lucene/core/src/java21/org/apache/lucene/internal/vectorization/MemorySegmentByteVectorScorerSupplier.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache S

Re: [PR] Add a MemorySegment Vector scorer - for scoring without copying on-heap [lucene]

ChrisHegarty commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589680684 ## lucene/core/src/java21/org/apache/lucene/internal/vectorization/MemorySegmentByteVectorScorerSupplier.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache