uschindler commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589339242
########## lucene/core/src/java/org/apache/lucene/codecs/hnsw/FlatVectorScorerProvider.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.lucene.codecs.hnsw; + +import java.lang.invoke.MethodHandles; +import java.lang.invoke.MethodType; +import org.apache.lucene.internal.vectorization.VectorizationProvider; + +/** + * A utility class that provides access to the default FlatVectorsScorer. + * + * @lucene.experimental + */ +public class FlatVectorScorerProvider { + + /** Returns the default FlatVectorsScorer. */ + public static FlatVectorsScorer createDefault() { + if (isPanamaVectorUtilSupportEnabled()) { + // we only enable this scorer if the Panama vector provider is also enabled + return lookup(); + } + return new DefaultFlatVectorScorer(); + } + + public static FlatVectorsScorer lookup() { Review Comment: Yes very nice now. The whole construct is still a bit strange but at least in main branch quite clean, because we know that MMapDir always available with memory segments, so the vector provider does not need to differentiate. If we want to backport there are more knobs that could change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
