uschindler commented on code in PR #13339:
URL: https://github.com/apache/lucene/pull/13339#discussion_r1589314731
##########
lucene/core/src/java/org/apache/lucene/internal/vectorization/VectorizationProvider.java:
##########
@@ -198,6 +201,11 @@ private static void ensureCaller() {
private static final class Holder {
private Holder() {}
- static final VectorizationProvider INSTANCE = lookup(false);
+ // TODO: this is not quite right. But we should be able to run tests with
Panama Vector
+ static boolean testMode() {
+ return TESTS_VECTOR_SIZE.isPresent() || TESTS_FORCE_INTEGER_VECTORS;
Review Comment:
We must remove this again, because the problem with tests is that they use a
special JVM flag to disable tiered compilation, so C2 never gets active.
By the trick `CI=true` we enable this. We should better document this or
maybe add another sysprop. The code added here makes no sense its just a
workaround to enforce slowness. It works if you have a very fast machine or
only run a few tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
