bharath-techie commented on code in PR #13342: URL: https://github.com/apache/lucene/pull/13342#discussion_r1589030697
########## lucene/core/src/java/org/apache/lucene/index/SegmentInfo.java: ########## @@ -124,7 +125,8 @@ public SegmentInfo( Map<String, String> diagnostics, byte[] id, Map<String, String> attributes, - Sort indexSort) { + Sort indexSort, + DataCubesConfig dataCubesConfig) { Review Comment: Yeah will revert the second commit which removed the overload. I think overload is good , we can remove it if needed based on feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org