uschindler commented on code in PR #13339: URL: https://github.com/apache/lucene/pull/13339#discussion_r1589596339
########## lucene/core/src/java21/org/apache/lucene/internal/vectorization/MemorySegmentByteVectorScorerSupplier.java: ########## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.internal.vectorization; + +import java.io.IOException; +import java.lang.foreign.MemorySegment; +import java.util.Optional; +import org.apache.lucene.index.VectorSimilarityFunction; +import org.apache.lucene.store.FilterIndexInput; +import org.apache.lucene.store.IndexInput; +import org.apache.lucene.store.MemorySegmentAccessInput; +import org.apache.lucene.util.Bits; +import org.apache.lucene.util.hnsw.RandomAccessVectorValues; +import org.apache.lucene.util.hnsw.RandomVectorScorer; +import org.apache.lucene.util.hnsw.RandomVectorScorerSupplier; + +/** A scorer of vectors whose element size is byte. */ +public abstract sealed class MemorySegmentByteVectorScorerSupplier + implements RandomVectorScorerSupplier, RandomVectorScorer + permits DotProductByteVectorScorerSupplier, EuclideanByteVectorScorerSupplier { + final int vectorByteSize; + final int dims; + final int maxOrd; + final MemorySegmentAccessInput input; + + final RandomAccessVectorValues values; // to support ordToDoc/getAcceptOrds + final byte[] scratch1, scratch2; + + MemorySegment first; + + /** + * Return an optional whose value, if present, is the scorer. Otherwise, an empty optional is + * returned. + */ + public static Optional<MemorySegmentByteVectorScorerSupplier> create( + int dims, + int maxOrd, + int vectorByteSize, + VectorSimilarityFunction type, + IndexInput input, + RandomAccessVectorValues values) { + input = FilterIndexInput.unwrap(input); Review Comment: Can we simply remove the unwrapping here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
