[
https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468417#comment-17468417
]
Adrien Grand commented on LUCENE-8739:
--
I updated block sizes so that ZSTD uses the
[
https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468482#comment-17468482
]
Tobias Ibounig commented on LUCENE-8739:
Would it make sense to increase the blo
uschindler commented on pull request #579:
URL: https://github.com/apache/lucene/pull/579#issuecomment-1004639920
> I've been wondering what to do with the security manager. If we're on Java
17, where it's officially deprecated, perhaps we should just get rid of it? I
know it sounds terrib
Uwe Schindler created LUCENE-10352:
--
Summary: Convert TestAllAnalyzersHaveFactories and
TestRandomChains to a global integration test and discover classes to check
from module system
Key: LUCENE-10352
URL: https
[
https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468498#comment-17468498
]
Adrien Grand commented on LUCENE-8739:
--
bq. Would such an increase even make sense
jpountz commented on pull request #579:
URL: https://github.com/apache/lucene/pull/579#issuecomment-1004649045
Sorry @uschindler I should have made it clear that this PR was not passing
precommit checks yet.
Agreed on handling the SecurityManager changes in a separate PR. I only
fix
uschindler commented on pull request #581:
URL: https://github.com/apache/lucene/pull/581#issuecomment-1004649040
> Change looks good to me. I like that tests are improving. We may wish to
someday migrate the `TestAllAnalyzerHaveFactories` and maybe even
`TestRandomChains` to the modular l
[
https://issues.apache.org/jira/browse/LUCENE-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468504#comment-17468504
]
Uwe Schindler commented on LUCENE-10352:
You can watch progress here:
[https:/
[
https://issues.apache.org/jira/browse/LUCENE-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468505#comment-17468505
]
Uwe Schindler commented on LUCENE-10352:
CC [~rmuir]
> Convert TestAllAnalyzer
[
https://issues.apache.org/jira/browse/LUCENE-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10352:
---
Description:
Currently TestAllAnalyzersHaveFactories and TestRandomChains only work on the
[
https://issues.apache.org/jira/browse/LUCENE-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10352:
---
Description:
Currently TestAllAnalyzersHaveFactories and TestRandomChains only work on the
gf2121 commented on pull request #578:
URL: https://github.com/apache/lucene/pull/578#issuecomment-1004760012
Indeed, I am very suprised to see such a big QPS improvement just by
removing some null check and method call. It is also interesting that
BrowseMonthTaxoFacets can be much faster
gf2121 removed a comment on pull request #578:
URL: https://github.com/apache/lucene/pull/578#issuecomment-1004760012
Indeed, I am very suprised to see such a big QPS improvement just by
removing some null check and method call. It is also interesting that
BrowseMonthTaxoFacets can be much
[
https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468610#comment-17468610
]
Tobias Ibounig commented on LUCENE-8739:
Ok this all sounds very good.
Just one
uschindler merged pull request #581:
URL: https://github.com/apache/lucene/pull/581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
[
https://issues.apache.org/jira/browse/LUCENE-10348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468644#comment-17468644
]
ASF subversion and git services commented on LUCENE-10348:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468647#comment-17468647
]
ASF subversion and git services commented on LUCENE-10348:
--
Co
uschindler opened a new pull request #582:
URL: https://github.com/apache/lucene/pull/582
See: https://issues.apache.org/jira/browse/LUCENE-10352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
uschindler commented on a change in pull request #582:
URL: https://github.com/apache/lucene/pull/582#discussion_r778117015
##
File path: gradle/java/modules.gradle
##
@@ -214,7 +214,7 @@ allprojects {
}
// Configure (tasks.test, sourceSets.test)
-tasks.matching
uschindler commented on a change in pull request #582:
URL: https://github.com/apache/lucene/pull/582#discussion_r778121113
##
File path:
lucene/analysis/integration.tests/src/test/org/apache/lucene/analysis/tests/da_UTF8.xml
##
@@ -0,0 +1,1208 @@
+
Review comment:
Tis
uschindler commented on a change in pull request #582:
URL: https://github.com/apache/lucene/pull/582#discussion_r778121113
##
File path:
lucene/analysis/integration.tests/src/test/org/apache/lucene/analysis/tests/da_UTF8.xml
##
@@ -0,0 +1,1208 @@
+
Review comment:
Thi
uschindler commented on a change in pull request #582:
URL: https://github.com/apache/lucene/pull/582#discussion_r778121625
##
File path:
lucene/analysis/integration.tests/src/test/org/apache/lucene/analysis/tests/simple.aff
##
@@ -0,0 +1,20 @@
+SET UTF-8
Review comment:
[
https://issues.apache.org/jira/browse/LUCENE-10348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler resolved LUCENE-10348.
Fix Version/s: 9.1
10.0 (main)
Resolution: Fixed
> Make stopwor
[
https://issues.apache.org/jira/browse/LUCENE-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468664#comment-17468664
]
Uwe Schindler commented on LUCENE-10352:
Here is now a first PR: https://github
uschindler commented on a change in pull request #582:
URL: https://github.com/apache/lucene/pull/582#discussion_r778140193
##
File path:
lucene/analysis/integration.tests/src/test/org/apache/lucene/analysis/tests/ModuleClassDiscovery.java
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-10328:
-
Attachment: image-2022-01-04-16-04-56-563.png
> Module path for compiling and running tests is
[
https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468676#comment-17468676
]
Dawid Weiss commented on LUCENE-10328:
--
I've been working on this for too long and
rmuir commented on pull request #582:
URL: https://github.com/apache/lucene/pull/582#issuecomment-1004897909
This is gonna be fun :) Thanks for starting this! It is almost guaranteed to
find some bugs. Previously only `analyzers-common` got this level of testing. I
will help wrestle these
dweiss commented on pull request #582:
URL: https://github.com/apache/lucene/pull/582#issuecomment-1004900949
@uschindler - can you take a look at #571? Or we can merge that branch here
too. I've converted non-distribution .tests projects there to utilize the test
framework and generally i
mayya-sharipova commented on a change in pull request #580:
URL: https://github.com/apache/lucene/pull/580#discussion_r778170401
##
File path:
lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java
##
@@ -559,6 +561,12 @@ public void tes
dweiss commented on a change in pull request #582:
URL: https://github.com/apache/lucene/pull/582#discussion_r778171354
##
File path: lucene/analysis/integration.tests/src/test/module-info.java
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
uschindler commented on a change in pull request #582:
URL: https://github.com/apache/lucene/pull/582#discussion_r778140193
##
File path:
lucene/analysis/integration.tests/src/test/org/apache/lucene/analysis/tests/ModuleClassDiscovery.java
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed
uschindler commented on a change in pull request #582:
URL: https://github.com/apache/lucene/pull/582#discussion_r778172990
##
File path: lucene/analysis/integration.tests/src/test/module-info.java
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
uschindler commented on pull request #582:
URL: https://github.com/apache/lucene/pull/582#issuecomment-1004909845
> @uschindler - can you take a look at #571? Or we can merge that branch
here too. I've converted non-distribution .tests projects there to utilize the
test framework and gener
dweiss commented on a change in pull request #582:
URL: https://github.com/apache/lucene/pull/582#discussion_r778173223
##
File path:
lucene/analysis/integration.tests/src/test/org/apache/lucene/analysis/tests/ModuleClassDiscovery.java
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to t
dweiss commented on a change in pull request #582:
URL: https://github.com/apache/lucene/pull/582#discussion_r778176703
##
File path: lucene/analysis/integration.tests/src/test/module-info.java
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
uschindler commented on a change in pull request #582:
URL: https://github.com/apache/lucene/pull/582#discussion_r778176445
##
File path: lucene/analysis/integration.tests/src/test/module-info.java
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
uschindler commented on a change in pull request #582:
URL: https://github.com/apache/lucene/pull/582#discussion_r778176916
##
File path: lucene/analysis/integration.tests/src/test/module-info.java
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
[ https://issues.apache.org/jira/browse/LUCENE-10344 ]
Dawid Weiss deleted comment on LUCENE-10344:
--
was (Author: JIRAUSER282805):
My account is hacked. I'm not sure what is going on.
> ECJ batch compiler does not support --patch-module at
[
https://issues.apache.org/jira/browse/LUCENE-10344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468698#comment-17468698
]
Dawid Weiss commented on LUCENE-10344:
--
Sorry, I just noticed your comment. There
[
https://issues.apache.org/jira/browse/LUCENE-10344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-10344.
--
Resolution: Won't Fix
> ECJ batch compiler does not support --patch-module at all
> -
mayya-sharipova commented on a change in pull request #580:
URL: https://github.com/apache/lucene/pull/580#discussion_r778185295
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java
##
@@ -239,6 +239,9 @@ public TopDocs search(Str
Robert Muir created LUCENE-10353:
Summary: Add null injection to analyzer integration tests (e.g.
TestRandomChains)
Key: LUCENE-10353
URL: https://issues.apache.org/jira/browse/LUCENE-10353
Project: L
Adrien Grand created LUCENE-10354:
-
Summary: Clarify contract of codec APIs with missing/disabled
fields
Key: LUCENE-10354
URL: https://issues.apache.org/jira/browse/LUCENE-10354
Project: Lucene - Cor
jpountz opened a new pull request #583:
URL: https://github.com/apache/lucene/pull/583
See https://issues.apache.org/jira/browse/LUCENE-10354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jpountz commented on a change in pull request #580:
URL: https://github.com/apache/lucene/pull/580#discussion_r778216878
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java
##
@@ -239,6 +239,9 @@ public TopDocs search(String fiel
Feng Guo created LUCENE-10355:
-
Summary: Remove EMPTY LongValues in favor of LongValues#ZERO
Key: LUCENE-10355
URL: https://issues.apache.org/jira/browse/LUCENE-10355
Project: Lucene - Core
Issue
[
https://issues.apache.org/jira/browse/LUCENE-10355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Feng Guo updated LUCENE-10355:
--
Component/s: core/codecs
> Remove EMPTY LongValues in favor of LongValues#ZERO
>
[
https://issues.apache.org/jira/browse/LUCENE-10355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Feng Guo updated LUCENE-10355:
--
Description: Remove EMPTY LongValues in favor of LongValues#ZEROS
> Remove EMPTY LongValues in favor
gf2121 closed pull request #584:
URL: https://github.com/apache/lucene/pull/584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
[
https://issues.apache.org/jira/browse/LUCENE-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468745#comment-17468745
]
Uwe Schindler commented on LUCENE-10352:
I found a missing TokenFilter in META_
[
https://issues.apache.org/jira/browse/LUCENE-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468760#comment-17468760
]
Uwe Schindler commented on LUCENE-10352:
I also added a new annotation to lucen
uschindler commented on a change in pull request #582:
URL: https://github.com/apache/lucene/pull/582#discussion_r778280755
##
File path:
lucene/analysis/integration.tests/src/test/org/apache/lucene/analysis/tests/ModuleClassDiscovery.java
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed
uschindler commented on a change in pull request #582:
URL: https://github.com/apache/lucene/pull/582#discussion_r778283613
##
File path:
lucene/analysis/integration.tests/src/test/org/apache/lucene/analysis/tests/ModuleClassDiscovery.java
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed
mayya-sharipova commented on a change in pull request #580:
URL: https://github.com/apache/lucene/pull/580#discussion_r778314409
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java
##
@@ -239,6 +239,9 @@ public TopDocs search(Str
jtibshirani commented on a change in pull request #583:
URL: https://github.com/apache/lucene/pull/583#discussion_r778317069
##
File path: lucene/core/src/java/org/apache/lucene/codecs/FieldsProducer.java
##
@@ -42,6 +45,14 @@ protected FieldsProducer() {}
*/
public abst
sonatype-lift[bot] commented on a change in pull request #582:
URL: https://github.com/apache/lucene/pull/582#discussion_r778334098
##
File path: lucene/core/src/java/org/apache/lucene/util/IgnoreRandomChains.java
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foun
akkig opened a new pull request #2636:
URL: https://github.com/apache/lucene-solr/pull/2636
…e and commit requests for RoutedAlias
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
mayya-sharipova merged pull request #580:
URL: https://github.com/apache/lucene/pull/580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-un
[
https://issues.apache.org/jira/browse/LUCENE-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468847#comment-17468847
]
ASF subversion and git services commented on LUCENE-10351:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468876#comment-17468876
]
ASF subversion and git services commented on LUCENE-10351:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayya Sharipova resolved LUCENE-10351.
--
Fix Version/s: 9.1
Resolution: Fixed
> Correct knn search failure with all de
uschindler commented on a change in pull request #582:
URL: https://github.com/apache/lucene/pull/582#discussion_r778421121
##
File path: lucene/core/src/java/org/apache/lucene/util/IgnoreRandomChains.java
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (
sonatype-lift[bot] commented on a change in pull request #582:
URL: https://github.com/apache/lucene/pull/582#discussion_r778421146
##
File path: lucene/core/src/java/org/apache/lucene/util/IgnoreRandomChains.java
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foun
gsmiller commented on pull request #578:
URL: https://github.com/apache/lucene/pull/578#issuecomment-1005246240
Nice find! With this kind of speedup just for avoiding the null check inside
the counting loop, I wonder if it's worth generalizing beyond countAll? What
about relaxing visibilit
rmuir commented on pull request #582:
URL: https://github.com/apache/lucene/pull/582#issuecomment-1005247521
elsewhere we have the integration tests as `core.tests` and
`distribution.tests`, should this be `analysis.tests`? Currently I am messing
around in this branch with `./gradlew -p lu
gsmiller commented on pull request #574:
URL: https://github.com/apache/lucene/pull/574#issuecomment-1005247653
Great find! For what it's worth, this was overlooked when specializing SSDV
in #255 because it was still using binary doc values at the time. When I
switched over to numeric doc
Greg Miller created LUCENE-10356:
Summary: Special-case singleton doc values for general taxonomy
facet counting
Key: LUCENE-10356
URL: https://issues.apache.org/jira/browse/LUCENE-10356
Project: Luce
[
https://issues.apache.org/jira/browse/LUCENE-10356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468917#comment-17468917
]
Greg Miller commented on LUCENE-10356:
--
PR coming shortly :)
> Special-case singl
[
https://issues.apache.org/jira/browse/LUCENE-10356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller reassigned LUCENE-10356:
Assignee: Greg Miller
> Special-case singleton doc values for general taxonomy facet cou
uschindler commented on pull request #582:
URL: https://github.com/apache/lucene/pull/582#issuecomment-1005287391
> elsewhere we have the integration tests as `core.tests` and
`distribution.tests`, should this be `analysis.tests`? Currently I am messing
around in this branch with `./gradle
uschindler commented on pull request #582:
URL: https://github.com/apache/lucene/pull/582#issuecomment-1005287982
I ran the whole thing the following way:
```
gradlew :lucene:analysis:integration.tests:beast -Dtests.dups=1000
```
No failures yet.
--
This is an automate
uschindler commented on pull request #582:
URL: https://github.com/apache/lucene/pull/582#issuecomment-1005291698
@rmuir I found a failure:
```
$ gradlew :lucene:analysis:integration.tests:test --tests
TestRandomChains.testRandomChainsWithLargeStrings -Dtests.seed=AA632771CC823702
uschindler commented on pull request #582:
URL: https://github.com/apache/lucene/pull/582#issuecomment-1005293671
Another one:
```
$ gradlew :lucene:analysis:integration.tests:test --tests
TestRandomChains.testRandomChains -Dtests.seed=3A0D0E91E0CA5BFC
-Dtests.slow=true -Dtests.l
uschindler edited a comment on pull request #582:
URL: https://github.com/apache/lucene/pull/582#issuecomment-1005291698
@rmuir I found a failure:
```
$ gradlew :lucene:analysis:integration.tests:test --tests
TestRandomChains.testRandomChainsWithLargeStrings -Dtests.seed=AA632771C
[
https://issues.apache.org/jira/browse/LUCENE-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468942#comment-17468942
]
Cameron VandenBerg commented on LUCENE-9537:
Hello [~jpountz]! Thank you fo
[
https://issues.apache.org/jira/browse/LUCENE-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468945#comment-17468945
]
Cameron VandenBerg commented on LUCENE-10157:
-
Hello [~cpoerschke]! I have
gf2121 commented on pull request #578:
URL: https://github.com/apache/lucene/pull/578#issuecomment-1005403431
Thanks @gsmiller for suggestion!
> With this kind of speedup just for avoiding the null check inside the
counting loop.
Yes, this is indeed suprising. I thought `Brows
78 matches
Mail list logo
