gf2121 removed a comment on pull request #578:
URL: https://github.com/apache/lucene/pull/578#issuecomment-1004760012
Indeed, I am very suprised to see such a big QPS improvement just by
removing some null check and method call. It is also interesting that
BrowseMonthTaxoFacets can be much faster then BrowseMonthSSDVFacets now but I
do think they should have similar QPS... I noticed that the stddev is also
becoming much higher, so I wonder if there is a amazing optimization in JVM
that is triggered from time to time after this change? It seems delicious to
find this out and try to make it stable.
To double check, I rerun a wikimediumall benchmark, getting a similar result
(higher QPS & higher stddev)
```
TaskQPS baseline StdDevQPS
my_modified_version StdDev Pct diff p-value
BrowseMonthSSDVFacets 4.67 (9.8%) 4.50
(6.0%) -3.6% ( -17% - 13%) 0.161
BrowseRandomLabelSSDVFacets 3.09 (5.6%) 3.03
(4.6%) -2.0% ( -11% - 8%) 0.211
HighPhrase 15.15 (3.3%) 14.84
(3.8%) -2.0% ( -8% - 5%) 0.074
LowPhrase 37.67 (3.2%) 36.95
(3.6%) -1.9% ( -8% - 5%) 0.080
LowTerm 1671.58 (4.1%) 1644.34
(4.8%) -1.6% ( -10% - 7%) 0.245
HighTerm 1210.15 (5.5%) 1191.05
(7.5%) -1.6% ( -13% - 12%) 0.448
BrowseDayOfYearSSDVFacets 4.19 (6.9%) 4.12
(5.5%) -1.5% ( -13% - 11%) 0.436
LowSloppyPhrase 11.70 (3.4%) 11.52
(1.7%) -1.5% ( -6% - 3%) 0.069
MedPhrase 17.15 (2.5%) 16.90
(3.6%) -1.5% ( -7% - 4%) 0.140
HighSloppyPhrase 8.52 (5.1%) 8.40
(3.2%) -1.4% ( -9% - 7%) 0.287
AndHighMedDayTaxoFacets 45.58 (2.8%) 44.97
(2.2%) -1.3% ( -6% - 3%) 0.093
OrNotHighLow 999.69 (3.1%) 987.25
(3.6%) -1.2% ( -7% - 5%) 0.242
AndHighHighDayTaxoFacets 11.16 (3.2%) 11.02
(3.8%) -1.2% ( -8% - 6%) 0.271
AndHighLow 662.82 (2.5%) 655.64
(3.0%) -1.1% ( -6% - 4%) 0.212
Respell 41.99 (2.7%) 41.58
(3.2%) -1.0% ( -6% - 5%) 0.290
OrHighNotMed 1074.76 (4.8%) 1065.13
(6.7%) -0.9% ( -11% - 11%) 0.626
MedSloppyPhrase 6.08 (3.4%) 6.02
(2.0%) -0.9% ( -6% - 4%) 0.317
AndHighHigh 30.48 (4.4%) 30.26
(4.2%) -0.7% ( -8% - 8%) 0.588
OrHighLow 451.34 (2.9%) 448.36
(4.2%) -0.7% ( -7% - 6%) 0.562
OrNotHighHigh 807.68 (4.5%) 803.96
(5.2%) -0.5% ( -9% - 9%) 0.764
LowIntervalsOrdered 21.59 (5.9%) 21.49
(5.6%) -0.5% ( -11% - 11%) 0.804
AndHighMed 82.97 (3.9%) 82.62
(4.1%) -0.4% ( -8% - 7%) 0.737
PKLookup 196.30 (4.4%) 195.53
(4.0%) -0.4% ( -8% - 8%) 0.769
OrHighNotHigh 815.15 (4.4%) 812.52
(5.8%) -0.3% ( -10% - 10%) 0.843
OrNotHighMed 1132.97 (3.6%) 1130.84
(6.7%) -0.2% ( -10% - 10%) 0.912
MedIntervalsOrdered 18.77 (9.9%) 18.74
(9.2%) -0.2% ( -17% - 21%) 0.958
OrHighHigh 15.86 (5.1%) 15.88
(3.5%) 0.1% ( -8% - 9%) 0.916
Fuzzy1 63.19 (2.6%) 63.33
(2.8%) 0.2% ( -5% - 5%) 0.799
HighIntervalsOrdered 4.97 (10.2%) 4.98
(9.5%) 0.2% ( -17% - 22%) 0.938
OrHighMed 43.11 (4.8%) 43.25
(3.8%) 0.3% ( -7% - 9%) 0.819
IntNRQ 47.52 (27.6%) 47.67
(29.2%) 0.3% ( -44% - 79%) 0.971
Fuzzy2 74.23 (2.7%) 74.48
(3.3%) 0.3% ( -5% - 6%) 0.722
LowSpanNear 85.95 (3.7%) 86.34
(4.5%) 0.5% ( -7% - 9%) 0.731
OrHighMedDayTaxoFacets 1.91 (6.9%) 1.93
(8.0%) 1.1% ( -12% - 17%) 0.655
OrHighNotLow 1181.50 (3.9%) 1194.56
(6.5%) 1.1% ( -8% - 11%) 0.511
MedTerm 1734.50 (4.6%) 1754.47
(5.9%) 1.2% ( -8% - 12%) 0.492
MedTermDayTaxoFacets 11.24 (5.6%) 11.37
(7.7%) 1.2% ( -11% - 15%) 0.576
HighTermMonthSort 9.60 (23.2%) 9.72
(18.3%) 1.2% ( -32% - 55%) 0.852
HighSpanNear 10.32 (3.9%) 10.46
(4.3%) 1.4% ( -6% - 9%) 0.289
MedSpanNear 2.74 (4.1%) 2.79
(4.6%) 2.1% ( -6% - 11%) 0.130
HighTermDayOfYearSort 43.60 (14.0%) 44.66
(16.9%) 2.4% ( -24% - 38%) 0.619
Prefix3 19.72 (21.3%) 20.62
(17.8%) 4.6% ( -28% - 55%) 0.462
Wildcard 36.11 (9.6%) 37.81
(9.0%) 4.7% ( -12% - 25%) 0.109
TermDTSort 82.04 (13.2%) 87.57
(18.3%) 6.7% ( -21% - 44%) 0.182
HighTermTitleBDVSort 54.11 (13.7%) 58.78
(18.9%) 8.6% ( -21% - 47%) 0.099
BrowseMonthTaxoFacets 5.10 (15.2%) 7.21
(79.7%) 41.4% ( -46% - 160%) 0.023
BrowseRandomLabelTaxoFacets 4.04 (9.8%) 5.99
(87.3%) 48.3% ( -44% - 161%) 0.014
BrowseDateTaxoFacets 4.62 (12.9%) 6.96
(90.6%) 50.6% ( -46% - 177%) 0.014
BrowseDayOfYearTaxoFacets 4.68 (13.4%) 7.10
(92.6%) 51.8% ( -47% - 182%) 0.013
```
Java version:
```
java version "16.0.2" 2021-07-20
Java(TM) SE Runtime Environment (build 16.0.2+7-67)
Java HotSpot(TM) 64-Bit Server VM (build 16.0.2+7-67, mixed mode, sharing)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
