uschindler commented on pull request #581: URL: https://github.com/apache/lucene/pull/581#issuecomment-1004649040
> Change looks good to me. I like that tests are improving. We may wish to someday migrate the `TestAllAnalyzerHaveFactories` and maybe even `TestRandomChains` to the modular layer. This way we know for sure all the things really work with the module system. But that's for another day. I started https://issues.apache.org/jira/browse/LUCENE-10352, you can watch progress here: https://github.com/uschindler/lucene/compare/jira/LUCENE-10348...uschindler:draft/random-chains -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
