mayya-sharipova commented on a change in pull request #580: URL: https://github.com/apache/lucene/pull/580#discussion_r778170401
########## File path: lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java ########## @@ -559,6 +561,12 @@ public void testDeleteAllVectorDocs() throws Exception { VectorValues values = getOnlyLeafReader(r).getVectorValues("v"); assertNotNull(values); assertEquals(0, values.size()); + + // assert that knn search doesn't fail on a field with all deleted docs + IndexSearcher searcher = newSearcher(r); Review comment: @jtibshirani Thanks for the review. I've adjusted the test in b4dfe087bf4a2f8686c1d90f1f658389b94f3f1f -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org