uschindler commented on a change in pull request #582: URL: https://github.com/apache/lucene/pull/582#discussion_r778172990
########## File path: lucene/analysis/integration.tests/src/test/module-info.java ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +/** + * Test module for global integration tests of all {@code org.apache.lucene.analysis} + * packages/modules. + */ +@SuppressWarnings({"requires-automatic"}) +module org.apache.lucene.analysis.tests { + requires java.xml; + requires org.apache.lucene.core; + requires org.apache.lucene.analysis.common; + requires org.apache.lucene.analysis.icu; + requires org.apache.lucene.analysis.kuromoji; + requires org.apache.lucene.analysis.morfologik; + requires org.apache.lucene.analysis.nori; + requires org.apache.lucene.analysis.opennlp; + requires org.apache.lucene.analysis.phonetic; + requires org.apache.lucene.analysis.smartcn; + requires org.apache.lucene.analysis.stempel; + requires org.apache.lucene.test_framework; + requires junit; Review comment: Ok I wanted to cleanup the requires clauses at end. We may need to add more transitive stuff, especially when we expose APIs or required modules, otherwise we will get "exports" warnings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
