dweiss commented on a change in pull request #582: URL: https://github.com/apache/lucene/pull/582#discussion_r778173223
########## File path: lucene/analysis/integration.tests/src/test/org/apache/lucene/analysis/tests/ModuleClassDiscovery.java ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.analysis.tests; + +import java.io.IOException; +import java.lang.module.ResolvedModule; +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import java.util.SortedMap; +import java.util.TreeMap; +import org.apache.lucene.tests.util.LuceneTestCase; +import org.junit.Assert; + +/** Discovers all classes from the module graph and loads them (without initialization) */ +abstract class ModuleClassDiscovery { + + private static final Module THIS_MODULE = ModuleClassDiscovery.class.getModule(); + private static final ModuleLayer LAYER = THIS_MODULE.getLayer(); + private static final SortedMap<String, ResolvedModule> ALL_ANALYSIS_MODULES; + + static { Review comment: it'd be great if this wasn't a static final but a lazily-computed static - static finals are, from test framework point of view, sort of evil because they cannot be ordered reasonably with respect to test execution lifecycle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
