[GitHub] [lucene] jpountz opened a new pull request #502: Make EndiannessReverser(Data|Index)Input always reverse byte order.

2021-12-02 Thread GitBox
jpountz opened a new pull request #502: URL: https://github.com/apache/lucene/pull/502 Currently EndiannessReverser(Data|Index)Input doesn't reverse the byte order for `readLongs` and `readFloats`. The reasoning is that these two method replaced `readLELongs` and `readLEFloats`, so th

[jira] [Commented] (LUCENE-10233) Store docIds as bitset when leafCardinality = 1 to speed up addAll

2021-12-02 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452234#comment-17452234 ] Adrien Grand commented on LUCENE-10233: --- I opened a PR that changes the way we ha

[GitHub] [lucene] zacharymorn commented on pull request #418: LUCENE-10061: Implements dynamic pruning support for CombinedFieldsQuery

2021-12-02 Thread GitBox
zacharymorn commented on pull request #418: URL: https://github.com/apache/lucene/pull/418#issuecomment-984393347 > Maybe we could have a SynonymImpactsSource or something like that as a public @lucene.internal class in core that would provide this logic. Ah yes using `@lucene.intern

[GitHub] [lucene] zacharymorn commented on pull request #418: LUCENE-10061: Implements dynamic pruning support for CombinedFieldsQuery

2021-12-02 Thread GitBox
zacharymorn commented on pull request #418: URL: https://github.com/apache/lucene/pull/418#issuecomment-984406785 > Yes. I liked this approach because it felt like it should work relatively well since the field with the highest weight should drive scores anyway, and deciding about which cl

[GitHub] [lucene] uschindler commented on pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-02 Thread GitBox
uschindler commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-984411366 This task would also be useful later when we maintain the module during its lifetime. I like the general idea. I was thinking about some extension, so we can add some sour

[jira] [Resolved] (LUCENE-10269) Add the ability to read KD trees from right to left

2021-12-02 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera resolved LUCENE-10269. --- Assignee: Ignacio Vera Resolution: Workaround Agreed, if we see there is traction or

[GitHub] [lucene] iverase merged pull request #498: LUCENE-10275: Add interval tree to MultiRangeQuery

2021-12-02 Thread GitBox
iverase merged pull request #498: URL: https://github.com/apache/lucene/pull/498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (LUCENE-10275) Use interval tree in MultiRangeQuery

2021-12-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452246#comment-17452246 ] ASF subversion and git services commented on LUCENE-10275: -- Co

[jira] [Commented] (LUCENE-10275) Use interval tree in MultiRangeQuery

2021-12-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452249#comment-17452249 ] ASF subversion and git services commented on LUCENE-10275: -- Co

[jira] [Resolved] (LUCENE-10275) Use interval tree in MultiRangeQuery

2021-12-02 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera resolved LUCENE-10275. --- Fix Version/s: 9.1 Assignee: Ignacio Vera Resolution: Fixed > Use interval

[jira] [Created] (LUCENE-10279) Fix equal and hashCode in MultiRange query

2021-12-02 Thread Ignacio Vera (Jira)
Ignacio Vera created LUCENE-10279: - Summary: Fix equal and hashCode in MultiRange query Key: LUCENE-10279 URL: https://issues.apache.org/jira/browse/LUCENE-10279 Project: Lucene - Core Issue

[GitHub] [lucene] iverase opened a new pull request #503: LUCENE-10279: Fix equals in MultiRangeQuery

2021-12-02 Thread GitBox
iverase opened a new pull request #503: URL: https://github.com/apache/lucene/pull/503 This PR implements equals and hashcode for RangeClause which fixes the current implementation of equals and has code for MultiRangeQuery. -- This is an automated message from the Apache Git Service. T

[GitHub] [lucene] dweiss commented on pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-02 Thread GitBox
dweiss commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-984461544 > There was invisible directory .gradle under dev-tools/missing-doclet/bin/. I'm not sure when the directory was created. Typically such directories are created by IDEs (intel

[GitHub] [lucene] rmuir merged pull request #500: improve term vector merging tests

2021-12-02 Thread GitBox
rmuir merged pull request #500: URL: https://github.com/apache/lucene/pull/500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [lucene] sonatype-lift[bot] commented on a change in pull request #418: LUCENE-10061: Implements dynamic pruning support for CombinedFieldsQuery

2021-12-02 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #418: URL: https://github.com/apache/lucene/pull/418#discussion_r760988572 ## File path: lucene/core/src/java/org/apache/lucene/search/ImpactsMergingUtils.java ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene] costin commented on pull request #453: Investigate whether should Packed64 use a byte[] plus VarHandles instead of a long[]

2021-12-02 Thread GitBox
costin commented on pull request #453: URL: https://github.com/apache/lucene/pull/453#issuecomment-984534767 Updated the benchmark to use JMH `blackhole` and tested it with/without the blackhole flag enabled on the Java 17.0.1 compiler and got the following results: ``` Benchmark

[GitHub] [lucene] rmuir opened a new pull request #504: Make TestNRTReplication.testCrashReplica nightly

2021-12-02 Thread GitBox
rmuir opened a new pull request #504: URL: https://github.com/apache/lucene/pull/504 This test is forking and crashing JVMs, always runs over 10 seconds. The other JVM-crashers are nightly, this one slipped through. Sorry I don't have a good quick solution yet to make the test run

[GitHub] [lucene] rmuir commented on a change in pull request #503: LUCENE-10279: Fix equals in MultiRangeQuery

2021-12-02 Thread GitBox
rmuir commented on a change in pull request #503: URL: https://github.com/apache/lucene/pull/503#discussion_r761010365 ## File path: lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestMultiRangeQueries.java ## @@ -649,4 +649,109 @@ public void testToString() {

[GitHub] [lucene] rmuir opened a new pull request #505: tone down BaseTermVectorsFormatTestCase.testLotsOfFields in non-nightly

2021-12-02 Thread GitBox
rmuir opened a new pull request #505: URL: https://github.com/apache/lucene/pull/505 This test runs across every IndexOptions, indexing hundreds of fields. It is slow for some implementations (e.g. SimpleText): ``` The slowest tests (exceeding 500 ms) during this run: 8.31

[GitHub] [lucene] rmuir opened a new pull request #506: tone down TestIndexWriter.testMaxCompletedSequenceNumber in non-nightly

2021-12-02 Thread GitBox
rmuir opened a new pull request #506: URL: https://github.com/apache/lucene/pull/506 this test currently indexes up to 600 docs for each thread. ``` The slowest tests (exceeding 500 ms) during this run: 7.88s TestIndexWriter.testMaxCompletedSequenceNumber (:lucene:core) ``

[GitHub] [lucene] iverase commented on a change in pull request #503: LUCENE-10279: Fix equals in MultiRangeQuery

2021-12-02 Thread GitBox
iverase commented on a change in pull request #503: URL: https://github.com/apache/lucene/pull/503#discussion_r761036341 ## File path: lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestMultiRangeQueries.java ## @@ -649,4 +649,109 @@ public void testToString() {

[GitHub] [lucene] sonatype-lift[bot] commented on a change in pull request #503: LUCENE-10279: Fix equals in MultiRangeQuery

2021-12-02 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #503: URL: https://github.com/apache/lucene/pull/503#discussion_r761044643 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java ## @@ -56,6 +56,26 @@ public RangeClause(byte[] lower

[GitHub] [lucene] rmuir commented on pull request #502: Make EndiannessReverser(Data|Index)Input always reverse byte order.

2021-12-02 Thread GitBox
rmuir commented on pull request #502: URL: https://github.com/apache/lucene/pull/502#issuecomment-984583479 yeah I think its the least-confusing solution. The number of old call sites that were calling `readLELongs` isn't going to increase, so going forwards, the back-compat will hassle us

[GitHub] [lucene] rmuir commented on a change in pull request #503: LUCENE-10279: Fix equals in MultiRangeQuery

2021-12-02 Thread GitBox
rmuir commented on a change in pull request #503: URL: https://github.com/apache/lucene/pull/503#discussion_r761047499 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java ## @@ -56,6 +56,26 @@ public RangeClause(byte[] lowerValue, byte[]

[GitHub] [lucene] iverase merged pull request #503: LUCENE-10279: Fix equals in MultiRangeQuery

2021-12-02 Thread GitBox
iverase merged pull request #503: URL: https://github.com/apache/lucene/pull/503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (LUCENE-10279) Fix equal and hashCode in MultiRange query

2021-12-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452380#comment-17452380 ] ASF subversion and git services commented on LUCENE-10279: -- Co

[jira] [Resolved] (LUCENE-10279) Fix equal and hashCode in MultiRange query

2021-12-02 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera resolved LUCENE-10279. --- Fix Version/s: 9.1 Assignee: Ignacio Vera Resolution: Fixed > Fix equal and

[jira] [Commented] (LUCENE-10279) Fix equal and hashCode in MultiRange query

2021-12-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452385#comment-17452385 ] ASF subversion and git services commented on LUCENE-10279: -- Co

[GitHub] [lucene] iverase opened a new pull request #507: LUCENE-10279: add entry in CHANGES.txt and make RangeClause final

2021-12-02 Thread GitBox
iverase opened a new pull request #507: URL: https://github.com/apache/lucene/pull/507 Follow up of https://github.com/apache/lucene/pull/503. Adding an entry in CHANGES.txt and making RangeClause final. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [lucene] iverase commented on a change in pull request #503: LUCENE-10279: Fix equals in MultiRangeQuery

2021-12-02 Thread GitBox
iverase commented on a change in pull request #503: URL: https://github.com/apache/lucene/pull/503#discussion_r761059134 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java ## @@ -56,6 +56,26 @@ public RangeClause(byte[] lowerValue, byte

[GitHub] [lucene] jpountz merged pull request #502: Make EndiannessReverser(Data|Index)Input always reverse byte order.

2021-12-02 Thread GitBox
jpountz merged pull request #502: URL: https://github.com/apache/lucene/pull/502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [lucene] iverase commented on pull request #502: Make EndiannessReverser(Data|Index)Input always reverse byte order.

2021-12-02 Thread GitBox
iverase commented on pull request #502: URL: https://github.com/apache/lucene/pull/502#issuecomment-984616712 Late to the party but I agree that this makes it more consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [lucene] mocobeta commented on pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-02 Thread GitBox
mocobeta commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-984635576 Could I go one step further to make life easier (for me...) https://github.com/dweiss/lucene/pull/4 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [lucene] sonatype-lift[bot] commented on a change in pull request #453: Investigate whether should Packed64 use a byte[] plus VarHandles instead of a long[]

2021-12-02 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #453: URL: https://github.com/apache/lucene/pull/453#discussion_r761116584 ## File path: lucene/core/src/java/org/apache/lucene/util/packed/Packed64VHLongAndByte.java ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache S

[jira] [Commented] (LUCENE-10233) Store docIds as bitset when leafCardinality = 1 to speed up addAll

2021-12-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452456#comment-17452456 ] ASF subversion and git services commented on LUCENE-10233: -- Co

[GitHub] [lucene] jpountz merged pull request #501: LUCENE-10278: don't write zero-sized array in this test

2021-12-02 Thread GitBox
jpountz merged pull request #501: URL: https://github.com/apache/lucene/pull/501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (LUCENE-10278) BKD TestDocIdsWriter.testRandom failure

2021-12-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452457#comment-17452457 ] ASF subversion and git services commented on LUCENE-10278: -- Co

[GitHub] [lucene] tiurin opened a new pull request #508: Remove duplicate entry in SpanishPluralStemmer invariants list

2021-12-02 Thread GitBox
tiurin opened a new pull request #508: URL: https://github.com/apache/lucene/pull/508 The word "quinientos" is repeated 2 times in the `invariantsList` constant. Removing the extra entry. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [lucene] tiurin commented on pull request #508: Remove duplicate entry in SpanishPluralStemmer invariants list

2021-12-02 Thread GitBox
tiurin commented on pull request #508: URL: https://github.com/apache/lucene/pull/508#issuecomment-984725473 @xaviersanchez FYI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [lucene] rmuir commented on a change in pull request #508: Remove duplicate entry in SpanishPluralStemmer invariants list

2021-12-02 Thread GitBox
rmuir commented on a change in pull request #508: URL: https://github.com/apache/lucene/pull/508#discussion_r761208470 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishPluralStemmer.java ## @@ -119,7 +119,6 @@ "portamantas",

[jira] [Commented] (LUCENE-10278) BKD TestDocIdsWriter.testRandom failure

2021-12-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452467#comment-17452467 ] ASF subversion and git services commented on LUCENE-10278: -- Co

[jira] [Commented] (LUCENE-10233) Store docIds as bitset when leafCardinality = 1 to speed up addAll

2021-12-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452466#comment-17452466 ] ASF subversion and git services commented on LUCENE-10233: -- Co

[jira] [Resolved] (LUCENE-10278) BKD TestDocIdsWriter.testRandom failure

2021-12-02 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10278. --- Fix Version/s: 9.1 Resolution: Fixed > BKD TestDocIdsWriter.testRandom failure > ---

[GitHub] [lucene] xaviersanchez commented on a change in pull request #508: Remove duplicate entry in SpanishPluralStemmer invariants list

2021-12-02 Thread GitBox
xaviersanchez commented on a change in pull request #508: URL: https://github.com/apache/lucene/pull/508#discussion_r761211829 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishPluralStemmer.java ## @@ -119,7 +119,6 @@ "portamantas",

[GitHub] [lucene] jpountz commented on pull request #499: LUCENE-10233: Use AND NOT for inverse intersector

2021-12-02 Thread GitBox
jpountz commented on pull request #499: URL: https://github.com/apache/lucene/pull/499#issuecomment-984743048 @iverase I think you are the right person to review this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [lucene] iverase commented on a change in pull request #499: LUCENE-10233: Use AND NOT for inverse intersector

2021-12-02 Thread GitBox
iverase commented on a change in pull request #499: URL: https://github.com/apache/lucene/pull/499#discussion_r761227803 ## File path: lucene/core/src/java/org/apache/lucene/util/FixedBitSet.java ## @@ -351,16 +351,38 @@ private void and(final long[] otherArr, final int otherN

[GitHub] [lucene] jpountz commented on a change in pull request #486: LUCENE-9619: Remove IntersectVisitor from PointsTree API

2021-12-02 Thread GitBox
jpountz commented on a change in pull request #486: URL: https://github.com/apache/lucene/pull/486#discussion_r761233070 ## File path: lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ## @@ -505,80 +504,29 @@ public long size() { } @Overrid

[GitHub] [lucene] iverase commented on a change in pull request #486: LUCENE-9619: Remove IntersectVisitor from PointsTree API

2021-12-02 Thread GitBox
iverase commented on a change in pull request #486: URL: https://github.com/apache/lucene/pull/486#discussion_r761244824 ## File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java ## @@ -361,14 +405,29 @@ private void intersect(IntersectVisitor visitor, PointT

[GitHub] [lucene-solr] thelabdude opened a new pull request #2620: SOLR-15825: Security UI 'hasPermission' check should check if the user has the all permission if the requested permission is not defi

2021-12-02 Thread GitBox
thelabdude opened a new pull request #2620: URL: https://github.com/apache/lucene-solr/pull/2620 backport of https://github.com/apache/solr/pull/437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] thelabdude merged pull request #2620: SOLR-15825: Security UI 'hasPermission' check should check if the user has the all permission if the requested permission is not defined

2021-12-02 Thread GitBox
thelabdude merged pull request #2620: URL: https://github.com/apache/lucene-solr/pull/2620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [lucene] uschindler commented on pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-02 Thread GitBox
uschindler commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-984774533 Hi @mocobeta: Please remove all "uses" statements in all modules, except in "org.apache.lucene.core" module. I have seen that you added it to the scaffold tool. "uses" me

[GitHub] [lucene] uschindler edited a comment on pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-02 Thread GitBox
uschindler edited a comment on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-984774533 Hi @mocobeta: Please remove all "uses" statements in all modules, except in "org.apache.lucene.core" module. I have seen that you added it to the scaffold tool. "u

[GitHub] [lucene] iverase commented on a change in pull request #486: LUCENE-9619: Remove IntersectVisitor from PointsTree API

2021-12-02 Thread GitBox
iverase commented on a change in pull request #486: URL: https://github.com/apache/lucene/pull/486#discussion_r761250414 ## File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java ## @@ -361,14 +405,29 @@ private void intersect(IntersectVisitor visitor, PointT

[GitHub] [lucene] iverase commented on a change in pull request #486: LUCENE-9619: Remove IntersectVisitor from PointsTree API

2021-12-02 Thread GitBox
iverase commented on a change in pull request #486: URL: https://github.com/apache/lucene/pull/486#discussion_r761251202 ## File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java ## @@ -269,22 +270,33 @@ protected PointValues() {} long size(); /**

[GitHub] [lucene] iverase commented on a change in pull request #486: LUCENE-9619: Remove IntersectVisitor from PointsTree API

2021-12-02 Thread GitBox
iverase commented on a change in pull request #486: URL: https://github.com/apache/lucene/pull/486#discussion_r761251552 ## File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java ## @@ -323,10 +355,18 @@ default void grow(int count) {} */ public final v

[GitHub] [lucene] mocobeta commented on pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-02 Thread GitBox
mocobeta commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-984777325 @uschindler ah right, sure. I will remove all uses statements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [lucene] iverase commented on a change in pull request #486: LUCENE-9619: Remove IntersectVisitor from PointsTree API

2021-12-02 Thread GitBox
iverase commented on a change in pull request #486: URL: https://github.com/apache/lucene/pull/486#discussion_r761252070 ## File path: lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ## @@ -505,80 +504,29 @@ public long size() { } @Overrid

[GitHub] [lucene] danmuzi commented on pull request #496: move build related changes entry to the 'Build' section from 'Other' section

2021-12-02 Thread GitBox
danmuzi commented on pull request #496: URL: https://github.com/apache/lucene/pull/496#issuecomment-984779348 I saw this PR a little late. Thank you for reflecting my patch! @mocobeta -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [lucene] uschindler commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-02 Thread GitBox
uschindler commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r761255741 ## File path: lucene/core/src/java-module/module-info.java ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [lucene] mocobeta commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-02 Thread GitBox
mocobeta commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r761263744 ## File path: gradle/java/modules.gradle ## @@ -0,0 +1,169 @@ +import java.util.jar.JarFile +import java.util.stream.Collectors + +/* + * Licensed to the Ap

[GitHub] [lucene] uschindler commented on pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-02 Thread GitBox
uschindler commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-984789671 I checked all usages: NamedSPILoader: https://github.com/apache/lucene/search?q=%22new+NamedSPILoader%22: - KnnVectorsFormat - SortFieldProvider - DocValuesFormat

[GitHub] [lucene] xaviersanchez commented on a change in pull request #508: Remove duplicate entry in SpanishPluralStemmer invariants list

2021-12-02 Thread GitBox
xaviersanchez commented on a change in pull request #508: URL: https://github.com/apache/lucene/pull/508#discussion_r761267104 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishPluralStemmer.java ## @@ -119,7 +119,6 @@ "portamantas",

[GitHub] [lucene] xaviersanchez commented on a change in pull request #508: Remove duplicate entry in SpanishPluralStemmer invariants list

2021-12-02 Thread GitBox
xaviersanchez commented on a change in pull request #508: URL: https://github.com/apache/lucene/pull/508#discussion_r761267104 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishPluralStemmer.java ## @@ -119,7 +119,6 @@ "portamantas",

[GitHub] [lucene] uschindler edited a comment on pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-02 Thread GitBox
uschindler edited a comment on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-984789671 I checked all usages: NamedSPILoader: https://github.com/apache/lucene/search?q=%22new+NamedSPILoader%22: - KnnVectorsFormat - SortFieldProvider - DocValue

[GitHub] [lucene] uschindler commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-02 Thread GitBox
uschindler commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r761290807 ## File path: gradle/java/modules.gradle ## @@ -0,0 +1,169 @@ +import java.util.jar.JarFile +import java.util.stream.Collectors + +/* + * Licensed to the

[GitHub] [lucene] uschindler commented on pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-02 Thread GitBox
uschindler commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-984816801 I fixed again a windows problem. In Gradle never ever use regular expressions on files and filenames. There's include/exclude on PatternFilterable for it (known from Ant).

[GitHub] [lucene] uschindler commented on pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-02 Thread GitBox
uschindler commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-984823396 I would leave the utility tasks in the project. They are useful, if you want to spawn a new module. We may also use them to add some checks (like we can verify using this that t

[GitHub] [lucene] gf2121 commented on pull request #499: LUCENE-10233: Use AND NOT for inverse intersector

2021-12-02 Thread GitBox
gf2121 commented on pull request #499: URL: https://github.com/apache/lucene/pull/499#issuecomment-984831680 @iverase Thanks a lot for the great advices! Ready for another look :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [lucene] ChrisHegarty commented on pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-02 Thread GitBox
ChrisHegarty commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-984843040 This is great progress, well done to all involved. I have a work-in-progress crummy prototype with the core of [Elasticsearch modularized][1] (it still needs a lot of cleanup

[GitHub] [lucene] uschindler commented on pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-02 Thread GitBox
uschindler commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-984864748 > This is great progress, well done to all involved. I have a work-in-progress crummy prototype with the core of [Elasticsearch modularized](https://github.com/elastic/elasticse

[GitHub] [lucene] sonatype-lift[bot] commented on a change in pull request #486: LUCENE-9619: Remove IntersectVisitor from PointsTree API

2021-12-02 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #486: URL: https://github.com/apache/lucene/pull/486#discussion_r761358324 ## File path: lucene/test-framework/src/java/org/apache/lucene/index/BasePointsFormatTestCase.java ## @@ -1070,29 +1071,13 @@ private void assert

[jira] [Resolved] (LUCENE-10267) Gradle does not write module version attribute for modules with zero dependencies

2021-12-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10267. -- Resolution: Fixed > Gradle does not write module version attribute for modules with zero > d

[GitHub] [lucene-solr] thelabdude opened a new pull request #2621: SOLR-15828: AuthTool (in SolrCLI) should include the config-read, collection-admin-read, core-admin-read, and all permissions in the

2021-12-02 Thread GitBox
thelabdude opened a new pull request #2621: URL: https://github.com/apache/lucene-solr/pull/2621 backport of https://github.com/apache/solr/pull/438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene] rmuir commented on pull request #508: Remove duplicate entries in SpanishPluralStemmer invariants list

2021-12-02 Thread GitBox
rmuir commented on pull request #508: URL: https://github.com/apache/lucene/pull/508#issuecomment-984921948 Thank you @tiurin @xaviersanchez -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [lucene] rmuir merged pull request #508: Remove duplicate entries in SpanishPluralStemmer invariants list

2021-12-02 Thread GitBox
rmuir merged pull request #508: URL: https://github.com/apache/lucene/pull/508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [lucene-solr] thelabdude merged pull request #2621: SOLR-15828: AuthTool (in SolrCLI) should include the config-read, collection-admin-read, core-admin-read, and all permissions in the initia

2021-12-02 Thread GitBox
thelabdude merged pull request #2621: URL: https://github.com/apache/lucene-solr/pull/2621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[jira] [Commented] (LUCENE-10255) Fully embrace the java module system

2021-12-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452578#comment-17452578 ] Dawid Weiss commented on LUCENE-10255: -- I've added an automatic check verifying th

[jira] [Resolved] (LUCENE-10277) Add a sanity check of consistency between services provided by the modular and classpath layer

2021-12-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10277. -- Resolution: Fixed I know other things can be checked in a similar vain (packages). I'm closin

[jira] [Updated] (LUCENE-10255) Fully embrace the java module system

2021-12-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10255: - Description: I've experimented a bit trying to move the code to the JMS. It is _surprisingly d

[GitHub] [lucene] dweiss commented on pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-02 Thread GitBox
dweiss commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-984949140 @uschindler @mocobeta @rmuir - this is how I think we should enforce consistency until a way is found to maybe generate one from the other (my understanding at the moment is that su

[GitHub] [lucene-solr] janhoy opened a new pull request #2622: SOLR-15826 ResourceLoader should better respect allowed paths

2021-12-02 Thread GitBox
janhoy opened a new pull request #2622: URL: https://github.com/apache/lucene-solr/pull/2622 https://issues.apache.org/jira/browse/SOLR-15826 backport from main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene] uschindler commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-02 Thread GitBox
uschindler commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r761470809 ## File path: lucene/distribution-tests/src/test/org/apache/lucene/distribution/TestModularLayer.java ## @@ -108,4 +140,76 @@ public void testAllModulesH

[GitHub] [lucene] uschindler commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-02 Thread GitBox
uschindler commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r761473889 ## File path: lucene/distribution-tests/src/test/org/apache/lucene/distribution/TestModularLayer.java ## @@ -108,4 +140,76 @@ public void testAllModulesH

[GitHub] [lucene] zhaih commented on pull request #225: LUCENE-10010 Introduce NFARunAutomaton to run NFA directly

2021-12-02 Thread GitBox
zhaih commented on pull request #225: URL: https://github.com/apache/lucene/pull/225#issuecomment-985053769 @rmuir I've done the benchmark! (Sorry for the delay): and result looks plain (which is good for this change) ``` TaskQPS base StdDevQPS cand

[GitHub] [lucene] zhaih commented on a change in pull request #225: LUCENE-10010 Introduce NFARunAutomaton to run NFA directly

2021-12-02 Thread GitBox
zhaih commented on a change in pull request #225: URL: https://github.com/apache/lucene/pull/225#discussion_r761533567 ## File path: lucene/CHANGES.txt ## @@ -7,6 +7,8 @@ http://s.apache.org/luceneversions New Features +* LUCENE-10010 Introduce NFARunAutomaton to run NFA d

[GitHub] [lucene] sonatype-lift[bot] commented on a change in pull request #225: LUCENE-10010 Introduce NFARunAutomaton to run NFA directly

2021-12-02 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #225: URL: https://github.com/apache/lucene/pull/225#discussion_r761596350 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/NFARunAutomaton.java ## @@ -0,0 +1,429 @@ +/* + * Licensed to the Apache Soft

[GitHub] [lucene] mocobeta commented on pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-02 Thread GitBox
mocobeta commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-985198581 Tried to add the module descriptors to other analysis subprojects. Except for morfologik module, it seems to work. https://github.com/dweiss/lucene/pull/6 -- This is an autom

[GitHub] [lucene] zacharymorn commented on pull request #418: LUCENE-10061: Implements dynamic pruning support for CombinedFieldsQuery

2021-12-02 Thread GitBox
zacharymorn commented on pull request #418: URL: https://github.com/apache/lucene/pull/418#issuecomment-985229215 I just added two logging statements in `ImpactsDISI` to print out `upTo` and max score comparison to examine the docs pruning results: ``` diff --git a/lucene/core/src

[GitHub] [lucene] iverase merged pull request #507: LUCENE-10279: add entry in CHANGES.txt and make RangeClause final

2021-12-02 Thread GitBox
iverase merged pull request #507: URL: https://github.com/apache/lucene/pull/507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (LUCENE-10279) Fix equal and hashCode in MultiRange query

2021-12-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452774#comment-17452774 ] ASF subversion and git services commented on LUCENE-10279: -- Co

[jira] [Commented] (LUCENE-10279) Fix equal and hashCode in MultiRange query

2021-12-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452773#comment-17452773 ] ASF subversion and git services commented on LUCENE-10279: -- Co

[jira] [Created] (LUCENE-10280) Store BKD blocks with continuous ids more efficiently

2021-12-02 Thread Feng Guo (Jira)
Feng Guo created LUCENE-10280: - Summary: Store BKD blocks with continuous ids more efficiently Key: LUCENE-10280 URL: https://issues.apache.org/jira/browse/LUCENE-10280 Project: Lucene - Core Iss

[jira] [Updated] (LUCENE-10280) Store BKD blocks with continuous ids more efficiently

2021-12-02 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Guo updated LUCENE-10280: -- Description: For scenes that index is sorted on the field, blocks with continuous ids may be a common

[GitHub] [lucene] dweiss commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-02 Thread GitBox
dweiss commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r761687444 ## File path: lucene/distribution-tests/src/test/org/apache/lucene/distribution/TestModularLayer.java ## @@ -108,4 +140,76 @@ public void testAllModulesHaveE

[GitHub] [lucene] dweiss commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-02 Thread GitBox
dweiss commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r761687631 ## File path: lucene/distribution-tests/src/test/org/apache/lucene/distribution/TestModularLayer.java ## @@ -108,4 +140,76 @@ public void testAllModulesHaveE

[GitHub] [lucene] mdmarshmallow opened a new pull request #509: LUCENE-10250: Add support for arbitrary length hierarchical SSDV facets

2021-12-02 Thread GitBox
mdmarshmallow opened a new pull request #509: URL: https://github.com/apache/lucene/pull/509 # Description Currently, SSDV faceting doesn't support hierarchical labels with a hierarchy of greater than 2. This change enables hierarchical labels of arbitrary length with SS

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2021-12-02 Thread Marc D'Mello (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452783#comment-17452783 ] Marc D'Mello commented on LUCENE-10250: --- Made a PR here for this issue: https://g

[jira] [Created] (LUCENE-10281) Error condition used to judge whether hits are sparse in StringValueFacetCounts

2021-12-02 Thread Lu Xugang (Jira)
Lu Xugang created LUCENE-10281: -- Summary: Error condition used to judge whether hits are sparse in StringValueFacetCounts Key: LUCENE-10281 URL: https://issues.apache.org/jira/browse/LUCENE-10281 Project

[GitHub] [lucene] gf2121 commented on a change in pull request #438: LUCENE-10233: Store docIds as bitset to speed up addAll

2021-12-02 Thread GitBox
gf2121 commented on a change in pull request #438: URL: https://github.com/apache/lucene/pull/438#discussion_r761691414 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/DocIdsWriter.java ## @@ -18,23 +18,32 @@ import java.io.IOException; import org.apache.lucen

[jira] [Updated] (LUCENE-10280) Store BKD blocks with continuous ids more efficiently

2021-12-02 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Guo updated LUCENE-10280: -- Description: For scenes that index is sorted on the field, blocks with continuous ids may be a commo

  1   2   >