dweiss commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-984461544
> There was invisible directory .gradle under dev-tools/missing-doclet/bin/. I'm not sure when the directory was created. Typically such directories are created by IDEs (intellij). jgit detects it as a change - git ignores empty directories. There is little I can do about it (it does signal a problem so I don't really consider it a bug). > I was thinking about some extension, so we can add some source annotation or marker file in the package directory and the build script exclude some package from the exports clause and the snippet for the module-info is autogenerated I actually like an explicit module-info file. It shows you how the module is structured and it's a common API people are (or eventually will be) used to. Custom annotations will make things more obscure and complicated - for example for IDEs. Before we start complicating things with generation, let's just make it work by creating corresponding files manually and adding cross-checks to make sure they're in sync - I plan to add service-provider layer checks later today; we'll see how it turns out (but I think it'll be just fine). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
