iverase commented on a change in pull request #486:
URL: https://github.com/apache/lucene/pull/486#discussion_r761252070
##########
File path:
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java
##########
@@ -505,80 +504,29 @@ public long size() {
}
@Override
- public void visitDocIDs(PointValues.IntersectVisitor visitor) throws
IOException {
+ public void visitDocIDs(PointValues.DocIdsVisitor docIdsVisitor) throws
IOException {
checkAndThrow();
- in.visitDocIDs(visitor);
+ in.visitDocIDs(
+ docID -> {
+ checkAndThrowWithSampling();
Review comment:
yes, we should take a closer look here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
