uschindler commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-984774533
Hi @mocobeta: Please remove all "uses" statements in all modules, except in "org.apache.lucene.core" module. I have seen that you added it to the scaffold tool. "uses" means that the services are consumed by ServiceLoader. The modules who provide them are not using them. Lucene reads the services only in "core" by calling ServiceLoader. The code for that is all in core: `NamedSPILoader` (used by codec components) and in `AnalysisSPILoader`. We don't load services anywhere else! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
