mdmarshmallow opened a new pull request #509: URL: https://github.com/apache/lucene/pull/509
<!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Lucene: * https://issues.apache.org/jira/projects/LUCENE You will need to create an account in Jira in order to create an issue. The title of the PR should reference the Jira issue number in the form: * LUCENE-####: <short description of problem or changes> LUCENE must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description Currently, SSDV faceting doesn't support hierarchical labels with a hierarchy of greater than 2. This change enables hierarchical labels of arbitrary length with SSDV faceting. # Solution In `SortedSetDocValuesReaderState`, I created a tree data structure called `HierarchicalOrdRange` that maintains all the labels added, storing the ordinal ranges of each label as well as references to child labels. This replaces the current `Map<String, OrdRange>` data structure that maps each dimension to its ordinal range. The `HierarchicalOrdRange` data structure is populated in `DefaultSortedSetDocValuesReaderState` and is then read in `SortedSetDocValuesFacetCounts` and `ConcurrentSortedSetDocValuesCounts` in order to get ranges of arbitrary length labels efficiently. # Tests * Created `TestHierarchicalOrdRange` to test `HierarchicalOrdRange` data structure * Added length > 2 labels to tests in `TestSortedSetDocValuesFacets` test class # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [X] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [X] I have developed this patch against the `main` branch. - [X] I have run `./gradlew check`. - [X] I have added tests for my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
