sonatype-lift[bot] commented on a change in pull request #486:
URL: https://github.com/apache/lucene/pull/486#discussion_r761358324
##########
File path:
lucene/test-framework/src/java/org/apache/lucene/index/BasePointsFormatTestCase.java
##########
@@ -1070,29 +1071,13 @@ private void assertSize(PointValues.PointTree tree)
throws IOException {
tree = rarely() ? clone : tree;
final long[] visitDocIDSize = new long[] {0};
final long[] visitDocValuesSize = new long[] {0};
- final IntersectVisitor visitor =
- new IntersectVisitor() {
- @Override
- public void visit(int docID) {
- visitDocIDSize[0]++;
- }
- @Override
- public void visit(int docID, byte[] packedValue) {
- visitDocValuesSize[0]++;
- }
-
- @Override
- public Relation compare(byte[] minPackedValue, byte[]
maxPackedValue) {
- return Relation.CELL_CROSSES_QUERY;
- }
- };
if (random().nextBoolean()) {
- tree.visitDocIDs(visitor);
- tree.visitDocValues(visitor);
+ tree.visitDocIDs((docID -> visitDocIDSize[0]++));
+ tree.visitDocValues((docID, packedValue) -> visitDocValuesSize[0]++);
} else {
- tree.visitDocValues(visitor);
- tree.visitDocIDs(visitor);
+ tree.visitDocValues((docID, packedValue) -> visitDocValuesSize[0]++);
+ tree.visitDocIDs((docID -> visitDocIDSize[0]++));
Review comment:
*UnnecessaryParentheses:* Unnecessary use of grouping parentheses
[(details)](https://errorprone.info/bugpattern/UnnecessaryParentheses)
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with
`help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
