[GitHub] [lucene] jpountz commented on a change in pull request #262: LUCENE-10063: implement SimpleTextKnnvectorsReader.search

2021-08-26 Thread GitBox
jpountz commented on a change in pull request #262: URL: https://github.com/apache/lucene/pull/262#discussion_r696363685 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextKnnVectorsReader.java ## @@ -140,7 +147,38 @@ public VectorValues getVect

[GitHub] [lucene] jpountz merged pull request #260: LUCENE-9613, LUCENE-10067: Further specialize ordinals.

2021-08-26 Thread GitBox
jpountz merged pull request #260: URL: https://github.com/apache/lucene/pull/260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (LUCENE-9613) Create blocks for ords when it helps in Lucene80DocValuesFormat

2021-08-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405028#comment-17405028 ] ASF subversion and git services commented on LUCENE-9613: - Commi

[jira] [Commented] (LUCENE-10067) investigate 6/23/2021 -> 6/24/2021 drop in facets perf

2021-08-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405029#comment-17405029 ] ASF subversion and git services commented on LUCENE-10067: -- Co

[jira] [Commented] (LUCENE-9990) Tracking issue for Gradle upgrade to 7.2

2021-08-26 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405034#comment-17405034 ] Dawid Weiss commented on LUCENE-9990: - I actually ran those already. One of the gene

[jira] [Commented] (LUCENE-9990) Tracking issue for Gradle upgrade to 7.2

2021-08-26 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405039#comment-17405039 ] Uwe Schindler commented on LUCENE-9990: --- Hi, Jenkins seems Happy on Windows, Linux

[jira] [Commented] (LUCENE-9990) Tracking issue for Gradle upgrade to 7.2

2021-08-26 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405043#comment-17405043 ] Dawid Weiss commented on LUCENE-9990: - Everything works up to JDK16 -- I'll commit L

[GitHub] [lucene] dweiss commented on pull request #259: LUCENE-10066: Build does not work with JDK16 as gradle's runtime

2021-08-26 Thread GitBox
dweiss commented on pull request #259: URL: https://github.com/apache/lucene/pull/259#issuecomment-906189898 Things are always easy, once solved. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene] dweiss merged pull request #259: LUCENE-10066: Build does not work with JDK16 as gradle's runtime

2021-08-26 Thread GitBox
dweiss merged pull request #259: URL: https://github.com/apache/lucene/pull/259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Resolved] (LUCENE-10066) Build does not work with JDK16 as gradle's runtime

2021-08-26 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10066. -- Fix Version/s: main (9.0) Assignee: Dawid Weiss Resolution: Fixed > Build doe

[jira] [Commented] (LUCENE-10066) Build does not work with JDK16 as gradle's runtime

2021-08-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405045#comment-17405045 ] ASF subversion and git services commented on LUCENE-10066: -- Co

[jira] [Created] (LUCENE-10072) Regenerate FST dictionaries (they're out of sync)

2021-08-26 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10072: Summary: Regenerate FST dictionaries (they're out of sync) Key: LUCENE-10072 URL: https://issues.apache.org/jira/browse/LUCENE-10072 Project: Lucene - Core I

[jira] [Commented] (LUCENE-10072) Regenerate FST dictionaries (they're out of sync)

2021-08-26 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405063#comment-17405063 ] Dawid Weiss commented on LUCENE-10072: -- The change is due to: LUCENE-9047: Directo

[GitHub] [lucene] dweiss merged pull request #265: LUCENE-10072: Regenerate FST dictionaries after LUCENE-9047.

2021-08-26 Thread GitBox
dweiss merged pull request #265: URL: https://github.com/apache/lucene/pull/265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Commented] (LUCENE-10072) Regenerate FST dictionaries (they're out of sync)

2021-08-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405095#comment-17405095 ] ASF subversion and git services commented on LUCENE-10072: -- Co

[jira] [Commented] (LUCENE-9047) Directory APIs should be little endian

2021-08-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405096#comment-17405096 ] ASF subversion and git services commented on LUCENE-9047: - Commi

[jira] [Resolved] (LUCENE-10072) Regenerate FST dictionaries (they're out of sync)

2021-08-26 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10072. -- Fix Version/s: main (9.0) Resolution: Fixed > Regenerate FST dictionaries (they're out

[jira] [Commented] (LUCENE-10068) Switch to a "double barrel" HPPC cache for the taxonomy LRU cache

2021-08-26 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405108#comment-17405108 ] Gautam Worah commented on LUCENE-10068: --- Some history here: We previously had a[

[jira] [Comment Edited] (LUCENE-10068) Switch to a "double barrel" HPPC cache for the taxonomy LRU cache

2021-08-26 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405108#comment-17405108 ] Gautam Worah edited comment on LUCENE-10068 at 8/26/21, 9:48 AM:

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-26 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r696495553 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +348,140 @@ public FacetLabe

[GitHub] [lucene] mikemccand commented on pull request #264: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals (instead of custom binary format)

2021-08-26 Thread GitBox
mikemccand commented on pull request #264: URL: https://github.com/apache/lucene/pull/264#issuecomment-906312429 > In benchmarks, using numeric doc values to store taxonomy facet ordinals shows almost a 400% qps improvement in browse-related taxonomy-based tasks (instead of custom delta-en

[GitHub] [lucene] mikemccand commented on a change in pull request #264: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals (instead of custom binary format)

2021-08-26 Thread GitBox
mikemccand commented on a change in pull request #264: URL: https://github.com/apache/lucene/pull/264#discussion_r696530876 ## File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java ## @@ -410,7 +411,16 @@ private void processFacetFields( // Facet c

[GitHub] [lucene] mikemccand commented on pull request #264: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals (instead of custom binary format)

2021-08-26 Thread GitBox
mikemccand commented on pull request #264: URL: https://github.com/apache/lucene/pull/264#issuecomment-906343623 I think a simple approach for the back-compat is to switch on `SegmentInfos.getIndexCreatedVersionMajor()`. If the index was created pre-8.10, then we use the legacy encoding (

[GitHub] [lucene] jpountz commented on a change in pull request #264: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals (instead of custom binary format)

2021-08-26 Thread GitBox
jpountz commented on a change in pull request #264: URL: https://github.com/apache/lucene/pull/264#discussion_r696569831 ## File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java ## @@ -410,7 +411,16 @@ private void processFacetFields( // Facet coun

[jira] [Created] (LUCENE-10073) Allow very small merges to merge more than segmentsPerTier segments?

2021-08-26 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10073: - Summary: Allow very small merges to merge more than segmentsPerTier segments? Key: LUCENE-10073 URL: https://issues.apache.org/jira/browse/LUCENE-10073 Project: Luc

[jira] [Commented] (LUCENE-9917) Reduce block size for BEST_SPEED

2021-08-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405211#comment-17405211 ] ASF subversion and git services commented on LUCENE-9917: - Commi

[GitHub] [lucene] jpountz merged pull request #257: LUCENE-9917: Smaller block sizes for BEST_SPEED.

2021-08-26 Thread GitBox
jpountz merged pull request #257: URL: https://github.com/apache/lucene/pull/257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [lucene] gsmiller merged pull request #261: LUCENE-10060: Ensure DrillSidewaysQuery instances never get cached

2021-08-26 Thread GitBox
gsmiller merged pull request #261: URL: https://github.com/apache/lucene/pull/261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [lucene] gsmiller commented on pull request #261: LUCENE-10060: Ensure DrillSidewaysQuery instances never get cached

2021-08-26 Thread GitBox
gsmiller commented on pull request #261: URL: https://github.com/apache/lucene/pull/261#issuecomment-906397479 Thanks @zacharymorn for the quick review and double-checking the fix against your PR! -- This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Commented] (LUCENE-10060) Ensure DrillSidewaysQuery instances don't get cached

2021-08-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405215#comment-17405215 ] ASF subversion and git services commented on LUCENE-10060: -- Co

[GitHub] [lucene-solr] colvinco commented on pull request #2560: SOLR-15410: Always use -Xverbosegclog for OpenJ9

2021-08-26 Thread GitBox
colvinco commented on pull request #2560: URL: https://github.com/apache/lucene-solr/pull/2560#issuecomment-906404688 @epugh fyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Commented] (LUCENE-10062) Explore using SORTED_NUMERIC doc values to encode taxonomy ordinals for faceting

2021-08-26 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405218#comment-17405218 ] Greg Miller commented on LUCENE-10062: -- Hmm, so I ran an internal benchmarking too

[GitHub] [lucene-solr] gsmiller opened a new pull request #2561: LUCENE-10060: Ensure DrillSidewaysQuery instances never get cached

2021-08-26 Thread GitBox
gsmiller opened a new pull request #2561: URL: https://github.com/apache/lucene-solr/pull/2561 Backport of a bug fix from `main` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [lucene] wuda0112 commented on pull request #224: LUCENE-10035: Simple text codec add multi level skip list data

2021-08-26 Thread GitBox
wuda0112 commented on pull request #224: URL: https://github.com/apache/lucene/pull/224#issuecomment-906430050 > This looks good to me. Since we don't need to encode these numbers differently maybe we could have a single abstract method, e.g. > > MultiLevelSkipListWriter > > `

[GitHub] [lucene-solr] gsmiller merged pull request #2561: LUCENE-10060: Ensure DrillSidewaysQuery instances never get cached

2021-08-26 Thread GitBox
gsmiller merged pull request #2561: URL: https://github.com/apache/lucene-solr/pull/2561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[jira] [Resolved] (LUCENE-10060) Ensure DrillSidewaysQuery instances don't get cached

2021-08-26 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller resolved LUCENE-10060. -- Fix Version/s: 8.10 main (9.0) Resolution: Fixed > Ensure DrillSide

[jira] [Commented] (LUCENE-10060) Ensure DrillSidewaysQuery instances don't get cached

2021-08-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405242#comment-17405242 ] ASF subversion and git services commented on LUCENE-10060: -- Co

[jira] [Commented] (LUCENE-9917) Reduce block size for BEST_SPEED

2021-08-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405244#comment-17405244 ] ASF subversion and git services commented on LUCENE-9917: - Commi

[GitHub] [lucene] jpountz commented on pull request #224: LUCENE-10035: Simple text codec add multi level skip list data

2021-08-26 Thread GitBox
jpountz commented on pull request #224: URL: https://github.com/apache/lucene/pull/224#issuecomment-906442903 Ah, I see what you mean. Let's ignore my suggestion then and go with your initial suggestion. -- This is an automated message from the Apache Git Service. To respond to the messa

[jira] [Resolved] (LUCENE-9917) Reduce block size for BEST_SPEED

2021-08-26 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-9917. -- Fix Version/s: 8.10 Resolution: Fixed > Reduce block size for BEST_SPEED >

[jira] [Commented] (LUCENE-9917) Reduce block size for BEST_SPEED

2021-08-26 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405249#comment-17405249 ] Adrien Grand commented on LUCENE-9917: -- Thank you [~rcmuir]! > Reduce block size f

[GitHub] [lucene] wuda0112 commented on pull request #224: LUCENE-10035: Simple text codec add multi level skip list data

2021-08-26 Thread GitBox
wuda0112 commented on pull request #224: URL: https://github.com/apache/lucene/pull/224#issuecomment-906451844 Ok , got it. I will keep work on it. Thanks for your patience -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [lucene] xiaoshi2013 removed a comment on pull request #253: LUCENE-10058: fix gradle lucene:benchmark:run error

2021-08-26 Thread GitBox
xiaoshi2013 removed a comment on pull request #253: URL: https://github.com/apache/lucene/pull/253#issuecomment-905706189 > Thanks @xiaoshi2013! Could you also open a backport PR against [`branch_8x` in `lucene-solr` github repository](https://github.com/apache/lucene-solr/tree/branch_8x)?

[GitHub] [lucene-solr] xiaoshi2013 commented on pull request #2559: LUCENE-10051 Fix lucene branch_8x run ant run-task error

2021-08-26 Thread GitBox
xiaoshi2013 commented on pull request #2559: URL: https://github.com/apache/lucene-solr/pull/2559#issuecomment-906463308 Hi @mikemccand As you suggested, I have also submitted a PR for lucene_8x: LUCENE-10051. -- This is an automated message from the Apache Git Service. To respon

[jira] [Commented] (LUCENE-10060) Ensure DrillSidewaysQuery instances don't get cached

2021-08-26 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405269#comment-17405269 ] Adrien Grand commented on LUCENE-10060: --- bq. I assume what's going on here is th

[GitHub] [lucene-solr] mikemccand commented on pull request #2559: LUCENE-10051 Fix lucene branch_8x run ant run-task error

2021-08-26 Thread GitBox
mikemccand commented on pull request #2559: URL: https://github.com/apache/lucene-solr/pull/2559#issuecomment-906475832 Awesome, thanks! I'll review and push. Mike McCandless http://blog.mikemccandless.com On Thu, Aug 26, 2021 at 10:28 AM xiaoshi ***@***.***> wrote:

[jira] [Commented] (LUCENE-10060) Ensure DrillSidewaysQuery instances don't get cached

2021-08-26 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405278#comment-17405278 ] Adrien Grand commented on LUCENE-10060: --- [~gsmiller] Your recent push seems to be

[GitHub] [lucene] msokolov commented on a change in pull request #262: LUCENE-10063: implement SimpleTextKnnvectorsReader.search

2021-08-26 Thread GitBox
msokolov commented on a change in pull request #262: URL: https://github.com/apache/lucene/pull/262#discussion_r696706087 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextKnnVectorsReader.java ## @@ -140,7 +147,38 @@ public VectorValues getVec

[GitHub] [lucene] jpountz commented on a change in pull request #262: LUCENE-10063: implement SimpleTextKnnvectorsReader.search

2021-08-26 Thread GitBox
jpountz commented on a change in pull request #262: URL: https://github.com/apache/lucene/pull/262#discussion_r696747416 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextKnnVectorsReader.java ## @@ -140,7 +145,36 @@ public VectorValues getVect

[GitHub] [lucene] rmuir commented on a change in pull request #264: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals (instead of custom binary format)

2021-08-26 Thread GitBox
rmuir commented on a change in pull request #264: URL: https://github.com/apache/lucene/pull/264#discussion_r696756609 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/DocValuesOrdinalsReader.java ## @@ -59,16 +53,21 @@ public void get(int docID, IntsRef or

[GitHub] [lucene] rmuir commented on a change in pull request #264: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals (instead of custom binary format)

2021-08-26 Thread GitBox
rmuir commented on a change in pull request #264: URL: https://github.com/apache/lucene/pull/264#discussion_r696757277 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/DocValuesOrdinalsReader.java ## @@ -59,16 +53,21 @@ public void get(int docID, IntsRef or

[GitHub] [lucene] mayya-sharipova opened a new pull request #267: Handle hierarchy in graph construction and search

2021-08-26 Thread GitBox
mayya-sharipova opened a new pull request #267: URL: https://github.com/apache/lucene/pull/267 This patch handles hierarchy in graph construction and search, but only in memory. Work left for future: handle hierarchy on disk -- This is an automated message from the Apache Git Se

[GitHub] [lucene-solr] epugh merged pull request #2560: SOLR-15410: Always use -Xverbosegclog for OpenJ9

2021-08-26 Thread GitBox
epugh merged pull request #2560: URL: https://github.com/apache/lucene-solr/pull/2560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[GitHub] [lucene] gsmiller commented on a change in pull request #264: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals (instead of custom binary format)

2021-08-26 Thread GitBox
gsmiller commented on a change in pull request #264: URL: https://github.com/apache/lucene/pull/264#discussion_r696806470 ## File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java ## @@ -410,7 +411,16 @@ private void processFacetFields( // Facet cou

[GitHub] [lucene] gsmiller commented on a change in pull request #264: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals (instead of custom binary format)

2021-08-26 Thread GitBox
gsmiller commented on a change in pull request #264: URL: https://github.com/apache/lucene/pull/264#discussion_r696809143 ## File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java ## @@ -410,7 +411,16 @@ private void processFacetFields( // Facet cou

[GitHub] [lucene] gsmiller commented on a change in pull request #264: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals (instead of custom binary format)

2021-08-26 Thread GitBox
gsmiller commented on a change in pull request #264: URL: https://github.com/apache/lucene/pull/264#discussion_r696810061 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/DocValuesOrdinalsReader.java ## @@ -41,12 +40,7 @@ public DocValuesOrdinalsReader(Stri

[GitHub] [lucene] jtibshirani commented on a change in pull request #262: LUCENE-10063: implement SimpleTextKnnvectorsReader.search

2021-08-26 Thread GitBox
jtibshirani commented on a change in pull request #262: URL: https://github.com/apache/lucene/pull/262#discussion_r696839771 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextKnnVectorsReader.java ## @@ -140,7 +147,38 @@ public VectorValues get

[GitHub] [lucene] jtibshirani commented on a change in pull request #262: LUCENE-10063: implement SimpleTextKnnvectorsReader.search

2021-08-26 Thread GitBox
jtibshirani commented on a change in pull request #262: URL: https://github.com/apache/lucene/pull/262#discussion_r696842465 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextKnnVectorsReader.java ## @@ -140,7 +147,38 @@ public VectorValues get

[jira] [Resolved] (LUCENE-10067) investigate 6/23/2021 -> 6/24/2021 drop in facets perf

2021-08-26 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10067. --- Fix Version/s: main (9.0) Resolution: Fixed New benchmark results look good: https:/

[jira] [Commented] (LUCENE-10060) Ensure DrillSidewaysQuery instances don't get cached

2021-08-26 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405441#comment-17405441 ] Greg Miller commented on LUCENE-10060: -- [~jpountz] thanks for the heads up. I'll d

[jira] [Commented] (LUCENE-10060) Ensure DrillSidewaysQuery instances don't get cached

2021-08-26 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405449#comment-17405449 ] Greg Miller commented on LUCENE-10060: -- OK, I think I actually broke the tests, no

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-26 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r696969300 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +349,139 @@ public FacetLabe

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-26 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r696973661 ## File path: lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestDirectoryTaxonomyReader.java ## @@ -567,4 +567,39 @@ public void te

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-26 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r696973661 ## File path: lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestDirectoryTaxonomyReader.java ## @@ -567,4 +567,39 @@ public void te

[jira] [Comment Edited] (LUCENE-10033) Encode doc values in smaller blocks of values, like postings

2021-08-26 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405467#comment-17405467 ] Greg Miller edited comment on LUCENE-10033 at 8/26/21, 9:07 PM: -

[jira] [Commented] (LUCENE-10033) Encode doc values in smaller blocks of values, like postings

2021-08-26 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405467#comment-17405467 ] Greg Miller commented on LUCENE-10033: -- [~weizijun] thanks for running this! The "

[jira] [Commented] (LUCENE-9969) DirectoryTaxonomyReader.taxoArray占用内存较大导致系统OOM宕机

2021-08-26 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405470#comment-17405470 ] Greg Miller commented on LUCENE-9969: - [~chengfengfeng] glad you were able to find a

[jira] [Resolved] (LUCENE-9969) DirectoryTaxonomyReader.taxoArray占用内存较大导致系统OOM宕机

2021-08-26 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller resolved LUCENE-9969. - Resolution: Information Provided > DirectoryTaxonomyReader.taxoArray占用内存较大导致系统OOM宕机 > --

[jira] [Commented] (LUCENE-10067) investigate 6/23/2021 -> 6/24/2021 drop in facets perf

2021-08-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405480#comment-17405480 ] Robert Muir commented on LUCENE-10067: -- Thank you [~jpountz], now we are better of

[GitHub] [lucene-solr] damianparus closed pull request #175: Skipping merger

2021-08-26 Thread GitBox
damianparus closed pull request #175: URL: https://github.com/apache/lucene-solr/pull/175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-u

[GitHub] [lucene] gsmiller merged pull request #268: Fix a DrillSideways unit test I broke when adding more tests in LUCENE-10060

2021-08-26 Thread GitBox
gsmiller merged pull request #268: URL: https://github.com/apache/lucene/pull/268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (LUCENE-10060) Ensure DrillSidewaysQuery instances don't get cached

2021-08-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405481#comment-17405481 ] ASF subversion and git services commented on LUCENE-10060: -- Co

[GitHub] [lucene-solr] gsmiller merged pull request #2562: Fix a DrillSideways unit test I broke when adding more tests in LUCENE-10060

2021-08-26 Thread GitBox
gsmiller merged pull request #2562: URL: https://github.com/apache/lucene-solr/pull/2562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[jira] [Commented] (LUCENE-10060) Ensure DrillSidewaysQuery instances don't get cached

2021-08-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405483#comment-17405483 ] ASF subversion and git services commented on LUCENE-10060: -- Co

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-26 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r697014864 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +348,140 @@ public FacetLabe

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-26 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r696973661 ## File path: lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestDirectoryTaxonomyReader.java ## @@ -567,4 +567,39 @@ public void te

[jira] [Commented] (LUCENE-10059) Assertion error in JapaneseTokenizer backtrace

2021-08-26 Thread Anh Dung Bui (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405507#comment-17405507 ] Anh Dung Bui commented on LUCENE-10059: --- Since both of them are depending on anal

[GitHub] [lucene] sonatype-lift[bot] commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-26 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r697042596 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +348,140 @@ public Face

[GitHub] [lucene] gsmiller commented on a change in pull request #240: LUCENE-10002: Deprecate IndexSearch#search(Query, Collector) in favor of IndexSearcher#search(Query, CollectorManager)

2021-08-26 Thread GitBox
gsmiller commented on a change in pull request #240: URL: https://github.com/apache/lucene/pull/240#discussion_r697046771 ## File path: lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/ReadTask.java ## @@ -180,6 +185,7 @@ protected int withTopDocs(IndexSearch

[GitHub] [lucene] gsmiller commented on a change in pull request #240: LUCENE-10002: Deprecate IndexSearch#search(Query, Collector) in favor of IndexSearcher#search(Query, CollectorManager)

2021-08-26 Thread GitBox
gsmiller commented on a change in pull request #240: URL: https://github.com/apache/lucene/pull/240#discussion_r697047554 ## File path: lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java ## @@ -527,7 +503,10 @@ public TopDocs search(Query query, int n) throws IOE

[GitHub] [lucene] gsmiller commented on a change in pull request #240: LUCENE-10002: Deprecate IndexSearch#search(Query, Collector) in favor of IndexSearcher#search(Query, CollectorManager)

2021-08-26 Thread GitBox
gsmiller commented on a change in pull request #240: URL: https://github.com/apache/lucene/pull/240#discussion_r697049547 ## File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollectorManager.java ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software F

[jira] [Commented] (LUCENE-10060) Ensure DrillSidewaysQuery instances don't get cached

2021-08-26 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405515#comment-17405515 ] Greg Miller commented on LUCENE-10060: -- [~jpountz] agreed that it would be nice to

[jira] [Created] (LUCENE-10074) Remove unneeded default value assignment

2021-08-26 Thread Zach Chen (Jira)
Zach Chen created LUCENE-10074: -- Summary: Remove unneeded default value assignment Key: LUCENE-10074 URL: https://issues.apache.org/jira/browse/LUCENE-10074 Project: Lucene - Core Issue Type: Ta

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index check across segments

2021-08-26 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r697140951 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -3622,6 +3860,7 @@ public static void main(String[] args) throws IOExce

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index check across segments

2021-08-26 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r697140979 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -605,209 +681,115 @@ public Status checkIndex(List onlySegments) throws

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index check across segments

2021-08-26 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r697141222 ## File path: lucene/test-framework/src/java/org/apache/lucene/store/MockDirectoryWrapper.java ## @@ -895,7 +895,11 @@ public synchronized void close()

[GitHub] [lucene] zacharymorn commented on a change in pull request #240: LUCENE-10002: Deprecate IndexSearch#search(Query, Collector) in favor of IndexSearcher#search(Query, CollectorManager)

2021-08-26 Thread GitBox
zacharymorn commented on a change in pull request #240: URL: https://github.com/apache/lucene/pull/240#discussion_r697150848 ## File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollectorManager.java ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [lucene] zacharymorn commented on a change in pull request #240: LUCENE-10002: Deprecate IndexSearch#search(Query, Collector) in favor of IndexSearcher#search(Query, CollectorManager)

2021-08-26 Thread GitBox
zacharymorn commented on a change in pull request #240: URL: https://github.com/apache/lucene/pull/240#discussion_r697155622 ## File path: lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/ReadTask.java ## @@ -180,6 +185,7 @@ protected int withTopDocs(IndexSea

[GitHub] [lucene] wuda0112 commented on pull request #224: LUCENE-10035: Simple text codec add multi level skip list data

2021-08-26 Thread GitBox
wuda0112 commented on pull request #224: URL: https://github.com/apache/lucene/pull/224#issuecomment-906934607 Now, there has no binary content gets written to the file ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us