gsmiller commented on a change in pull request #240:
URL: https://github.com/apache/lucene/pull/240#discussion_r697046771
##########
File path:
lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/ReadTask.java
##########
@@ -180,6 +185,7 @@ protected int withTopDocs(IndexSearcher searcher, Query q,
TopDocs hits) throws
return res;
}
+ @Deprecated
Review comment:
I was more thinking along the lines of keeping the change you had but
providing a protected method that would allow sub-classes to provide their own
`CollectorManager` if they wanted to do so (which would give users a migration
path if they were previously providing their own `Collector`). So in 9.0, I
think you'd move completely to the `CollectorManager` approach like you had.
What do you think of that approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
