gsmiller commented on a change in pull request #264: URL: https://github.com/apache/lucene/pull/264#discussion_r696810061
########## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/DocValuesOrdinalsReader.java ########## @@ -41,12 +40,7 @@ public DocValuesOrdinalsReader(String field) { @Override public OrdinalsSegmentReader getReader(LeafReaderContext context) throws IOException { Review comment: Yeah, we can definitely simplify this. I took the path of least resistance as a first cut for testing impact, but I'll work on simplifying and cleaning this up. Thanks for the suggestion! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org