gsmiller commented on a change in pull request #264:
URL: https://github.com/apache/lucene/pull/264#discussion_r696809143
##########
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##########
@@ -410,7 +411,16 @@ private void processFacetFields(
// Facet counts:
// DocValues are considered stored fields:
- doc.add(new BinaryDocValuesField(indexFieldName,
dedupAndEncode(ordinals.get())));
+ IntsRef o = ordinals.get();
+ Arrays.sort(o.ints, o.offset, o.length);
Review comment:
Thanks for the catch! I lifted this from the old code, which looks like
it was also doing this incorrectly (apologies for the oversight!). I'll for
sure correct it. Looks like we were never burned by this since
`IntsRefBuilder#get` asserts that the offset is always 0... :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
