[
https://issues.apache.org/jira/browse/LUCENE-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405278#comment-17405278
]
Adrien Grand commented on LUCENE-10060:
---------------------------------------
[~gsmiller] Your recent push seems to be triggering test failures on main and
branch_8x, e.g.
{noformat}
gradlew :lucene:facet:test --tests
"org.apache.lucene.facet.TestDrillSideways.testRandom" -Ptests.jvms=4
-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -Ptests.seed=4E66AA89940F75A0
-Ptests.file.encoding=UTF-8
16:37:02 org.apache.lucene.facet.TestDrillSideways > testRandom FAILED
16:37:02 java.lang.AssertionError: expected:<1.4262214> but was:<0.6111962>
16:37:02 at
__randomizedtesting.SeedInfo.seed([4E66AA89940F75A0:3C2A8F86256FC3D3]:0)
16:37:02 at org.junit.Assert.fail(Assert.java:89)
16:37:02 at org.junit.Assert.failNotEquals(Assert.java:835)
16:37:02 at org.junit.Assert.assertEquals(Assert.java:577)
16:37:02 at org.junit.Assert.assertEquals(Assert.java:701)
16:37:02 at
org.apache.lucene.facet.TestDrillSideways.verifyEquals(TestDrillSideways.java:1634)
16:37:02 at
org.apache.lucene.facet.TestDrillSideways.testRandom(TestDrillSideways.java:1304)
16:37:02 at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
16:37:02 at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
16:37:02 at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
16:37:02 at java.base/java.lang.reflect.Method.invoke(Method.java:566)
16:37:02 at
com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1754)
16:37:02 at
com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:942)
16:37:02 at
com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:978)
16:37:02 at
com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:992)
16:37:02 at
org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:44)
16:37:02 at
org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
16:37:02 at
org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
16:37:02 at
org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
16:37:02 at
org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
16:37:02 at org.junit.rules.RunRules.evaluate(RunRules.java:20)
16:37:02 at
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
16:37:02 at
com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:370)
16:37:02 at
com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:819)
16:37:02 at
com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:470)
16:37:02 at
com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:951)
16:37:02 at
com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:836)
16:37:02 at
com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:887)
16:37:02 at
com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:898)
16:37:02 at
org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
16:37:02 at
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
16:37:02 at
org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
16:37:02 at
com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
16:37:02 at
com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
16:37:02 at
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
16:37:02 at
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
16:37:02 at
org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
16:37:02 at
org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
16:37:02 at
org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
16:37:02 at
org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
16:37:02 at
org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
16:37:02 at org.junit.rules.RunRules.evaluate(RunRules.java:20)
16:37:02 at
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
16:37:02 at
com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:370)
16:37:02 at
com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:826)
16:37:02 at java.base/java.lang.Thread.run(Thread.java:834)
{noformat}
> Ensure DrillSidewaysQuery instances don't get cached
> ----------------------------------------------------
>
> Key: LUCENE-10060
> URL: https://issues.apache.org/jira/browse/LUCENE-10060
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/facet
> Reporter: Greg Miller
> Priority: Minor
> Fix For: main (9.0), 8.10
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> We need to make sure DSQ instances don't end up in the query cache. -It's
> important that the {{DrillSidewaysScorer}} (bulk scorer implementation)
> actually runs during query evaluation in order to populate the "sideways"
> {{FacetsCollector}} instances with "near miss" docs. If it gets cached, this
> won't happen.-
> There may also be an implication around {{acceptDocs}} getting honored as
> well. [~zacharymorn] may be able to provide more details.
> UPDATE: The original issue I detailed above isn't actually an issue since
> {{DrillDownQuery}} doesn't implement {{equals}}, so the cache always misses
> and it always executes the {{BulkScorer}} ( {{DrillSidewaysScorer}} ).
> Tricky! There is a separate issue found by Zach (as mentioned above) related
> to "acceptDocs" though. See below conversation and link off to the separate
> [PR
> conversation|https://github.com/apache/lucene/pull/240#discussion_r692154001]
> for more details.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
