[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258842#comment-17258842
]
Dawid Weiss commented on LUCENE-9570:
-
Hi [~broustant] - are you working on spatial3
sigram closed pull request #2133:
URL: https://github.com/apache/lucene-solr/pull/2133
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Andrzej Bialecki created SOLR-15068:
---
Summary: RefGuide documentation for replica placement plugins
Key: SOLR-15068
URL: https://issues.apache.org/jira/browse/SOLR-15068
Project: Solr
Issue
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258851#comment-17258851
]
Bruno Roustant commented on LUCENE-9570:
[~dweiss] Yes finally it's done. I push
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258851#comment-17258851
]
Bruno Roustant edited comment on LUCENE-9570 at 1/5/21, 11:51 AM:
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258856#comment-17258856
]
Dawid Weiss commented on LUCENE-9570:
-
Yeah, it's lots of code all right. I'm sorry
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9570:
Description:
Review and correct all the javadocs before they're messed up by automatic
formatting
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258889#comment-17258889
]
ASF subversion and git services commented on LUCENE-9570:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1725#comment-1725
]
ASF subversion and git services commented on LUCENE-9570:
-
Commi
noblepaul opened a new pull request #2177:
URL: https://github.com/apache/lucene-solr/pull/2177
WIP
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-9570.
-
Fix Version/s: master (9.0)
Resolution: Fixed
Thank you, [~erickerickson] and [~broustant
[
https://issues.apache.org/jira/browse/LUCENE-9643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-9643.
-
Fix Version/s: master (9.0)
Resolution: Fixed
> Create .git-blame-ignore-revs file with r
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-9564.
-
Fix Version/s: master (9.0)
Resolution: Fixed
> Format code automatically and enforce it
[
https://issues.apache.org/jira/browse/LUCENE-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258896#comment-17258896
]
Dawid Weiss commented on LUCENE-9563:
-
In all honesty, I don't think this is needed
dweiss closed pull request #2153:
URL: https://github.com/apache/lucene-solr/pull/2153
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
msokolov commented on pull request #2176:
URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-754627642
Uwe, I didn't think that IndexInput would expose its internal ByteBuffers
easily? But you are right about the double-copying - that is why I opened
https://issues.apache.or
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258944#comment-17258944
]
Erick Erickson commented on LUCENE-9570:
Whe! Lucene is done! Now when we fi
muse-dev[bot] commented on a change in pull request #2177:
URL: https://github.com/apache/lucene-solr/pull/2177#discussion_r551961005
##
File path: solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java
##
@@ -1219,17 +1225,28 @@ public void process(WatchedEvent ev
[
https://issues.apache.org/jira/browse/SOLR-15061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258946#comment-17258946
]
ASF subversion and git services commented on SOLR-15061:
Commit 5
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258953#comment-17258953
]
Dawid Weiss commented on LUCENE-9570:
-
Another reason not to change too much is that
[
https://issues.apache.org/jira/browse/SOLR-15061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258961#comment-17258961
]
ASF subversion and git services commented on SOLR-15061:
Commit 5
bruno-roustant closed pull request #2168:
URL: https://github.com/apache/lucene-solr/pull/2168
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
[
https://issues.apache.org/jira/browse/SOLR-15061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant resolved SOLR-15061.
---
Fix Version/s: 8.8
Resolution: Fixed
> Fix NPE in SearchHandler when shards.info
> ---
mcimadamore commented on a change in pull request #2176:
URL: https://github.com/apache/lucene-solr/pull/2176#discussion_r552026775
##
File path:
lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java
##
@@ -0,0 +1,524 @@
+/*
+ * Licensed to the Apache Softw
uschindler commented on a change in pull request #2176:
URL: https://github.com/apache/lucene-solr/pull/2176#discussion_r552031972
##
File path:
lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java
##
@@ -0,0 +1,524 @@
+/*
+ * Licensed to the Apache Softwa
[
https://issues.apache.org/jira/browse/SOLR-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259023#comment-17259023
]
ASF subversion and git services commented on SOLR-14571:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259031#comment-17259031
]
ASF subversion and git services commented on SOLR-14571:
Commit 3
[
https://issues.apache.org/jira/browse/SOLR-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated SOLR-14571:
---
Fix Version/s: master (9.0)
8.8
Assignee: Christine Poersc
[
https://issues.apache.org/jira/browse/SOLR-15048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259052#comment-17259052
]
ASF subversion and git services commented on SOLR-15048:
Commit a
madrob commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r552063218
##
File path:
solr/core/src/java/org/apache/solr/cloud/overseer/CollectionMutator.java
##
@@ -107,10 +111,24 @@ public ZkWriteCommand modifyCollection
madrob commented on pull request #2177:
URL: https://github.com/apache/lucene-solr/pull/2177#issuecomment-754810146
Please note that there are still a lot of outstanding comments on the 8x
version of this PR, I worry that you are going to end up doing double work
trying to maintain two pat
thelabdude opened a new pull request #2178:
URL: https://github.com/apache/lucene-solr/pull/2178
# Description
See: https://issues.apache.org/jira/browse/SOLR-15058
# Solution
The current impl. of `Utils#getBaseUrlForNodeName` would create the wrong
URL if the hostname
thelabdude commented on pull request #2164:
URL: https://github.com/apache/lucene-solr/pull/2164#issuecomment-754824054
Hi @Sasasu ... Please close this PR as I've made the changes here:
https://github.com/apache/lucene-solr/pull/2178
Thanks for reporting and your initial PR; I gave
thelabdude merged pull request #2178:
URL: https://github.com/apache/lucene-solr/pull/2178
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
sigram opened a new pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179
See Jira for details.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
[
https://issues.apache.org/jira/browse/SOLR-15048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259174#comment-17259174
]
ASF subversion and git services commented on SOLR-15048:
Commit f
msokolov commented on pull request #2175:
URL: https://github.com/apache/lucene-solr/pull/2175#issuecomment-754862200
I plan to push soon - @uschindler do you have any further comments?
This is an automated message from the A
madrob commented on a change in pull request #2166:
URL: https://github.com/apache/lucene-solr/pull/2166#discussion_r552162552
##
File path:
solr/core/src/java/org/apache/solr/core/DelegatingDirectoryFactory.java
##
@@ -0,0 +1,189 @@
+/*
+ * Licensed to the Apache Software Fou
thelabdude opened a new pull request #2180:
URL: https://github.com/apache/lucene-solr/pull/2180
This is the backport from master to 8x
See original PR: https://github.com/apache/lucene-solr/pull/2178
This is an au
thelabdude merged pull request #2180:
URL: https://github.com/apache/lucene-solr/pull/2180
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
David Smiley created SOLR-15069:
---
Summary: child doc transformer should make parentFilter obsolete
Key: SOLR-15069
URL: https://issues.apache.org/jira/browse/SOLR-15069
Project: Solr
Issue Type
[
https://issues.apache.org/jira/browse/SOLR-15058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy Potter resolved SOLR-15058.
---
Fix Version/s: master (9.0)
8.8
Resolution: Fixed
> Solr can not ge
[
https://issues.apache.org/jira/browse/SOLR-15055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259178#comment-17259178
]
Mike Drob commented on SOLR-15055:
--
I believe maxShardsPerNode limited the total number
dsmiley opened a new pull request #2181:
URL: https://github.com/apache/lucene-solr/pull/2181
https://issues.apache.org/jira/browse/SOLR-15069
Repeated issue description:
The `parentFilter` param to `[child]` was once required, and then made only
optional if you have a `_nest_path_` f
murblanc commented on a change in pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552196761
##
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java
##
@@ -116,6 +121,25 @@ public void call(ClusterStat
dsmiley commented on pull request #2159:
URL: https://github.com/apache/lucene-solr/pull/2159#issuecomment-754901726
I believe everything MUSE_DEV reported is a non-issue. Only one thread
touches any AddUpdateCommand and the SolrInputDoc on it. Perhaps MUSE_DEV saw
the `synchronized` key
[
https://issues.apache.org/jira/browse/SOLR-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259209#comment-17259209
]
ASF subversion and git services commented on SOLR-14608:
Commit a
murblanc commented on a change in pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552193376
##
File path: solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaPosition.java
##
@@ -19,17 +19,20 @@
public class ReplicaPosition implemen
murblanc commented on a change in pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552195844
##
File path:
solr/solrj/src/java/org/apache/solr/common/params/CollectionAdminParams.java
##
@@ -80,6 +80,17 @@
*/
String COLL_CONF = "colle
murblanc commented on a change in pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552201141
##
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java
##
@@ -116,6 +121,25 @@ public void call(ClusterStat
murblanc commented on a change in pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552198751
##
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java
##
@@ -116,6 +121,25 @@ public void call(ClusterStat
murblanc commented on a change in pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552212826
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java
##
@@ -242,6 +260,37 @@ public PlacementPla
murblanc commented on a change in pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552216897
##
File path:
solr/solrj/src/java/org/apache/solr/common/params/CollectionAdminParams.java
##
@@ -80,6 +80,17 @@
*/
String COLL_CONF = "colle
dsmiley commented on pull request #2181:
URL: https://github.com/apache/lucene-solr/pull/2181#issuecomment-754916903
CC @barrotsteindev (anyone CC'ed or really anyone, I'd appreciate a review)
This is an automated message f
murblanc commented on a change in pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552198751
##
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java
##
@@ -116,6 +121,25 @@ public void call(ClusterStat
murblanc commented on a change in pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552215235
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java
##
@@ -242,6 +260,37 @@ public PlacementPla
murblanc commented on a change in pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552208910
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java
##
@@ -193,6 +195,22 @@ public PlacementPla
barrotsteindev commented on pull request #2181:
URL: https://github.com/apache/lucene-solr/pull/2181#issuecomment-754920896
Seems like a great idea.
I think `parentFilter` still has its place when you want to return a part of
a hierarchy where the parent documents are not the root docs(t
murblanc commented on a change in pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552220473
##
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java
##
@@ -254,8 +280,27 @@ public void call(ClusterStat
dsmiley commented on pull request #2181:
URL: https://github.com/apache/lucene-solr/pull/2181#issuecomment-754932185
I was thinking that maybe but I **suspect** (just a theory) the current code
"just works" because it tracks the path information already and builds the
tree. It'd just be a
muse-dev[bot] commented on a change in pull request #2159:
URL: https://github.com/apache/lucene-solr/pull/2159#discussion_r552231540
##
File path:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
##
@@ -76,6 +87,37 @@ public String getName() {
murblanc commented on a change in pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552210621
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java
##
@@ -193,6 +195,22 @@ public PlacementPla
[
https://issues.apache.org/jira/browse/LUCENE-9590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259247#comment-17259247
]
David Smiley commented on LUCENE-9590:
--
It's up to you wether to link to Confluence
[
https://issues.apache.org/jira/browse/SOLR-15048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter resolved SOLR-15048.
---
Fix Version/s: master (9.0)
8.8
Resolution: Fixed
> collaps
murblanc commented on a change in pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552214070
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java
##
@@ -242,6 +260,37 @@ public PlacementPla
murblanc commented on a change in pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552224065
##
File path:
solr/solrj/src/java/org/apache/solr/common/params/CollectionAdminParams.java
##
@@ -80,6 +80,17 @@
*/
String COLL_CONF = "colle
thelabdude commented on pull request #2165:
URL: https://github.com/apache/lucene-solr/pull/2165#issuecomment-754937121
Pinged you for a review @janhoy if you're curious. Also, would appreciate
guidance on updating the default dashboard with these changes once they are
back ported to 8.8.
murblanc commented on a change in pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552226534
##
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java
##
@@ -116,6 +121,25 @@ public void call(ClusterStat
muse-dev[bot] commented on a change in pull request #2165:
URL: https://github.com/apache/lucene-solr/pull/2165#discussion_r552227035
##
File path:
solr/contrib/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/MetricsQueryTemplate.java
##
@@ -0,0 +1,135 @@
+/*
[
https://issues.apache.org/jira/browse/SOLR-15018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259253#comment-17259253
]
David Smiley commented on SOLR-15018:
-
Perhaps we should have a more structured schem
dsmiley commented on a change in pull request #2159:
URL: https://github.com/apache/lucene-solr/pull/2159#discussion_r552241596
##
File path:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
##
@@ -76,6 +87,37 @@ public String getName() {
@Ove
[
https://issues.apache.org/jira/browse/SOLR-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy Potter updated SOLR-15059:
--
Description:
The default Grafana dashboard doesn't expose graphs for monitoring query
performa
[
https://issues.apache.org/jira/browse/SOLR-15058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259193#comment-17259193
]
ASF subversion and git services commented on SOLR-15058:
Commit b
madrob commented on a change in pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552160275
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java
##
@@ -59,13 +59,8 @@
import static org.apache.sol
muse-dev[bot] commented on a change in pull request #2181:
URL: https://github.com/apache/lucene-solr/pull/2181#discussion_r552251280
##
File path:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
##
@@ -76,6 +87,37 @@ public String getName() {
[
https://issues.apache.org/jira/browse/SOLR-15047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter updated SOLR-15047:
--
Attachment: SOLR-15047.patch
Status: Open (was: Open)
With SOLR-15048 fixed, f
Sasasu closed pull request #2164:
URL: https://github.com/apache/lucene-solr/pull/2164
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-15047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter updated SOLR-15047:
--
Attachment: SOLR-15047.patch
Status: Open (was: Open)
> 'collapse' on numeric
thelabdude opened a new pull request #2182:
URL: https://github.com/apache/lucene-solr/pull/2182
See: https://github.com/apache/lucene-solr/pull/2180 ... missed some test
failures
This is an automated message from th
thelabdude merged pull request #2182:
URL: https://github.com/apache/lucene-solr/pull/2182
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/SOLR-15058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259311#comment-17259311
]
ASF subversion and git services commented on SOLR-15058:
Commit e
murblanc commented on pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#issuecomment-754989462
**Blocking issue**: `CreateCollectionCmd` is not the only place where
`withCollection` logic is going to get applied. All calls that end up calling
the placement plugins no
noblepaul commented on pull request #2177:
URL: https://github.com/apache/lucene-solr/pull/2177#issuecomment-755019793
> Please note that there are still a lot of outstanding comments on the 8x
version of this PR, I worry that you are going to end up doing double work
trying to maintain tw
noblepaul commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r552318967
##
File path:
solr/solrj/src/java/org/apache/solr/common/cloud/PerReplicaStates.java
##
@@ -0,0 +1,600 @@
+/*
+ * Licensed to the Apache Software F
noblepaul commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r552319669
##
File path:
solr/solrj/src/java/org/apache/solr/common/cloud/PerReplicaStates.java
##
@@ -0,0 +1,600 @@
+/*
+ * Licensed to the Apache Software F
noblepaul commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r552361214
##
File path:
solr/solrj/src/java/org/apache/solr/common/cloud/PerReplicaStates.java
##
@@ -0,0 +1,587 @@
+/*
+ * Licensed to the Apache Software F
noblepaul commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r552362386
##
File path:
solr/solrj/src/java/org/apache/solr/common/cloud/PerReplicaStates.java
##
@@ -0,0 +1,600 @@
+/*
+ * Licensed to the Apache Software F
noblepaul edited a comment on pull request #2177:
URL: https://github.com/apache/lucene-solr/pull/2177#issuecomment-755019793
> Please note that there are still a lot of outstanding comments on the 8x
version of this PR, I worry that you are going to end up doing double work
trying to main
zacharymorn commented on a change in pull request #2141:
URL: https://github.com/apache/lucene-solr/pull/2141#discussion_r552384800
##
File path: lucene/core/src/java/org/apache/lucene/search/WANDScorer.java
##
@@ -130,10 +130,21 @@ private static long scaleMinScore(float minSc
zacharymorn commented on a change in pull request #2141:
URL: https://github.com/apache/lucene-solr/pull/2141#discussion_r552385395
##
File path:
lucene/core/src/java/org/apache/lucene/search/Boolean2ScorerSupplier.java
##
@@ -230,10 +232,13 @@ private Scorer opt(
for (
[
https://issues.apache.org/jira/browse/SOLR-15064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley reassigned SOLR-15064:
---
Assignee: David Smiley
Description:
In SOLR-14923, doing an atomic/partial update to
zacharymorn commented on a change in pull request #2141:
URL: https://github.com/apache/lucene-solr/pull/2141#discussion_r552385764
##
File path:
lucene/core/src/java/org/apache/lucene/search/Boolean2ScorerSupplier.java
##
@@ -74,11 +74,13 @@ private long computeCost() {
zacharymorn commented on a change in pull request #2141:
URL: https://github.com/apache/lucene-solr/pull/2141#discussion_r552385957
##
File path: lucene/core/src/java/org/apache/lucene/search/WANDScorer.java
##
@@ -447,6 +461,23 @@ private int doNextCompetitiveCandidate() throw
zacharymorn commented on a change in pull request #2141:
URL: https://github.com/apache/lucene-solr/pull/2141#discussion_r552386265
##
File path: lucene/core/src/java/org/apache/lucene/search/WANDScorer.java
##
@@ -447,6 +461,23 @@ private int doNextCompetitiveCandidate() throw
[
https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259437#comment-17259437
]
David Smiley commented on SOLR-14923:
-
To be clear, the PR:
* Atomic/partial updates
zacharymorn commented on pull request #2141:
URL: https://github.com/apache/lucene-solr/pull/2141#issuecomment-755104110
> I left some comments but it looks great in general. Could you add more
tests as well, e.g. a variant of TestWANDScorer#testBasics that configures a
minShouldMatch of 2
96 matches
Mail list logo
